mirror/cypress
1
0
Fork 0
mirror of https://github.com/cypress-io/cypress.git synced 2026-05-24 09:29:35 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix: Require react-dom as a dependency for React projects (#22572)

Browse Source 
* fix: Require react-dom as a dependency for React projects

* fix: Update tests

* fix: Add react-dom as required dependency for Nextjs projects

Co-authored-by: Zachary Williams <ZachJW34@gmail.com>
This commit is contained in:
Adam Stone
2022-06-29 18:05:36 -04:00
committed by GitHub
parent 88b10e8f50
commit 6fefe7d48b
3 changed files with 16 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/data-context/test/unit/sources/WizardDataSource.spec.ts
+3 -3
View File
@@ -27,7 +27,7 @@ describe('packagesToInstall', () => {
const actual = ctx.wizard.installDependenciesCommand()
expect(actual).to.eq(`npm install -D react-scripts webpack react`)
expect(actual).to.eq(`npm install -D react-scripts webpack react-dom react`)
})
it('vueclivue2-unconfigured', async () => {
@@ -91,7 +91,7 @@ describe('packagesToInstall', () => {
const actual = ctx.wizard.installDependenciesCommand()
expect(actual).to.eq(`npm install -D vite react`)
expect(actual).to.eq(`npm install -D vite react react-dom`)
})
it('regular vue project with vite', async () => {
@@ -123,7 +123,7 @@ describe('packagesToInstall', () => {
const actual = ctx.wizard.installDependenciesCommand()
expect(actual).to.eq(`npm install -D next react`)
expect(actual).to.eq(`npm install -D next react react-dom`)
})
it('nuxtjs-vue2-unconfigured', async () => {
packages/scaffold-config/src/dependencies.ts
+10
View File
@@ -34,6 +34,15 @@ export const WIZARD_DEPENDENCY_REACT = {
minVersion: '>=16.x',
} as const
export const WIZARD_DEPENDENCY_REACT_DOM = {
type: 'react-dom',
name: 'React DOM',
package: 'react-dom',
installer: 'react-dom',
description: 'This package serves as the entry point to the DOM and server renderers for React',
minVersion: '>=16.x',
} as const
export const WIZARD_DEPENDENCY_TYPESCRIPT = {
type: 'typescript',
name: 'TypeScript',
@@ -97,6 +106,7 @@ export const WIZARD_DEPENDENCIES = [
WIZARD_DEPENDENCY_NUXT,
WIZARD_DEPENDENCY_NEXT,
WIZARD_DEPENDENCY_REACT,
WIZARD_DEPENDENCY_REACT_DOM,
WIZARD_DEPENDENCY_VUE_2,
WIZARD_DEPENDENCY_VUE_3,
] as const
packages/scaffold-config/src/frameworks.ts
+3
View File
@@ -71,6 +71,7 @@ export const WIZARD_FRAMEWORKS = [
return [
inPkgJson(dependencies.WIZARD_DEPENDENCY_REACT_SCRIPTS, projectPath),
inPkgJson(dependencies.WIZARD_DEPENDENCY_WEBPACK, projectPath),
inPkgJson(dependencies.WIZARD_DEPENDENCY_REACT_DOM, projectPath),
inPkgJson(dependencies.WIZARD_DEPENDENCY_REACT, projectPath),
]
},
@@ -128,6 +129,7 @@ export const WIZARD_FRAMEWORKS = [
return [
inPkgJson(dependencies.WIZARD_DEPENDENCY_NEXT, projectPath),
inPkgJson(dependencies.WIZARD_DEPENDENCY_REACT, projectPath),
inPkgJson(dependencies.WIZARD_DEPENDENCY_REACT_DOM, projectPath),
]
},
codeGenFramework: 'react',
@@ -207,6 +209,7 @@ export const WIZARD_FRAMEWORKS = [
return [
getBundlerDependency(bundler, projectPath),
inPkgJson(dependencies.WIZARD_DEPENDENCY_REACT, projectPath),
inPkgJson(dependencies.WIZARD_DEPENDENCY_REACT_DOM, projectPath),
]
},
codeGenFramework: 'react',