From 7be840efca45a5248a0cd9a34bba8f57938adc52 Mon Sep 17 00:00:00 2001 From: Gleb Bahmutov Date: Tue, 29 Oct 2019 16:10:59 +0100 Subject: [PATCH] =?UTF-8?q?use=20default=20next-dev-version=20if=20not=20s?= =?UTF-8?q?et=20during=20Linux=20binary=20bui=E2=80=A6=20(#5512)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- circle.yml | 5 ++++- scripts/binary/index.coffee | 2 ++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/circle.yml b/circle.yml index cdee560742..9d8e05c737 100644 --- a/circle.yml +++ b/circle.yml @@ -607,7 +607,10 @@ jobs: - run: environment: DEBUG: electron-builder,electron-osx-sign* - command: npm run binary-build -- --platform $PLATFORM --version $NEXT_DEV_VERSION + # if this is a forked pull request, the NEXT_DEV_VERSION environment variable + # won't be set and we will use default version, since we are not going to + # upload the dev binary build anywhere + command: npm run binary-build -- --platform $PLATFORM --version ${NEXT_DEV_VERSION:-0.0.0-development} - run: npm run binary-zip -- --platform $PLATFORM # Cypress binary file should be zipped to cypress.zip - run: ls -l *.zip diff --git a/scripts/binary/index.coffee b/scripts/binary/index.coffee index 6550bc0d70..83f4d6ae66 100644 --- a/scripts/binary/index.coffee +++ b/scripts/binary/index.coffee @@ -139,9 +139,11 @@ deploy = { build: (options) -> console.log('#build') options ?= @parseOptions(process.argv) + debug("parsed build options %o", options) askMissingOptions(['version', 'platform'])(options) .then -> + debug("building binary: platform %s version %s", options.platform, options.version) build(options.platform, options.version, options) zip: (options) ->