Upgrade to electron 2.0.18 and node 8.9.3 (#4001)

* upgrade to electron 2.0.18 and node 8.9.3

* use cypress/browsers:node8.9.3-chrome73 docker image

* fix type_spec for chrome

* Revert "fix type_spec for chrome"

This reverts commit 7914f68142.

* fix driver specs for chrome

* update engines to 8.9.3


Co-authored-by: Ben Kucera <14625260+Bkucera@users.noreply.github.com>
Co-authored-by: Brian Mann <brian.mann86@gmail.com>

.node-version

@@ -1 +1 @@
-8.2.1
+8.9.3

appveyor.yml

@@ -6,8 +6,8 @@ branches:
 
 # https://www.appveyor.com/docs/lang/nodejs-iojs/
 environment:
-  # use latest version of Node 8 with NPM 6
-  nodejs_version: "8.2.1"
+  # use matching version of Node.js
+  nodejs_version: "8.9.3"
   # encode secure variables which will NOT be used
   # in pull requests
   # https://www.appveyor.com/docs/build-configuration/#secure-variables

circle.yml

@@ -23,7 +23,7 @@ executors:
   # the Docker image with Cypress dependencies and Chrome browser
   cy-doc:
     docker:
-      - image: cypress/browsers:chrome64
+      - image: cypress/browsers:node8.9.3-chrome73
     environment:
       PLATFORM: linux
 

package.json

@@ -5,7 +5,7 @@
   "description": "Cypress.io end to end testing tool",
   "private": true,
   "engines": {
-    "node": ">=8.2.1"
+    "node": ">=8.9.3"
   },
   "scripts": {
     "prestart": "npm run check-deps-pre",

packages/electron/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@packages/electron",
   "version": "0.0.0",
-  "electronVersion": "1.8.2",
+  "electronVersion": "2.0.18",
   "private": true,
   "main": "index.js",
   "scripts": {

scripts/run-docker-local.sh

@@ -2,7 +2,7 @@ set e+x
 
 echo "This script should be run from cypress's root"
 
-name=cypress/browsers:chrome64
+name=cypress/browsers:node8.9.3-chrome73
 echo "Pulling CI container $name"
 
 docker pull $name