chore(deps): update dependency supertest to version .x 🌟 (#4154)

* chore(deps): update supertest to 4.0.2 🌟

* remove deprecated 'supertest-as-promised' + update supertest-session

* fix linting error


Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Jennifer Shehane <jennifer@cypress.io>

packages/https-proxy/package.json

@@ -29,8 +29,7 @@
     "sinon": "1.17.7",
     "sinon-as-promised": "4.0.3",
     "sinon-chai": "3.3.0",
-    "supertest": "1.2.0",
-    "supertest-as-promised": "3.2.0"
+    "supertest": "4.0.2"
   },
   "dependencies": {
     "bluebird": "3.5.3",

packages/https-proxy/test/spec_helper.coffee

@@ -5,7 +5,7 @@ sinonChai     = require("sinon-chai")
 sinonPromise  = require("sinon-as-promised")(Promise)
 
 global.request   = require("request-promise")
-global.supertest = require("supertest-as-promised")(Promise)
+global.supertest = require("supertest")
 
 chai.use(sinonChai)
 

packages/server/package.json

@@ -88,8 +88,7 @@
     "snap-shot-it": "7.0.1",
     "ssestream": "1.0.1",
     "stream-to-promise": "1.1.1",
-    "supertest": "0.15.0",
-    "supertest-as-promised": "3.2.0",
+    "supertest": "4.0.2",
     "supertest-session": "0.0.7",
     "through2": "0.6.5",
     "ws": "5.2.2",

packages/server/test/integration/http_requests_spec.coffee

@@ -32,8 +32,8 @@ Fixtures      = require("#{root}test/support/helpers/fixtures")
 
 zlib = Promise.promisifyAll(zlib)
 
-## force supertest-session to use supertest-as-promised, hah
-Session       = proxyquire("supertest-session", {supertest: supertest})
+## force supertest-session to use promises provided in supertest
+Session = proxyquire("supertest-session", {supertest: supertest})
 
 removeWhitespace = (c) ->
   c = str.clean(c)

packages/server/test/spec_helper.coffee

@@ -1,7 +1,7 @@
 require("../lib/environment")
 
 global.root      = "../../"
-global.supertest = require("supertest-as-promised")
+global.supertest = require("supertest")
 global.nock      = require("nock")
 global.expect    = require("chai").expect
 global.mockery   = require("mockery")