From c3828e52066b86f7f7476ce279f9efcec5bca9f4 Mon Sep 17 00:00:00 2001 From: Ryan Manuel Date: Wed, 8 Oct 2025 08:55:11 -0500 Subject: [PATCH] chore: (cy.prompt) fix prompt driver tests during contributor workflows (#32667) * chore: (cy.prompt) fix prompt driver tests during contributor workflows * chore: (cy.prompt) fix prompt driver tests during contributor workflows * Update packages/driver/cypress/e2e/commands/prompt/prompt.cy.ts * rework test --- packages/driver/cypress.config.ts | 3 ++ .../cypress/e2e/commands/prompt/prompt.cy.ts | 39 ++++++++++++------- 2 files changed, 27 insertions(+), 15 deletions(-) diff --git a/packages/driver/cypress.config.ts b/packages/driver/cypress.config.ts index fdbfe3bd68..3a92391d84 100644 --- a/packages/driver/cypress.config.ts +++ b/packages/driver/cypress.config.ts @@ -6,6 +6,9 @@ export const baseConfig: Cypress.ConfigOptions = { projectId: 'ypt4pf', experimentalMemoryManagement: true, experimentalWebKitSupport: true, + env: { + CI: process.env.CI, + }, hosts: { 'foobar.com': '127.0.0.1', '*.foobar.com': '127.0.0.1', diff --git a/packages/driver/cypress/e2e/commands/prompt/prompt.cy.ts b/packages/driver/cypress/e2e/commands/prompt/prompt.cy.ts index f33c7e8c48..c78155936a 100644 --- a/packages/driver/cypress/e2e/commands/prompt/prompt.cy.ts +++ b/packages/driver/cypress/e2e/commands/prompt/prompt.cy.ts @@ -3,22 +3,31 @@ describe('src/cy/commands/prompt', () => { Cypress.testingType = 'e2e' }) - it('executes the prompt command', () => { - // TODO: (cy.prompt) We will look into supporting other browsers - // as this is rolled out. We will add error messages for other browsers - // and add tests if necessary - if (Cypress.isBrowser('webkit') || Cypress.isBrowser('firefox')) { - return + // TODO: (cy.prompt) We will look into supporting other browsers + // as this is rolled out. We will add error messages for other browsers + // and add tests if necessary + if (!Cypress.isBrowser('webkit') && !Cypress.isBrowser('firefox')) { + const contributorPr = Cypress.env('CI') && !Cypress.env('RECORD_KEY') && Cypress.config('isTextTerminal') + + if (contributorPr) { + it('executes the prompt command - contributor PR', (done) => { + cy.on('fail', (err) => { + expect(err.message).to.include('Record key not provided') + + done() + }) + + cy.visit('http://www.foobar.com:3500/fixtures/prompt.html') + cy.prompt(['Click the "click me" button']) + }) + } else { + it('executes the prompt command - normal PR', () => { + cy.visit('http://www.foobar.com:3500/fixtures/prompt.html') + cy.prompt(['Click the "click me" button']) + cy.get('#log').should('contain', 'clicked') + }) } - - cy.visit('http://www.foobar.com:3500/fixtures/prompt.html') - - // TODO: add more tests when cy.prompt is built out, but for now this just - // verifies that the command executes without throwing an error - cy.prompt(['Click the "click me" button']) - - cy.get('#log').should('contain', 'clicked') - }) + } it('fails when testingType is component', (done) => { cy.on('fail', (err) => {