mirror/cypress
1
0
Fork 0
mirror of https://github.com/cypress-io/cypress.git synced 2026-05-08 07:50:24 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix: remove extra bundled electron in 10.0 binary (#20932)

Browse Source 
* fix: remove duplicate electron in binary dependencies

* move openProject

* fix test failure

* Decrease the MAX_ALLOWED_SIZE_MB
This commit is contained in:
Tim Griesser
2022-04-06 11:18:19 -04:00
committed by GitHub
parent 1d2d6a4723
commit d19cba873a
9 changed files with 13 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scripts/binary/zip.js
+4 -1
View File
@@ -72,7 +72,10 @@ const checkZipSize = function (zipPath) {
const zipSize = filesize(stats.size, { round: 0 })
console.log(`zip file size ${zipSize}`)
const MAX_ALLOWED_SIZE_MB = os.platform() === 'win32' ? 295 : 300
// Before you modify these max sizes, check and see what you did that might have
// done to increase the size of the binary, and if you do need to change it,
// call it out in the PR description / comments
const MAX_ALLOWED_SIZE_MB = os.platform() === 'win32' ? 295 : 200
const MAX_ZIP_FILE_SIZE = megaBytes(MAX_ALLOWED_SIZE_MB)
if (stats.size > MAX_ZIP_FILE_SIZE) {