chore(deps): Update dependency eslint to version 6.8.0 🌟 (#6509)

* chore(deps): Update eslint to 6.8.0 🌟

* fix missing dangling commas for linter

* fix missing dangling commas for linter

* more lint fixes

* yarn lock

Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com>
Co-authored-by: Jennifer Shehane <shehane.jennifer@gmail.com>

cli/lib/cli.js

@@ -171,7 +171,7 @@ module.exports = {
       debug('invalid CYPRESS_ENV value', process.env.CYPRESS_ENV)
 
       return errors.exitWithError(errors.errors.invalidCypressEnv)(
-        `CYPRESS_ENV=${process.env.CYPRESS_ENV}`
+        `CYPRESS_ENV=${process.env.CYPRESS_ENV}`,
       )
     }
 
@@ -251,7 +251,7 @@ module.exports = {
     .command('install')
     .usage('[options]')
     .description(
-      'Installs the Cypress executable matching this package\'s version'
+      'Installs the Cypress executable matching this package\'s version',
     )
     .option('-f, --force', text('forceInstall'))
     .action((opts) => {
@@ -264,7 +264,7 @@ module.exports = {
     .command('verify')
     .usage('[options]')
     .description(
-      'Verifies that Cypress is installed correctly and executable'
+      'Verifies that Cypress is installed correctly and executable',
     )
     .option('--dev', text('dev'), coerceFalse)
     .action((opts) => {

cli/lib/errors.js

@@ -36,7 +36,7 @@ const failedUnzip = {
 const missingApp = (binaryDir) => {
   return {
     description: `No version of Cypress is installed in: ${chalk.cyan(
-      binaryDir
+      binaryDir,
     )}`,
     solution: stripIndent`
     \nPlease reinstall Cypress by running: ${chalk.cyan('cypress install')}
@@ -214,7 +214,7 @@ const removed = {
   CYPRESS_BINARY_VERSION: {
     description: stripIndent`
     The environment variable CYPRESS_BINARY_VERSION has been renamed to CYPRESS_INSTALL_BINARY as of version ${chalk.green(
-    '3.0.0'
+    '3.0.0',
   )}
     `,
     solution: stripIndent`
@@ -224,7 +224,7 @@ const removed = {
   CYPRESS_SKIP_BINARY_INSTALL: {
     description: stripIndent`
     The environment variable CYPRESS_SKIP_BINARY_INSTALL has been removed as of version ${chalk.green(
-    '3.0.0'
+    '3.0.0',
   )}
     `,
     solution: stripIndent`
@@ -287,7 +287,7 @@ function formErrorText (info, msg, prevMessage) {
     la(
       is.unemptyString(obj.description),
       'expected error description to be text',
-      obj.description
+      obj.description,
     )
 
     // assuming that if there the solution is a function it will handle
@@ -307,7 +307,7 @@ function formErrorText (info, msg, prevMessage) {
       la(
         is.unemptyString(obj.solution),
         'expected error solution to be text',
-        obj.solution
+        obj.solution,
       )
 
       add(`

cli/lib/exec/spawn.js

@@ -102,7 +102,7 @@ module.exports = {
           // the launch cmd to be 'npm run dev'
           executable = 'node'
           args.unshift(
-            path.resolve(__dirname, '..', '..', '..', 'scripts', 'start.js')
+            path.resolve(__dirname, '..', '..', '..', 'scripts', 'start.js'),
           )
 
           debug('in dev mode the args became %o', args)

cli/lib/tasks/download.js

@@ -121,7 +121,7 @@ const verifyDownloadedFile = (filename, expectedSize, expectedChecksum) => {
         debug(text)
 
         throw new Error(text)
-      }
+      },
     )
   }
 
@@ -253,7 +253,7 @@ const downloadFromUrl = ({ url, downloadDestination, progress }) => {
           Failed downloading the Cypress binary.
           Response code: ${response.statusCode}
           Response message: ${response.statusMessage}
-        `
+        `,
         )
 
         reject(err)

cli/lib/tasks/install.js

@@ -50,7 +50,7 @@ const displayCompletionMsg = () => {
   logger.log()
   logger.log(
     'You can now open Cypress by running:',
-    chalk.cyan(path.join('node_modules', '.bin', 'cypress'), 'open')
+    chalk.cyan(path.join('node_modules', '.bin', 'cypress'), 'open'),
   )
 
   logger.log()
@@ -88,7 +88,7 @@ const downloadAndUnzip = ({ version, installDir, downloadDir }) => {
           util.setTaskTitle(
             task,
             util.titleize(chalk.green('Downloaded Cypress')),
-            rendererOptions.renderer
+            rendererOptions.renderer,
           )
         })
       },
@@ -115,7 +115,7 @@ const downloadAndUnzip = ({ version, installDir, downloadDir }) => {
           util.setTaskTitle(
             task,
             util.titleize(chalk.green('Finished Installation'), chalk.gray(installDir)),
-            rendererOptions.renderer
+            rendererOptions.renderer,
           )
         })
       },
@@ -160,7 +160,7 @@ const start = (options = {}) => {
       debug('environment variable CYPRESS_INSTALL_BINARY = 0, skipping install')
       logger.log(
         stripIndent`
-        ${chalk.yellow('Note:')} Skipping binary installation: Environment variable CYPRESS_INSTALL_BINARY = 0.`
+        ${chalk.yellow('Note:')} Skipping binary installation: Environment variable CYPRESS_INSTALL_BINARY = 0.`,
       )
 
       logger.log()
@@ -184,7 +184,7 @@ const start = (options = {}) => {
         ${chalk.yellow('Note:')} Overriding Cypress cache directory to: ${chalk.cyan(envCache)}
 
               Previous installs of Cypress may not be found.
-      `
+      `,
     )
 
     logger.log()
@@ -254,7 +254,7 @@ const start = (options = {}) => {
             Instead we will install version: ${chalk.green(needVersion)}
 
             These versions may not work properly together.
-        `)
+        `),
       )
 
       logger.log()
@@ -337,7 +337,7 @@ const unzipTask = ({ zipFilePath, installDir, progress, rendererOptions }) => {
         util.setTaskTitle(
           task,
           util.titleize(chalk.green('Unzipped Cypress')),
-          rendererOptions.renderer
+          rendererOptions.renderer,
         )
       })
     },
@@ -355,7 +355,7 @@ const progessify = (task, title) => {
     util.setTaskTitle(
       task,
       util.titleize(title, percentComplete, remaining),
-      getRendererOptions().renderer
+      getRendererOptions().renderer,
     )
   }
 }

cli/lib/tasks/state.js

@@ -150,7 +150,7 @@ const writeBinaryVerifiedAsync = (verified, binaryDir) => {
     return fs.outputJsonAsync(
       getBinaryStatePath(binaryDir),
       _.extend(contents, { verified }),
-      { spaces: 2 }
+      { spaces: 2 },
     )
   })
 }

cli/lib/tasks/verify.js

@@ -55,7 +55,7 @@ const runSmokeTest = (binaryDir, options) => {
         debug('error timedOut is true')
 
         return throwFormErrorText(
-          errors.smokeTestFailure(smokeTestCommand, true)
+          errors.smokeTestFailure(smokeTestCommand, true),
         )(errMessage)
       }
 
@@ -90,7 +90,7 @@ const runSmokeTest = (binaryDir, options) => {
     if (options.dev) {
       executable = 'node'
       args.unshift(
-        path.resolve(__dirname, '..', '..', '..', 'scripts', 'start.js')
+        path.resolve(__dirname, '..', '..', '..', 'scripts', 'start.js'),
       )
     }
 
@@ -208,9 +208,9 @@ function testBinary (version, binaryDir, options) {
             task,
             util.titleize(
               chalk.green('Verified Cypress!'),
-              chalk.gray(binaryDir)
+              chalk.gray(binaryDir),
             ),
-            rendererOptions.renderer
+            rendererOptions.renderer,
           )
         })
       },

cli/package.json

@@ -78,7 +78,7 @@
     "cross-env": "6.0.3",
     "dependency-check": "3.4.1",
     "dtslint": "0.9.0",
-    "eslint": "6.1.0",
+    "eslint": "6.8.0",
     "execa-wrap": "1.4.0",
     "hasha": "5.0.0",
     "mocha": "6.2.2",

cli/scripts/post-install.js

@@ -32,14 +32,14 @@ shell.sed(
   '-i',
   '<reference types="chai" />',
   '<reference path="../chai/index.d.ts" />',
-  join('types', 'chai-jquery', 'index.d.ts')
+  join('types', 'chai-jquery', 'index.d.ts'),
 )
 
 shell.sed(
   '-i',
   '<reference types="jquery" />',
   '<reference path="../jquery/index.d.ts" />',
-  join('types', 'chai-jquery', 'index.d.ts')
+  join('types', 'chai-jquery', 'index.d.ts'),
 )
 
 const sinonChaiFilename = join('types', 'sinon-chai', 'index.d.ts')
@@ -48,7 +48,7 @@ shell.sed(
   '-i',
   '<reference types="chai" />',
   '<reference path="../chai/index.d.ts" />',
-  sinonChaiFilename
+  sinonChaiFilename,
 )
 
 // also use relative import via path for sinon-chai
@@ -57,7 +57,7 @@ shell.sed(
   '-i',
   '<reference types="sinon" />',
   '<reference path="../sinon/index.d.ts" />',
-  sinonChaiFilename
+  sinonChaiFilename,
 )
 
 // and an import sinon line to be changed to relative path

cli/test/lib/exec/open_spec.js

@@ -42,7 +42,7 @@ describe('exec open', function () {
       return open.start({ env: 'host=http://localhost:1337,name=brian' })
       .then(() => {
         expect(spawn.start).to.be.calledWith(
-          ['--env', 'host=http://localhost:1337,name=brian']
+          ['--env', 'host=http://localhost:1337,name=brian'],
         )
       })
     })
@@ -51,7 +51,7 @@ describe('exec open', function () {
       return open.start({ config: 'watchForFileChanges=false,baseUrl=localhost' })
       .then(() => {
         expect(spawn.start).to.be.calledWith(
-          ['--config', 'watchForFileChanges=false,baseUrl=localhost']
+          ['--config', 'watchForFileChanges=false,baseUrl=localhost'],
         )
       })
     })
@@ -60,7 +60,7 @@ describe('exec open', function () {
       return open.start({ configFile: false })
       .then(() => {
         expect(spawn.start).to.be.calledWith(
-          ['--config-file', false]
+          ['--config-file', false],
         )
       })
     })
@@ -69,7 +69,7 @@ describe('exec open', function () {
       return open.start({ configFile: 'special-cypress.json' })
       .then(() => {
         expect(spawn.start).to.be.calledWith(
-          ['--config-file', 'special-cypress.json']
+          ['--config-file', 'special-cypress.json'],
         )
       })
     })
@@ -80,7 +80,7 @@ describe('exec open', function () {
       return open.start()
       .then(() => {
         expect(spawn.start).to.be.calledWith(
-          ['--project', process.cwd()]
+          ['--project', process.cwd()],
         )
       })
     })
@@ -91,7 +91,7 @@ describe('exec open', function () {
       return open.start({ global: true })
       .then(() => {
         expect(spawn.start).not.to.be.calledWith(
-          ['--project', process.cwd()]
+          ['--project', process.cwd()],
         )
       })
     })
@@ -102,7 +102,7 @@ describe('exec open', function () {
       return open.start({ project: '/path/to/project' })
       .then(() => {
         expect(spawn.start).to.be.calledWith(
-          ['--project', '/path/to/project']
+          ['--project', '/path/to/project'],
         )
       })
     })
@@ -111,7 +111,7 @@ describe('exec open', function () {
       return open.start({ project: '/path/to/project' })
       .then(() => {
         expect(spawn.start).to.be.calledWith(
-          ['--project', '/path/to/project']
+          ['--project', '/path/to/project'],
         )
       })
     })

cli/test/lib/exec/run_spec.js

@@ -100,7 +100,7 @@ describe('exec run', function () {
       return run.start({ configFile: false })
       .then(() => {
         expect(spawn.start).to.be.calledWith(
-          ['--run-project', process.cwd(), '--config-file', false]
+          ['--run-project', process.cwd(), '--config-file', false],
         )
       })
     })
@@ -109,7 +109,7 @@ describe('exec run', function () {
       return run.start({ configFile: 'special-cypress.json' })
       .then(() => {
         expect(spawn.start).to.be.calledWith(
-          ['--run-project', process.cwd(), '--config-file', 'special-cypress.json']
+          ['--run-project', process.cwd(), '--config-file', 'special-cypress.json'],
         )
       })
     })

cli/test/lib/tasks/install_spec.js

@@ -68,7 +68,7 @@ describe('/lib/tasks/install', function () {
 
           snapshot(
             'skip installation 1',
-            normalize(this.stdout.toString())
+            normalize(this.stdout.toString()),
           )
         })
       })
@@ -92,7 +92,7 @@ describe('/lib/tasks/install', function () {
 
           snapshot(
             'specify version in env vars 1',
-            normalize(this.stdout.toString())
+            normalize(this.stdout.toString()),
           )
         })
       })
@@ -195,7 +195,7 @@ describe('/lib/tasks/install', function () {
           .then(() => {
             return snapshot(
               'version already installed - cypress install 1',
-              normalize(this.stdout.toString())
+              normalize(this.stdout.toString()),
             )
           })
         })
@@ -207,7 +207,7 @@ describe('/lib/tasks/install', function () {
           .then(() => {
             snapshot(
               'version already installed - postInstall 1',
-              normalize(this.stdout.toString())
+              normalize(this.stdout.toString()),
             )
           })
         })
@@ -231,7 +231,7 @@ describe('/lib/tasks/install', function () {
 
           snapshot(
             'continues installing on failure 1',
-            normalize(this.stdout.toString())
+            normalize(this.stdout.toString()),
           )
         })
       })
@@ -254,12 +254,12 @@ describe('/lib/tasks/install', function () {
 
           // cleans up the zip file
           expect(fs.removeAsync).to.be.calledWith(
-            downloadDestination
+            downloadDestination,
           )
 
           snapshot(
             'installs without existing installation 1',
-            normalize(this.stdout.toString())
+            normalize(this.stdout.toString()),
           )
         })
       })
@@ -282,7 +282,7 @@ describe('/lib/tasks/install', function () {
 
           snapshot(
             'installed version does not match needed version 1',
-            normalize(this.stdout.toString())
+            normalize(this.stdout.toString()),
           )
         })
       })
@@ -305,7 +305,7 @@ describe('/lib/tasks/install', function () {
 
           snapshot(
             'forcing true always installs 1',
-            normalize(this.stdout.toString())
+            normalize(this.stdout.toString()),
           )
         })
       })
@@ -330,7 +330,7 @@ describe('/lib/tasks/install', function () {
 
           snapshot(
             'warning installing as global 1',
-            normalize(this.stdout.toString())
+            normalize(this.stdout.toString()),
           )
         })
       })
@@ -347,7 +347,7 @@ describe('/lib/tasks/install', function () {
         it('uses verbose renderer', function () {
           snapshot(
             'installing in ci 1',
-            normalize(this.stdout.toString())
+            normalize(this.stdout.toString()),
           )
         })
       })
@@ -371,7 +371,7 @@ describe('/lib/tasks/install', function () {
 
             snapshot(
               'invalid cache directory 1',
-              normalize(this.stdout.toString())
+              normalize(this.stdout.toString()),
             )
           })
         })
@@ -441,7 +441,7 @@ describe('/lib/tasks/install', function () {
 
             snapshot(
               'error for removed CYPRESS_BINARY_VERSION 1',
-              normalize(this.stdout.toString())
+              normalize(this.stdout.toString()),
             )
           })
         })
@@ -455,7 +455,7 @@ describe('/lib/tasks/install', function () {
       .then(() => {
         return snapshot(
           'silent install 1',
-          normalize(`[no output]${this.stdout.toString()}`)
+          normalize(`[no output]${this.stdout.toString()}`),
         )
       })
     })

cli/test/lib/tasks/state_spec.js

@@ -20,7 +20,7 @@ const binaryPkgPath = path.join(
   'Contents',
   'Resources',
   'app',
-  'package.json'
+  'package.json',
 )
 
 describe('lib/tasks/state', function () {
@@ -88,7 +88,7 @@ describe('lib/tasks/state', function () {
         '.cache/Cypress/1.2.3/Cypress.app/Contents/MacOS/Cypress'
 
       expect(state.getPathToExecutable(state.getBinaryDir())).to.equal(
-        macExecutable
+        macExecutable,
       )
     })
 
@@ -97,7 +97,7 @@ describe('lib/tasks/state', function () {
       const linuxExecutable = '.cache/Cypress/1.2.3/Cypress/Cypress'
 
       expect(state.getPathToExecutable(state.getBinaryDir())).to.equal(
-        linuxExecutable
+        linuxExecutable,
       )
     })
 
@@ -110,7 +110,7 @@ describe('lib/tasks/state', function () {
       const customBinaryDir = 'home/downloads/cypress.app'
 
       expect(state.getPathToExecutable(customBinaryDir)).to.equal(
-        'home/downloads/cypress.app/Contents/MacOS/Cypress'
+        'home/downloads/cypress.app/Contents/MacOS/Cypress',
       )
     })
   })
@@ -118,7 +118,7 @@ describe('lib/tasks/state', function () {
   context('.getBinaryDir', function () {
     it('resolves path on macOS', function () {
       expect(state.getBinaryDir()).to.equal(
-        path.join(versionDir, 'Cypress.app')
+        path.join(versionDir, 'Cypress.app'),
       )
     })
 
@@ -142,7 +142,7 @@ describe('lib/tasks/state', function () {
 
     it('resolves path to binary/installation from version', function () {
       expect(state.getBinaryDir('4.5.6')).to.be.equal(
-        path.join(cacheDir, '4.5.6', 'Cypress.app')
+        path.join(cacheDir, '4.5.6', 'Cypress.app'),
       )
     })
 
@@ -221,10 +221,10 @@ describe('lib/tasks/state', function () {
         () => {
           return expect(fs.outputJsonAsync).to.be.calledWith(
             binaryStateFilename,
-            { verified: true }
+            { verified: true },
           )
         },
-        { spaces: 2 }
+        { spaces: 2 },
       )
     })
 
@@ -237,7 +237,7 @@ describe('lib/tasks/state', function () {
         return expect(fs.outputJsonAsync).to.be.calledWith(
           binaryStateFilename,
           { verified: false },
-          { spaces: 2 }
+          { spaces: 2 },
         )
       })
     })
@@ -310,7 +310,7 @@ describe('lib/tasks/state', function () {
 
       return state
       .parseRealPlatformBinaryFolderAsync(
-        '/Documents/Cypress.app/Contents/MacOS/Cypress'
+        '/Documents/Cypress.app/Contents/MacOS/Cypress',
       )
       .then((path) => {
         return expect(path).to.eql('/Documents/Cypress.app')

cli/test/lib/tasks/verify_spec.js

@@ -82,7 +82,7 @@ context('lib/tasks/verify', () => {
 
       snapshot(
         'no version of Cypress installed 1',
-        normalize(stdout.toString())
+        normalize(stdout.toString()),
       )
     })
   })
@@ -159,7 +159,7 @@ context('lib/tasks/verify', () => {
     .catch(() => {
       return snapshot(
         'warning installed version does not match verified version 1',
-        normalize(stdout.toString())
+        normalize(stdout.toString()),
       )
     })
   })
@@ -323,7 +323,7 @@ context('lib/tasks/verify', () => {
       .then(() => {
         return snapshot(
           'fails verifying Cypress 1',
-          normalize(slice(stdout.toString()))
+          normalize(slice(stdout.toString())),
         )
       })
     })
@@ -407,7 +407,7 @@ context('lib/tasks/verify', () => {
         expect(util.exec).to.have.been.calledTwice
         // user should have been warned
         expect(logger.warn).to.have.been.calledWithMatch(
-          'This is likely due to a misconfigured DISPLAY environment variable.'
+          'This is likely due to a misconfigured DISPLAY environment variable.',
         )
       })
     })
@@ -502,7 +502,7 @@ context('lib/tasks/verify', () => {
 
       return snapshot(
         'Cypress non-executable permissions 1',
-        normalize(stdout.toString())
+        normalize(stdout.toString()),
       )
     })
   })
@@ -517,7 +517,7 @@ context('lib/tasks/verify', () => {
     return verify.start().then(() => {
       return snapshot(
         'current version has not been verified 1',
-        normalize(stdout.toString())
+        normalize(stdout.toString()),
       )
     })
   })
@@ -532,7 +532,7 @@ context('lib/tasks/verify', () => {
     return verify.start().then(() => {
       return snapshot(
         'different version installed 1',
-        normalize(stdout.toString())
+        normalize(stdout.toString()),
       )
     })
   })
@@ -549,7 +549,7 @@ context('lib/tasks/verify', () => {
     return verify.start().then(() => {
       return snapshot(
         'silent verify 1',
-        normalize(`[no output]${stdout.toString()}`)
+        normalize(`[no output]${stdout.toString()}`),
       )
     })
   })
@@ -712,7 +712,7 @@ context('lib/tasks/verify', () => {
           logger.error(err)
           snapshot(
             `${platform}: error when invalid CYPRESS_RUN_BINARY 1`,
-            normalize(stdout.toString())
+            normalize(stdout.toString()),
           )
         })
       })

cli/test/support/normalize.js

@@ -20,7 +20,7 @@ const normalize = (str) => {
     .split('\n')
     .map(removeExcessWhiteSpace)
     .join('\n')
-    .replace(downloadQueryRe, '?platform=OS&arch=ARCH')
+    .replace(downloadQueryRe, '?platform=OS&arch=ARCH'),
   )
 }