chore(deps): Update dependency eslint to version 6.8.0 🌟 (#6509)

* chore(deps): Update eslint to 6.8.0 🌟

* fix missing dangling commas for linter

* fix missing dangling commas for linter

* more lint fixes

* yarn lock

Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com>
Co-authored-by: Jennifer Shehane <shehane.jennifer@gmail.com>

scripts/add_newlines_to_snapshots.js

@@ -14,7 +14,7 @@ globAsync('packages/server/__snapshots__/*')
     return str
     .replace(
       contentBetweenBackticksRe,
-      '`\n$1\n`'
+      '`\n$1\n`',
     )
     .split('`\n\n\n').join('`\n\n')
     .split('\n\n\n\n`').join('\n\n\n`')

scripts/binary/util/purge-cloudflare-cache.ts

@@ -13,7 +13,7 @@ function hasCloudflareEnvironmentVars () {
 export function purgeCloudflareCache (url) {
   la(
     hasCloudflareEnvironmentVars(),
-    'Cannot purge Cloudflare cache without credentials. Ensure that the CF_TOKEN and CF_ZONEID environment variables are set.'
+    'Cannot purge Cloudflare cache without credentials. Ensure that the CF_TOKEN and CF_ZONEID environment variables are set.',
   )
 
   la(check.webUrl(url), 'Missing url to purge from Cloudflare.')

scripts/check-node-version.js

@@ -39,7 +39,7 @@ if (isWindows() && process.env.APPVEYOR) {
       assert.equal(
         os.arch(),
         'ia32',
-        getErrMsg('ia32')
+        getErrMsg('ia32'),
       )
 
       break
@@ -47,7 +47,7 @@ if (isWindows() && process.env.APPVEYOR) {
       assert.equal(
         os.arch(),
         'x64',
-        getErrMsg('x64')
+        getErrMsg('x64'),
       )
 
       break
@@ -61,7 +61,7 @@ const join = require('path').join
 
 const nodeVersionNeededString = read(
   join(__dirname, '..', '.node-version'),
-  'utf8'
+  'utf8',
 )
 const nodeVersionNeeded = nodeVersionNeededString.split('.')
 

scripts/decaff/no-cond-assign.js

@@ -17,7 +17,7 @@ module.exports = (fileInfo, api) => {
     const ifStatement = j.ifStatement(
       node.test.left,
       node.consequent,
-      node.alternate
+      node.alternate,
     )
 
     return [

scripts/decaff/switch-false.js

@@ -72,7 +72,7 @@ function generateIfStatement (j, cases) {
     ifStatement = j.ifStatement(
       c.test,
       content,
-      ifStatement
+      ifStatement,
     )
   })
 

scripts/test-other-projects.js

@@ -145,6 +145,6 @@ bump
   getStatusAndMessage,
   cliOptions.provider,
   shortNpmVersion,
-  platform
+  platform,
 )
 .catch(onError)

scripts/unit/binary/bump-spec.js

@@ -24,7 +24,7 @@ describe('bump', () => {
       la(
         R.equals(filtered, projects),
         'should have kept all projects',
-        filtered
+        filtered,
       )
     })
 
@@ -34,7 +34,7 @@ describe('bump', () => {
       la(
         projects.length,
         'there should be at least a few projects in the list of projects',
-        projects
+        projects,
       )
 
       const filter = bump.getFilterByProvider('circle', 'darwin')

scripts/unit/binary/move-binaries-spec.js

@@ -140,7 +140,7 @@ describe('move-binaries', () => {
       .withArgs(
         `${latestMacBuild}cypress.zip`,
         'desktop/3.3.0/darwin-x64/cypress.zip',
-        aws.bucket
+        aws.bucket,
       )
       .resolves()
 

scripts/unit/binary/upload-spec.js

@@ -47,7 +47,7 @@ describe('upload', () => {
       la(
         folder === 'desktop/3.3.0/darwin-x64/',
         'wrong upload desktop folder',
-        folder
+        folder,
       )
     })
   })

scripts/unit/binary/util/packages-spec.js

@@ -67,7 +67,7 @@ describe('packages', () => {
             }),
           },
         },
-      }
+      },
     )
 
     const res = await packages.getPackagesWithScript('build')

scripts/unit/konfig-spec.js

@@ -23,7 +23,7 @@ describe('konfig check', () => {
       !cwd.includes(join('packages', 'server')),
       'process CWD is set to',
       cwd,
-      'for some reason'
+      'for some reason',
     )
     // if the above assertion breaks, it means some script in binary scripts
     // loads "lib/konfig" directly, which unexpectedly changes the CWD.
@@ -38,7 +38,7 @@ describe('konfig check', () => {
       'previous cwd',
       cwd,
       'differs after loading konfig',
-      cwdAfter
+      cwdAfter,
     )
 
     la(is.fn(konfig), 'expected konfig to be a function', konfig)

scripts/win-appveyor-build.js

@@ -54,7 +54,7 @@ la(is.unemptyString(version), 'missing NEXT_DEV_VERSION')
 console.log('building version', version)
 
 shell.exec(
-  `node scripts/binary.js upload-npm-package --file cli/build/${filename} --version ${version}`
+  `node scripts/binary.js upload-npm-package --file cli/build/${filename} --version ${version}`,
 )
 
 const arch = os.arch()
@@ -77,7 +77,7 @@ const result = shell.exec('yarn list --dev --depth 0 || true', {
 if (result.stdout.includes('nodemon')) {
   console.error('Hmm, server package includes dev dependency "coveralls"')
   console.error(
-    'which means somehow we are including dev dependencies in the output bundle'
+    'which means somehow we are including dev dependencies in the output bundle',
   )
 
   console.error('see https://github.com/cypress-io/cypress/issues/2896')
@@ -115,15 +115,15 @@ if (isPullRequest()) {
   shell.exec('yarn binary-zip')
   shell.ls('-l', '*.zip')
   shell.exec(
-    `node scripts/binary.js upload-unique-binary --file cypress.zip --version ${version}`
+    `node scripts/binary.js upload-unique-binary --file cypress.zip --version ${version}`,
   )
 
   shell.cat('binary-url.json')
   shell.exec(
-    'node scripts/add-install-comment.js --npm npm-package-url.json --binary binary-url.json'
+    'node scripts/add-install-comment.js --npm npm-package-url.json --binary binary-url.json',
   )
 
   shell.exec(
-    'node scripts/test-other-projects.js --npm npm-package-url.json --binary binary-url.json --provider appVeyor'
+    'node scripts/test-other-projects.js --npm npm-package-url.json --binary binary-url.json --provider appVeyor',
   )
 }