From ef8a3dca20ec3f138200576d9805dc4d1dcb866b Mon Sep 17 00:00:00 2001 From: Jessica Sachs Date: Tue, 16 Nov 2021 14:20:21 -0500 Subject: [PATCH] BREAKING CHANGE: trigger major bump --- circle.yml | 2 -- packages/app/src/runner/event-manager.ts | 2 +- packages/data-context/src/sources/VersionsDataSource.ts | 2 +- scripts/binary/upload-unique-binary.js | 1 - 4 files changed, 2 insertions(+), 5 deletions(-) diff --git a/circle.yml b/circle.yml index c630515ee4..b84e65ddd0 100644 --- a/circle.yml +++ b/circle.yml @@ -2448,8 +2448,6 @@ mac-workflow: &mac-workflow - build: name: darwin-build executor: mac - environment: - NEXT_VERSION=10.0.0 requires: - darwin-node-modules-install <<: *macBuildFilters diff --git a/packages/app/src/runner/event-manager.ts b/packages/app/src/runner/event-manager.ts index 4a38dc65ab..e9e0c8f11a 100644 --- a/packages/app/src/runner/event-manager.ts +++ b/packages/app/src/runner/event-manager.ts @@ -85,7 +85,7 @@ export class EventManager { const rerun = () => { if (!this) { // if the tests have been reloaded - // then nothing to rerun + // then there is nothing to rerun return } diff --git a/packages/data-context/src/sources/VersionsDataSource.ts b/packages/data-context/src/sources/VersionsDataSource.ts index 23b0e440cb..96f058ef70 100644 --- a/packages/data-context/src/sources/VersionsDataSource.ts +++ b/packages/data-context/src/sources/VersionsDataSource.ts @@ -26,7 +26,7 @@ export class VersionsDataSource { * } */ async versions (): Promise { - const currentCypressVersion = require('./cypress/package.json') + const currentCypressVersion = require('@packages/root') const result = await execa(`npm`, [`view`, `cypress`, `time`, `--json`]) const json = JSON.parse(result.stdout) diff --git a/scripts/binary/upload-unique-binary.js b/scripts/binary/upload-unique-binary.js index f2e381f2a3..13cfc44300 100644 --- a/scripts/binary/upload-unique-binary.js +++ b/scripts/binary/upload-unique-binary.js @@ -43,7 +43,6 @@ const getCDN = function ({ version, hash, filename, platform }) { } // returns folder that contains beta (unreleased) binaries for given version -// const getUploadVersionDirName = function (options) { la(check.unemptyString(options.version), 'missing version', options)