From f81dfecef405f883ec1bbc1c17ffeec820c67674 Mon Sep 17 00:00:00 2001 From: Chris Breiding Date: Wed, 24 Feb 2021 16:28:45 -0500 Subject: [PATCH] fix: Remove truncation of preprocessor errors (#15198) --- packages/server/__snapshots__/1_busted_support_file_spec.js | 2 ++ packages/server/__snapshots__/1_es_modules_spec.js | 1 + .../__snapshots__/1_typescript_spec_support_spec.ts.js | 1 + packages/server/__snapshots__/5_stdout_spec.js | 1 + packages/server/__snapshots__/7_record_spec.js | 4 ++++ packages/server/lib/plugins/preprocessor.js | 4 +--- packages/server/test/unit/plugins/preprocessor_spec.js | 5 +++-- 7 files changed, 13 insertions(+), 5 deletions(-) diff --git a/packages/server/__snapshots__/1_busted_support_file_spec.js b/packages/server/__snapshots__/1_busted_support_file_spec.js index 82a958e4c9..7ec201237b 100644 --- a/packages/server/__snapshots__/1_busted_support_file_spec.js +++ b/packages/server/__snapshots__/1_busted_support_file_spec.js @@ -34,6 +34,8 @@ Looked for and couldn't find the file at the following paths: [/foo/bar/.projects/busted-support-file/cypress/support/does/not/exist.ts] [/foo/bar/.projects/busted-support-file/cypress/support/does/not/exist.tsx] @ ./cypress/support/index.js 3:0-27 + + [stack trace lines] This occurred while Cypress was compiling and bundling your test code. This is usually caused by: diff --git a/packages/server/__snapshots__/1_es_modules_spec.js b/packages/server/__snapshots__/1_es_modules_spec.js index 143b1b029c..5123208e76 100644 --- a/packages/server/__snapshots__/1_es_modules_spec.js +++ b/packages/server/__snapshots__/1_es_modules_spec.js @@ -95,6 +95,7 @@ SyntaxError: /foo/bar/.projects/e2e/lib/fail.js: Unexpected token (2:0) > 2 | | ^ @ ./cypress/integration/es_module_import_failing_spec.js 3:0-25 + [stack trace lines] This occurred while Cypress was compiling and bundling your test code. This is usually caused by: diff --git a/packages/server/__snapshots__/1_typescript_spec_support_spec.ts.js b/packages/server/__snapshots__/1_typescript_spec_support_spec.ts.js index ba688e711f..fa425a42af 100644 --- a/packages/server/__snapshots__/1_typescript_spec_support_spec.ts.js +++ b/packages/server/__snapshots__/1_typescript_spec_support_spec.ts.js @@ -96,6 +96,7 @@ You may need an additional loader to handle the result of these loaders. | // because it tests failing spec. > describe('fail', - > ); | + [stack trace lines] This occurred while Cypress was compiling and bundling your test code. This is usually caused by: diff --git a/packages/server/__snapshots__/5_stdout_spec.js b/packages/server/__snapshots__/5_stdout_spec.js index cd185f2272..7e3829809c 100644 --- a/packages/server/__snapshots__/5_stdout_spec.js +++ b/packages/server/__snapshots__/5_stdout_spec.js @@ -149,6 +149,7 @@ SyntaxError: /foo/bar/.projects/e2e/cypress/integration/stdout_exit_early_failin > 1 | +> | ^ 2 | + [stack trace lines] This occurred while Cypress was compiling and bundling your test code. This is usually caused by: diff --git a/packages/server/__snapshots__/7_record_spec.js b/packages/server/__snapshots__/7_record_spec.js index 7833085f66..ba2569c336 100644 --- a/packages/server/__snapshots__/7_record_spec.js +++ b/packages/server/__snapshots__/7_record_spec.js @@ -39,6 +39,8 @@ Looked for and couldn't find the file at the following paths: [/foo/bar/.projects/e2e/cypress/it/does/not/exist.ts] [/foo/bar/.projects/e2e/cypress/it/does/not/exist.tsx] @ ./cypress/integration/record_error_spec.js 3:0-31 + + [stack trace lines] This occurred while Cypress was compiling and bundling your test code. This is usually caused by: @@ -991,6 +993,8 @@ Looked for and couldn't find the file at the following paths: [/foo/bar/.projects/e2e/cypress/it/does/not/exist.ts] [/foo/bar/.projects/e2e/cypress/it/does/not/exist.tsx] @ ./cypress/integration/record_error_spec.js 3:0-31 + + [stack trace lines] This occurred while Cypress was compiling and bundling your test code. This is usually caused by: diff --git a/packages/server/lib/plugins/preprocessor.js b/packages/server/lib/plugins/preprocessor.js index 3c21c90eba..3b6bf2f23b 100644 --- a/packages/server/lib/plugins/preprocessor.js +++ b/packages/server/lib/plugins/preprocessor.js @@ -9,9 +9,7 @@ const appData = require('../util/app_data') const plugins = require('../plugins') const errorMessage = function (err = {}) { - return (err.stack || err.annotated || err.message || err.toString()) - .replace(/\n\s*at.*/g, '') - .replace(/From previous event:\n?/g, '') + return err.stack || err.annotated || err.message || err.toString() } const clientSideError = function (err) { diff --git a/packages/server/test/unit/plugins/preprocessor_spec.js b/packages/server/test/unit/plugins/preprocessor_spec.js index 8ffaf3e0fa..56098fda89 100644 --- a/packages/server/test/unit/plugins/preprocessor_spec.js +++ b/packages/server/test/unit/plugins/preprocessor_spec.js @@ -185,8 +185,9 @@ describe('lib/plugins/preprocessor', () => { expect(preprocessor.errorMessage(err)).to.equal('message') }) - it('removes stack lines', () => { - expect(preprocessor.errorMessage('foo\n at what.ever (foo 23:30)\n baz\n at where.ever (bar 1:5)')).to.equal('foo\n baz') + it('does not remove stack lines', () => { + expect(preprocessor.errorMessage('foo\n at what.ever (foo 23:30)\n baz\n at where.ever (bar 1:5)')) + .to.equal('foo\n at what.ever (foo 23:30)\n baz\n at where.ever (bar 1:5)') }) }) })