chore: enable caching for lint task (#26791)

.eslintrc.js

@@ -57,7 +57,6 @@ module.exports = {
       rules: {
         'no-restricted-properties': 'off',
         'no-restricted-syntax': 'off',
-        'no-console': 'off',
       },
     },
   ],

cli/package.json

@@ -66,7 +66,15 @@
   "devDependencies": {
     "@babel/cli": "7.13.0",
     "@babel/preset-env": "7.13.5",
+    "@cypress/angular": "0.0.0-development",
+    "@cypress/grep": "0.0.0-development",
+    "@cypress/mount-utils": "0.0.0-development",
+    "@cypress/react": "0.0.0-development",
+    "@cypress/react18": "0.0.0-development",
     "@cypress/sinon-chai": "2.9.1",
+    "@cypress/svelte": "0.0.0-development",
+    "@cypress/vue": "0.0.0-development",
+    "@cypress/vue2": "0.0.0-development",
     "@packages/root": "0.0.0-development",
     "@types/bluebird": "3.5.33",
     "@types/chai": "4.2.15",

lerna.json

@@ -5,7 +5,8 @@
     "packages/*",
     "npm/*",
     "tooling/*",
-    "system-tests"
+    "system-tests",
+    "scripts"
   ],
   "useWorkspaces": true,
   "useNx": true,

npm/angular/src/mount.ts

@@ -116,6 +116,7 @@ export type MountResponse<T> = {
 // 'zone.js/testing' is not properly aliasing `it.skip` but it does provide `xit`/`xspecify`
 // Written up under https://github.com/angular/angular/issues/46297 but is not seeing movement
 // so we'll patch here pending a fix in that library
+// @ts-ignore Ignore so that way we can bypass semantic error TS7017: Element implicitly has an 'any' type because type 'typeof globalThis' has no index signature.
 globalThis.it.skip = globalThis.xit
 
 @Injectable()

nx.json

@@ -3,9 +3,46 @@
     "default": {
       "runner": "nx-cloud",
       "options": {
-        "cacheableOperations": [],
+        "cacheableOperations": [
+          "lint"
+        ],
         "accessToken": "ZmNlNjA0YzAtNTM1NS00MDIwLWFlMWItNWYxYzNiMjQ4N2VkfHJlYWQtb25seQ=="
       }
     }
+  },
+  "targetDefaults": {
+    "lint": {
+      "inputs": [
+        "default",
+        "{workspaceRoot}/.eslintrc.js"
+      ]
+    },
+    "build": {
+      "dependsOn": [
+        "^build"
+      ]
+    },
+    "build-prod": {
+      "dependsOn": [
+        "^build-prod"
+      ]
+    }
+  },
+  "namedInputs": {
+    "sharedGlobals": [],
+    "default": [
+      "{projectRoot}/**/*",
+      "sharedGlobals"
+    ],
+    "production": [
+      "default",
+      "!{projectRoot}/**/*.spec.ts",
+      "!{projectRoot}/**/*.md",
+      "!{projectRoot}/tsconfig.spec.json",
+      "!{projectRoot}/.eslintrc.json",
+      "!{projectRoot}/.mocharc.{js,json}",
+      "!{projectRoot/cypress.config.{ts,js}",
+      "!{projectRoot/**/*.cy.ts"
+    ]
   }
-}
+}

package.json

@@ -13,7 +13,7 @@
     "binary-upload": "node ./scripts/binary.js upload",
     "binary-zip": "node ./scripts/binary.js zip",
     "build": "yarn build-npm-modules && lerna run build --stream --no-bail --ignore create-cypress-tests --ignore cypress --ignore \"'@packages/{runner}'\" --ignore \"'@cypress/{angular,react,react18,vue,vue2,mount-utils,svelte}'\" && node ./cli/scripts/post-build.js && lerna run build --stream --scope create-cypress-tests",
-    "build-npm-modules": "lerna run build --scope cypress --scope @cypress/mount-utils && lerna run build --scope \"'@cypress/{angular,react,react18,vue,vue2,svelte}'\"",
+    "build-npm-modules": "lerna run build --scope cypress --scope @cypress/mount-utils --scope @cypress/react && lerna run build --scope \"'@cypress/{angular,react18,vue,vue2,svelte}'\"",
     "build-prod": "lerna run build-prod-ui --stream && lerna run build-prod --stream --ignore create-cypress-tests && node ./cli/scripts/post-build.js && lerna run build-prod --stream --scope create-cypress-tests --scope",
     "build-v8-snapshot-dev": "node --max-old-space-size=8192 tooling/v8-snapshot/scripts/setup-v8-snapshot-in-cypress.js --env=dev",
     "build-v8-snapshot-prod": "node --max-old-space-size=8192 tooling/v8-snapshot/scripts/setup-v8-snapshot-in-cypress.js",
@@ -41,7 +41,7 @@
     "ensure-deps": "./scripts/ensure-dependencies.sh",
     "get-next-version": "node scripts/get-next-version.js",
     "postinstall": "node ./scripts/run-postInstall.js",
-    "lint": "lerna run lint --no-bail --concurrency 2 && eslint --ext .js,.ts,.json, scripts",
+    "lint": "lerna run lint --no-bail --concurrency 2",
     "prepare-release-artifacts": "node ./scripts/prepare-release-artifacts.js",
     "npm-release": "node scripts/npm-release.js",
     "prestart": "yarn ensure-deps",
@@ -244,7 +244,8 @@
       "packages/*",
       "npm/*",
       "tooling/*",
-      "system-tests"
+      "system-tests",
+      "scripts"
     ],
     "nohoist": [
       "**/webpack-preprocessor/babel-loader",

scripts/.eslintrc

@@ -0,0 +1,17 @@
+{
+  "plugins": [
+    "cypress",
+    "@cypress/dev"
+  ],
+  "extends": [
+    "plugin:@cypress/dev/general",
+    "plugin:@cypress/dev/tests"
+  ],
+  "env": {
+    "cypress/globals": true
+  },
+  "rules": {
+    "no-console": "off",
+    "prefer-rest-params": "off"
+  }
+}

scripts/package.json

@@ -0,0 +1,6 @@
+{
+  "name": "internal-scripts",
+  "scripts": {
+    "lint": "eslint --ext .js,.ts,.json, ."
+  }
+}