Commit Graph

50 Commits

Author SHA1 Message Date
Zachary Williams
00a0f5a0e9 fix: restart dev-server on config change (#21212)
* fix: restart dev-server on config change

* close dev server before cp is spawned

* fix test that is failing... not sure why

* cleanup unsued close events

* remove wait

* add back in close for unit tests

Co-authored-by: Tim Griesser <tgriesser10@gmail.com>
2022-05-02 12:05:01 +10:00
Lachlan Miller
22e7d36673 fix: update dev server error message (#21181)
* fix: update dev server error message

* revert change

* remove obsolete test

* revert change

* update errors

* rename error
2022-04-26 12:37:18 +10:00
Barthélémy Ledoux
026c300708 fix: make error on integration folder point to e2e (#20853)
* fix: make error on integration folder point to e2e

* fix: add context for testing type to the errors

* fix: pass testnigtype to errors

* add testingType where needed

* show setupNodeEvent when error

* fix some unit tests

* update snapshot

* update snapshot

* test: add test for stupNodeEvents

* fix: add name for config error

* fix: use distinct errors for root and e2e failures

* test: update 2 snapshots

* snapshot update again

* update snapshots again normally this time
2022-04-15 15:05:35 -05:00
Alejandro Estrada
0af82eaf64 fix: display correct error location (#21003)
* fix: display correct error location

* Update ts_node

* Add test

* Fix test

* Update with feedback
2022-04-11 13:05:13 -04:00
Alejandro Estrada
e6cbc5ae1e fix: windows build (#20854)
* fix: update icons build to work on windows

* Add rimraf

* Update scripts

* Update script

* Update scripts

* Fix windows migration

* Update postinstall script

* Remove script
2022-04-04 11:12:08 -05:00
Zachary Williams
2c8e97df24 refactor: lift indexHtmlFile up to component, add validation (#20870) 2022-04-01 09:45:21 -05:00
Lachlan Miller
332e69b57c fix(launchpad): show more specific error when default supportFile is missing (#20792)
* fix: show correct error message for missing default supportFile

* add regression test for custom support file

* update error

* update tests

* fix test

* remove unused arg

* remove console.log
2022-03-29 13:21:33 +10:00
Barthélémy Ledoux
1de1aa5ccc feat: error when updating a 9.X value in 10.X in the pluginsFile (#20521) 2022-03-24 11:52:51 -05:00
Zachary Williams
110f8ae02d fix: remove --config-file false references and update types (#20643)
* fix: remove --config-file false references and update types

* cleanup tests and types, catch errors when calling open

* fix test

* remove string check

* code quality feedback
2022-03-21 22:49:14 +10:00
BlueWinds
0dea68790c Review feedback 2022-03-17 08:56:47 -07:00
BlueWinds
62b105fcb0 Add error when componentFolder found in 10.0 configs 2022-03-16 12:31:23 -07:00
David Munechika
2f5f0de759 fix(unify): Use of experimentalStudio should throw a warning that it is removed (#20515)
* add terminal warning for experimental studio

* add to errors old

* add warnings to main

* debug onWarning callback

* show error in open mode

* update snapshot

* update tests

* validate config earlier

* remove from types and schema

* use on link

* refactor getError

* update types

Co-authored-by: Emily Rohrbough  <emilyrohrbough@users.noreply.github.com>

* add unit test for validateNoBreakingConfigLaunchpad

* fix types

* merge test files

* update types

Co-authored-by: Emily Rohrbough  <emilyrohrbough@users.noreply.github.com>
2022-03-15 11:30:15 +10:00
Emily Rohrbough
efede20d9e chore(unification): remove pluginsFile references (#20560)
* remove pluginsFile references

* fix all tests relying on this system test

* fix broken tests

* fix more broken tests

* one more

* relative path

* pr feedbkac

* fix vite-dev-server broken configuration

* PR feedback on error message

* update errors snaphsot

* bring back error in gql

* fix snapshot

* fix snapshot.

* fix merge issues

Co-authored-by: ElevateBart <ledouxb@gmail.com>
2022-03-15 11:27:04 +10:00
Barthélémy Ledoux
c4dec1efb9 refactor: make config package type-safe (#20590) 2022-03-14 15:32:11 -05:00
Jess
c2cc967227 feat: adding module support for invoking cypress.config.mjs, .cjs, .ts (#20554)
* feat: adding module support for invoking cypress.config.mjs, .cjs, .ts

Co-authored-by: Lachlan Miller <lachlan.miller.1990@outlook.com>
2022-03-14 10:46:29 -04:00
Lachlan Miller
742f261a1b fix(launchpad): correctly migrate projects settings config in plugins (#20509)
Co-authored-by: Barthélémy Ledoux <bart@cypress.io>
2022-03-11 13:04:06 -06:00
Alejandro Estrada
5670344590 feat: remove testFiles reference (#20565)
* feat: remove testFiles reference

* feat: remove testFiles reference

* Fix test/TS
2022-03-11 12:02:37 +10:00
Alejandro Estrada
7636287eee fix: config migration when --config-file flag is set (#20470)
* fix: config migration when --config-file flag is set

* Fix/add tests

* Update migration for config migrations that already ocurred

* Fix TS, fix test

* Update comment

* Refactor code

* Update error, prevent clicking the project on topNav

* Fix TS

* Fix error - update error message

* Update test

* Refactor code / add test for legacy config

* Refactor code

* Update with feedback

* Update with code review
2022-03-09 17:11:39 -05:00
Tim Griesser
92eac2f67e feat: Error standardization (#20323)
* refactor: reworking client-side error shape

* feat: add the CodeFrame to baseerror

* consolidate baseError handling, type fixes

* Fix UNIFY-1164 w/ test cleanup to avoid intercepting

* fix types, cleanup based on review / Brian

* fix: imports / types / tests

* cleanup tests, fix TSError location, add reinitializeCypress mutation

* fix: show correct stack trace file name (#20410)

* Improve comments for regexes / TSError capture

* feat: Add codeframe to error, address PR comments

* update snapshot

* change codeframe impl, per Brian's request

* Attempt to fix test flake

Co-authored-by: ElevateBart <ledouxb@gmail.com>
Co-authored-by: Alejandro Estrada <estrada9166@hotmail.com>
2022-03-02 18:03:52 -05:00
Tim Griesser
e2f385d85f fix: remove unused AUTH_BROWSER_LAUNCHED / AUTH_COULD_NOT_LAUNCH_BROWSER 2022-02-22 11:21:20 -05:00
Brian Mann
6d818ce989 update paths to be more realistic 2022-02-22 10:06:21 -05:00
Brian Mann
61a5a84764 rename a bunch of errors for consistency 2022-02-22 10:06:05 -05:00
Brian Mann
a4ee43b62c revise multiple errors 2022-02-22 10:05:01 -05:00
Brian Mann
da3c582ced revise SETUP_NODE_EVENTS_DO_NOT_SUPPORT_DEV_SERVER error 2022-02-22 10:03:01 -05:00
Brian Mann
1717518ef9 revise MULTIPLE_SUPPORT_FILES_FOUND again 2022-02-22 10:02:00 -05:00
Brian Mann
6214af2f1e revise CONFIG_FILES_LANGUAGE_CONFLICT error 2022-02-22 10:00:26 -05:00
Brian Mann
511bbf41aa revise PLUGINS_INVALID_EVENT_NAME_ERROR error 2022-02-22 09:59:37 -05:00
Brian Mann
a679a7c7e1 revise CONFIG_FILE_UNEXPECTED_ERROR error 2022-02-22 09:59:15 -05:00
Brian Mann
7314e5a0aa revise CONFIG_FILE_SETUP_NODE_EVENTS_ERROR error 2022-02-22 09:58:20 -05:00
Brian Mann
9ef922583a revise SETUP_NODE_EVENTS_IS_NOT_FUNCTION error 2022-02-22 09:57:23 -05:00
Brian Mann
ebfaa7600e revise MULTIPLE_SUPPORT_FILES_FOUND error, accept array of strings for formatting 2022-02-22 09:56:17 -05:00
Tim Griesser
032ec60d38 fix spec failures 2022-02-21 19:21:19 -05:00
Tim Griesser
73def69360 Fixing CONFIG_VALIDATION_ERROR / SETUP_NODE_EVENTS_IS_NOT_FUNCTION errors 2022-02-21 17:37:39 -05:00
Tim Griesser
7e8370a2a5 working through mapping error cases from develop 2022-02-21 17:07:46 -05:00
Tim Griesser
d3b1969a75 update CONFIG_FILE_REQUIRE_ERROR 2022-02-21 16:23:48 -05:00
Tim Griesser
0beaaef4d2 remove plugins file not found error/test 2022-02-21 15:51:41 -05:00
Tim Griesser
1c84831317 update deep import of @packages/errors 2022-02-21 10:11:55 -05:00
Brian Mann
6b363eca2f fix invalid exports 2022-02-21 09:29:59 -05:00
Brian Mann
bc73d956a8 export errors.theme, update imports not to require from deep inside packages 2022-02-18 17:09:09 -05:00
Brian Mann
6ed3540cd5 fix test importing wrong strip_indent 2022-02-18 16:36:00 -05:00
Tim Griesser
61e9f00517 fix: cleanup a few more tests/snapshot errors 2022-02-17 10:43:22 -05:00
Tim Griesser
6727893b1e fix: additional cleanup of errors following merge 2022-02-17 09:59:30 -05:00
Tim Griesser
9a1874d6a8 fix: clean up a few test failures 2022-02-16 17:07:53 -05:00
Tim Griesser
9307dc01ec fix: types for config changes 2022-02-16 16:14:27 -05:00
Brian Mann
f076a64f3b rename clone -> cloneErr 2022-02-15 02:15:15 -05:00
Brian Mann
923ab0a9ba export additional properties on error, update refs, fix tests 2022-02-15 02:03:14 -05:00
Brian Mann
7848147f88 add visual tests for new errors, update formatting + copy of existing errors to bring into parity with new conventions 2022-02-14 18:35:43 -05:00
Tim Griesser
6279a7dd10 wip: type fixes & changes after merge 2022-02-14 08:20:11 -05:00
Tim Griesser
678bedeca6 Merge branch 'develop' into 10.0-release
* develop:
  feat: gray out the path to system node in cypress run header (#20121)
  feat: redesign server errors (#20072)
  test: fix awesome-typescript-loader test and remove test-binary job (#20131)
  fix: Fix issues with stack traces and command log in Chrome 99 (#20049)
  fix: `cy.type(' ')` fires click event on button-like elements. (#20067)
  fix: `change`, `input` events are not fired when the same option is selected again. (#19623)
  build: publish vue3 on latest (#20099)
  chore: release @cypress/webpack-preprocessor-v5.11.1
  chore: release @cypress/webpack-dev-server-v1.8.1
  fix: detect newly added specs in dev-server compilation (#17950)
  chore: Remove pkg/driver //@ts-nocheck part 3 (#19837)
  chore: set up semantic-pull-request GitHub Action (#20091)
  chore: release @cypress/react-v5.12.2
  fix: remove nullish coalescing in js files to support node 12 (#20094)
  docs: update @cypress/webpack-preprocessor links (#19902)
  refactor: use aliases instead of meta (#19566)
2022-02-13 15:36:48 -05:00
Brian Mann
29841f32b9 feat: redesign server errors (#20072)
* chore: rename errors.js -> errors.ts

* refactor: type safety on errors

* refactor: add err_template for consistent error formatting

* fix a few system tests

* fix tests; update snapshots

* Fix types

* normalize snapshot - remove chalk ansi colors

* more unit test fixes

* more system test fixes

* circleci build

* backtick always in stdout, fix error formatting and failing snapshots

* refactor: create @packages/errors

* fix import

* fix import

* fixing build / tests

* remove extraneous file

* move warnIfExplicitCiBuildId

* fix build / tests

* Fix

* error, type fixes, documentation, standardize child process error serialization

* fix import

* build errors on install

* wrote specs generating visual images of all errors

* remove unused dep

* sanitize stack traces

* add image diffing

- if base images don't exist, create them
- if base images don't match and local, overwrite them, if in CI throw
- if base images are stale and local, delete them, if in CI throw

* remove Courier New + MesloLGS NF font

* type fixes, remove Bluebird, general cleanup

* TS Cleanup

* skip typecheck on tests for now

* yarn.lock

* fix @types/chai version

* fix yarn.lock

* Different version of mocha types so it isnt patched

* errors spec snapshot

* CI fix

* fixes

* store snapshot images in circle artifacts

* dont change artifact destination prefix

* use Courier Prime

* antialias the text

* decrease pixelmatch threshold, fail in CI only when changed pixels > 100

* increase timeout

* overflow: hidden, remove new Promise, add debug logging

Co-Authored-By: Tim Griesser <tgriesser@gmail.com>

* run unit tests w/ concurrency=1

* unique window per file

* disable app hardware acceleration + use in process gpu + single process

* do not do image diffing

- conditionally convert html to images
- store html snapshots
- do not store images in git

* store snapshot html

* Merge branch 'tgriesser/chore/refactor-errors' of https://github.com/cypress-io/cypress into tgriesser/chore/refactor-errors

* remove concurrency

* fix assertion

* fixing ci

* Link in readme

* pass the browsers to listItems

* fix: build @packages/errors in CI, defer import to prevent errors locally

* Merge branch 'develop' into tgriesser/chore/refactor-errors

* develop:
  chore: fix cypress npm package artifact upload path (#20023)
  chore(driver): move cy.within logic into it's own file (#20036)
  chore: update automerge workflows (#19982)
  fix(selectFile): use target window's File/DataTransfer classes (#20003)
  chore: Update Chrome (stable) to 98.0.4758.80 and Chrome (beta) to 98.0.4758.80 (#19995)
  fix: Adjust ffmpeg CLI args for performance (#19983)
  build: allow unified to run cypress on Apple Silicon (arm64) (backport #19067 to 9.x) (#19968)

* fix run-if-ci.sh

* remove dead code

* Mark the .html files as generated in gitattributes

* fix running single error case, slice out more of the brittle stack

* remove additional brittle stack line

* firefox web security error

* nest inside of describe

* reformat and redesign errors

* more error cleanup and standardization

* additional formatting of errors, code cleanup, refactoring

* update ansi colors to match terminal colors

* cleanup remaining loose ends, update several errors, compact excess formatters

* fix types

* additional formatting, remove TODO's, ensure no [object Object] in output

* add test for 412 server response on invalid schema

* update unknown dashboard error on creating run

* use fs.access instead of fs.stat for perf

* added PLUGINS_FILE_NOT_FOUND error

- separated out from PLUGINS_FILE_ERROR
- add system tests for both cases
- update snapshots
- remove stack trace from PLUGINS_FILE_NOT_FOUND fka PLUGINS_FILE_ERROR

* add plugins system test around plugins synchronously throwing on require

* remove forcing process.cwd() to be packages/server, update affected code

- this was a long needed hangover from very old code that was doing unnecessary things due to respawning electron from node and handling various entrypoints into booting cypress
- this also makes the root yarn dev and dev-debug work correctly because options.cwd is set correctly now

* perf: lazy load chalk

* remove excessive line since the file exists but is invalid

* fix types

* add system test when plugins function throws a synchronous error

* create new PLUGINS_INVALID_EVENT_ERROR, wire it up correctly for error template use

- properly pass error instance from child to ensure proper user stack frames
- move error display code into the right place

* only show a single stack trace, either originalError or internal cypressError

* push error html snapshots

* fix tests, types

* fix test

* fix failing tests

* fix tests

* fixes lots of broken tests

* more test fixes

* fixes more tests

* fix type checking

* wip: consistent handling of interpolated values

* feat: fixing up errors, added simple error comparison tool

* wrapping up error formatting

* Fixes for unit tests

* fix PLUGINS_VALIDATION_ERROR

* fix fs.readdir bug, show rows even if there's only markdown formatting [SKIP CI]

* when in base-list, show full width of errors

* Fix type errors

* added searching and filtering for files based on error name

* fix: system tests

* updated NO_SPECS_FOUND error to properly join searched folder + pattern

- join patterns off of process.cwd, not projectRoot
- highlight original specPattern in yellow, baseDir in blue
- add tests

* fixes failing tests

* fix test

* preserve original spec pattern, display relative to projectRoot for terminal banner

* make the nodeVersion path display in gray, not white

* fix tests, pass right variables

* fix chrome:canary snapshots

* update snapshots

* update snapshot

* strip newlines caused by "Still waiting to connect to {browser}..."

* don't remove the snapshotHtmlFolder in CI, add additional verification snapshots match to error keys symmetrically

* update snapshot

* update snapshot

* update snapshot

* update snapshot

* update snapshot

* update snapshot

* update gitignore

* fix snapshot

* update snapshot html

* update logic for parsing the resolve pattern matching, add tests

* update snapshots

* update snapshot

* update snapshot

* update snapshot

* fix failing test

* fix: error_message_spec

* fix snapshot

* run each variant through an it(...) so multiple failures are received

* add newlines to multiline formatters, add fmt.stringify, allow format overrides

* stringify invalid return values from plugins

* move config validation errors into packages/errors, properly highlight and stringify values

* add component testing yarn commands

* fix the arrow not showing on details

* fix typescript error

* fixed lots of poorly written tests that weren't actually testing anything. created settings validation error when given a string validation result.

* fixes tests

* fixes tests, adds new error template for validating within an array list (for browser validation)

* remove dupe line

* fix copy for consistency, update snapshots

* remove redundant errors, standardize formatting and phrasing

* more formatting

* remove excess snapshots

* prune out excessive error snapshot html files when not in CI

* add missing tests, add case for when config validation fails without a fileType

* fixes test

* update snapshot

* update snapshot

* update snapshot

* sort uniqErrors + errorKeys prior to assertion - assert one by one

* add system test for binding to an event with the wrong handler

* fixes tests

* set more descriptive errors when setting invalid plugin events, or during plugin event validation

* remove duplicate PLUGINS_EVENT_ERROR, collapse into existing error

* use the same multiline formatting as @packages/errors

* standardize verbiage and highlighting for consistency

* fix incorrect error path

* fixes tests, standardized and condensed more language

* Update packages/errors/src/errors.ts

Co-authored-by: Ryan Manuel <ryanm@cypress.io>

* Update guides/error-handling.md

Co-authored-by: Ryan Manuel <ryanm@cypress.io>

* Update guides/error-handling.md

Co-authored-by: Ryan Manuel <ryanm@cypress.io>

* added some final todo's

* fix types

Co-authored-by: Tim Griesser <tgriesser10@gmail.com>
Co-authored-by: Tim Griesser <tgriesser@gmail.com>
Co-authored-by: Ryan Manuel <ryanm@cypress.io>
2022-02-11 02:06:07 -05:00