Commit Graph

1135 Commits

Author SHA1 Message Date
Tim Griesser 675b78f19f fix remaining test failures 2022-02-21 18:38:05 -05:00
Tim Griesser 73def69360 Fixing CONFIG_VALIDATION_ERROR / SETUP_NODE_EVENTS_IS_NOT_FUNCTION errors 2022-02-21 17:37:39 -05:00
Tim Griesser 7e8370a2a5 working through mapping error cases from develop 2022-02-21 17:07:46 -05:00
Tim Griesser d3b1969a75 update CONFIG_FILE_REQUIRE_ERROR 2022-02-21 16:23:48 -05:00
Tim Griesser 4478048a6a fix: serialize details when serializing the error 2022-02-21 14:00:27 -05:00
Brian Mann 6f1353ed80 Merge branch '10.0-release' into 10.0-release-merge-4b50f9ee 2022-02-19 22:24:03 -05:00
Ryan Manuel cbc7cfc79a chore: fix server performance flake (#20280)
* chore: fix server performance flake

* rerun in circle

Co-authored-by: Brian Mann <brian.mann86@gmail.com>
2022-02-18 19:31:00 -06:00
Brian Mann cc37d79c7d export stripAnsi onto the old errors object 2022-02-18 17:34:37 -05:00
Brian Mann da48210216 Merge branch '10.0-release' into 10.0-release-merge-4b50f9ee 2022-02-18 15:11:59 -05:00
Tim Griesser 6727893b1e fix: additional cleanup of errors following merge 2022-02-17 09:59:30 -05:00
Tim Griesser 9a1874d6a8 fix: clean up a few test failures 2022-02-16 17:07:53 -05:00
Brian Mann f076a64f3b rename clone -> cloneErr 2022-02-15 02:15:15 -05:00
Brian Mann b8fb9abece fix missing ref 2022-02-15 02:03:57 -05:00
Brian Mann 923ab0a9ba export additional properties on error, update refs, fix tests 2022-02-15 02:03:14 -05:00
Brian Mann e53e74f1f3 export what is called directly to avoid circular ref proxy that's unstubbable 2022-02-14 20:49:35 -05:00
Brian Mann 81a0b0f0d2 fix require, lazy load if necessary 2022-02-14 18:58:34 -05:00
Tim Griesser 6279a7dd10 wip: type fixes & changes after merge 2022-02-14 08:20:11 -05:00
Tim Griesser 678bedeca6 Merge branch 'develop' into 10.0-release
* develop:
  feat: gray out the path to system node in cypress run header (#20121)
  feat: redesign server errors (#20072)
  test: fix awesome-typescript-loader test and remove test-binary job (#20131)
  fix: Fix issues with stack traces and command log in Chrome 99 (#20049)
  fix: `cy.type(' ')` fires click event on button-like elements. (#20067)
  fix: `change`, `input` events are not fired when the same option is selected again. (#19623)
  build: publish vue3 on latest (#20099)
  chore: release @cypress/webpack-preprocessor-v5.11.1
  chore: release @cypress/webpack-dev-server-v1.8.1
  fix: detect newly added specs in dev-server compilation (#17950)
  chore: Remove pkg/driver //@ts-nocheck part 3 (#19837)
  chore: set up semantic-pull-request GitHub Action (#20091)
  chore: release @cypress/react-v5.12.2
  fix: remove nullish coalescing in js files to support node 12 (#20094)
  docs: update @cypress/webpack-preprocessor links (#19902)
  refactor: use aliases instead of meta (#19566)
2022-02-13 15:36:48 -05:00
Ryan Manuel c52e07d576 feat: Update version checking logic to query the manifest and ensure ctx.util.fetch can handle a proxy (#20107)
Co-authored-by: Zach Bloomquist <git@chary.us>
2022-02-11 17:00:16 -06:00
Brian Mann 29841f32b9 feat: redesign server errors (#20072)
* chore: rename errors.js -> errors.ts

* refactor: type safety on errors

* refactor: add err_template for consistent error formatting

* fix a few system tests

* fix tests; update snapshots

* Fix types

* normalize snapshot - remove chalk ansi colors

* more unit test fixes

* more system test fixes

* circleci build

* backtick always in stdout, fix error formatting and failing snapshots

* refactor: create @packages/errors

* fix import

* fix import

* fixing build / tests

* remove extraneous file

* move warnIfExplicitCiBuildId

* fix build / tests

* Fix

* error, type fixes, documentation, standardize child process error serialization

* fix import

* build errors on install

* wrote specs generating visual images of all errors

* remove unused dep

* sanitize stack traces

* add image diffing

- if base images don't exist, create them
- if base images don't match and local, overwrite them, if in CI throw
- if base images are stale and local, delete them, if in CI throw

* remove Courier New + MesloLGS NF font

* type fixes, remove Bluebird, general cleanup

* TS Cleanup

* skip typecheck on tests for now

* yarn.lock

* fix @types/chai version

* fix yarn.lock

* Different version of mocha types so it isnt patched

* errors spec snapshot

* CI fix

* fixes

* store snapshot images in circle artifacts

* dont change artifact destination prefix

* use Courier Prime

* antialias the text

* decrease pixelmatch threshold, fail in CI only when changed pixels > 100

* increase timeout

* overflow: hidden, remove new Promise, add debug logging

Co-Authored-By: Tim Griesser <tgriesser@gmail.com>

* run unit tests w/ concurrency=1

* unique window per file

* disable app hardware acceleration + use in process gpu + single process

* do not do image diffing

- conditionally convert html to images
- store html snapshots
- do not store images in git

* store snapshot html

* Merge branch 'tgriesser/chore/refactor-errors' of https://github.com/cypress-io/cypress into tgriesser/chore/refactor-errors

* remove concurrency

* fix assertion

* fixing ci

* Link in readme

* pass the browsers to listItems

* fix: build @packages/errors in CI, defer import to prevent errors locally

* Merge branch 'develop' into tgriesser/chore/refactor-errors

* develop:
  chore: fix cypress npm package artifact upload path (#20023)
  chore(driver): move cy.within logic into it's own file (#20036)
  chore: update automerge workflows (#19982)
  fix(selectFile): use target window's File/DataTransfer classes (#20003)
  chore: Update Chrome (stable) to 98.0.4758.80 and Chrome (beta) to 98.0.4758.80 (#19995)
  fix: Adjust ffmpeg CLI args for performance (#19983)
  build: allow unified to run cypress on Apple Silicon (arm64) (backport #19067 to 9.x) (#19968)

* fix run-if-ci.sh

* remove dead code

* Mark the .html files as generated in gitattributes

* fix running single error case, slice out more of the brittle stack

* remove additional brittle stack line

* firefox web security error

* nest inside of describe

* reformat and redesign errors

* more error cleanup and standardization

* additional formatting of errors, code cleanup, refactoring

* update ansi colors to match terminal colors

* cleanup remaining loose ends, update several errors, compact excess formatters

* fix types

* additional formatting, remove TODO's, ensure no [object Object] in output

* add test for 412 server response on invalid schema

* update unknown dashboard error on creating run

* use fs.access instead of fs.stat for perf

* added PLUGINS_FILE_NOT_FOUND error

- separated out from PLUGINS_FILE_ERROR
- add system tests for both cases
- update snapshots
- remove stack trace from PLUGINS_FILE_NOT_FOUND fka PLUGINS_FILE_ERROR

* add plugins system test around plugins synchronously throwing on require

* remove forcing process.cwd() to be packages/server, update affected code

- this was a long needed hangover from very old code that was doing unnecessary things due to respawning electron from node and handling various entrypoints into booting cypress
- this also makes the root yarn dev and dev-debug work correctly because options.cwd is set correctly now

* perf: lazy load chalk

* remove excessive line since the file exists but is invalid

* fix types

* add system test when plugins function throws a synchronous error

* create new PLUGINS_INVALID_EVENT_ERROR, wire it up correctly for error template use

- properly pass error instance from child to ensure proper user stack frames
- move error display code into the right place

* only show a single stack trace, either originalError or internal cypressError

* push error html snapshots

* fix tests, types

* fix test

* fix failing tests

* fix tests

* fixes lots of broken tests

* more test fixes

* fixes more tests

* fix type checking

* wip: consistent handling of interpolated values

* feat: fixing up errors, added simple error comparison tool

* wrapping up error formatting

* Fixes for unit tests

* fix PLUGINS_VALIDATION_ERROR

* fix fs.readdir bug, show rows even if there's only markdown formatting [SKIP CI]

* when in base-list, show full width of errors

* Fix type errors

* added searching and filtering for files based on error name

* fix: system tests

* updated NO_SPECS_FOUND error to properly join searched folder + pattern

- join patterns off of process.cwd, not projectRoot
- highlight original specPattern in yellow, baseDir in blue
- add tests

* fixes failing tests

* fix test

* preserve original spec pattern, display relative to projectRoot for terminal banner

* make the nodeVersion path display in gray, not white

* fix tests, pass right variables

* fix chrome:canary snapshots

* update snapshots

* update snapshot

* strip newlines caused by "Still waiting to connect to {browser}..."

* don't remove the snapshotHtmlFolder in CI, add additional verification snapshots match to error keys symmetrically

* update snapshot

* update snapshot

* update snapshot

* update snapshot

* update snapshot

* update snapshot

* update gitignore

* fix snapshot

* update snapshot html

* update logic for parsing the resolve pattern matching, add tests

* update snapshots

* update snapshot

* update snapshot

* update snapshot

* fix failing test

* fix: error_message_spec

* fix snapshot

* run each variant through an it(...) so multiple failures are received

* add newlines to multiline formatters, add fmt.stringify, allow format overrides

* stringify invalid return values from plugins

* move config validation errors into packages/errors, properly highlight and stringify values

* add component testing yarn commands

* fix the arrow not showing on details

* fix typescript error

* fixed lots of poorly written tests that weren't actually testing anything. created settings validation error when given a string validation result.

* fixes tests

* fixes tests, adds new error template for validating within an array list (for browser validation)

* remove dupe line

* fix copy for consistency, update snapshots

* remove redundant errors, standardize formatting and phrasing

* more formatting

* remove excess snapshots

* prune out excessive error snapshot html files when not in CI

* add missing tests, add case for when config validation fails without a fileType

* fixes test

* update snapshot

* update snapshot

* update snapshot

* sort uniqErrors + errorKeys prior to assertion - assert one by one

* add system test for binding to an event with the wrong handler

* fixes tests

* set more descriptive errors when setting invalid plugin events, or during plugin event validation

* remove duplicate PLUGINS_EVENT_ERROR, collapse into existing error

* use the same multiline formatting as @packages/errors

* standardize verbiage and highlighting for consistency

* fix incorrect error path

* fixes tests, standardized and condensed more language

* Update packages/errors/src/errors.ts

Co-authored-by: Ryan Manuel <ryanm@cypress.io>

* Update guides/error-handling.md

Co-authored-by: Ryan Manuel <ryanm@cypress.io>

* Update guides/error-handling.md

Co-authored-by: Ryan Manuel <ryanm@cypress.io>

* added some final todo's

* fix types

Co-authored-by: Tim Griesser <tgriesser10@gmail.com>
Co-authored-by: Tim Griesser <tgriesser@gmail.com>
Co-authored-by: Ryan Manuel <ryanm@cypress.io>
2022-02-11 02:06:07 -05:00
Tim Griesser 6b539b05f5 feat: graphql over websockets (#20108)
* feat: graphql over websockets

Co-authored-by: Lachlan Miller <lachlan.miller.1990@outlook.com>
2022-02-10 16:28:37 -05:00
Ryan Manuel a015397f57 fix: reorder electron launching sequence to eliminate timing issue (#20140)
Co-authored-by: Emily Rohrbough  <emilyrohrbough@users.noreply.github.com>
2022-02-10 11:36:16 -06:00
Ryan Manuel 655090330f feat: Close and reopen a new tab in between tests to get around a memory leak (#19915) 2022-02-08 10:16:03 -06:00
Alejandro Estrada 6e803597a3 fix: update scaffold template to use correct path (#20047)
* fix: update scaffold template to use correct path

* Remove support for dynamic import on devServer

* Update scaffold template

* Update config files

* Update with feedback

* Rename cypressConfig to cypressDevServerConfig

* Update devserver link

* Update comment
2022-02-07 16:58:24 -05:00
Lachlan Miller bb37389157 chore: make error more informative about migration to Cypress 10 (#20007)
Co-authored-by: Zachary Williams <ZachJW34@gmail.com>
2022-02-07 14:48:18 +10:00
Tim Griesser d3a8744f19 Merge pull request #20004 from cypress-io/219138ca4e-develop-into-10.0-release
chore: merge develop (3987eb3430) into 10.0-release
2022-02-06 20:30:00 -05:00
Alejandro Estrada 5d52758d82 feat: validate specPattern root level (#19980)
* feat: validate specPattern root level

* Fix/add tests

* Fix test

* Update specExcludePattern

* Fix tests

* Fix/add tests

* Fix/add tests

* Fix tests

* Rename specExcludePattern to excludeSpecPattern

* Fix tests
2022-02-04 10:48:10 -05:00
Zach Bloomquist b694e33d5a Merge remote-tracking branch 'origin/develop' into 219138ca4e-develop-into-10.0-release 2022-02-02 15:08:51 -05:00
Blue F 2c1ecabf7d fix: Adjust ffmpeg CLI args for performance (#19983)
* Adjust ffmpeg CLI args for performance

* Properly use and clean up metadata file

* Always limit encoder to 1 thread regardless of os.cpu count

* Typo in last commit

* Add comments to ffmpeg args

* Remove threads arg, back to original threading behavior
2022-02-02 07:37:32 -08:00
Zachary Williams 02a669daae feat: relaunch browser when switching testing types from app (#19961)
Co-authored-by: Barthélémy Ledoux <bart@cypress.io>
2022-02-01 15:45:42 -06:00
Emily Rohrbough 99f24863a2 fix: move node 17 Check from Binary to CLI (#19977) 2022-01-31 12:03:36 -06:00
Zach Bloomquist 815fe3d913 fix: pass correct spec URL in cypress run on Windows (#19890)
Co-authored-by: Barthélémy Ledoux <bart@cypress.io>
2022-01-31 17:52:14 +00:00
Alejandro Estrada 805ed11345 fix: refactor set specs by specPattern (#19953)
* fix: refactor set specs by specPattern

* Update types

Co-authored-by: Zachary Williams <ZachJW34@gmail.com>
2022-01-31 10:48:38 -05:00
Zach Bloomquist b12e3c622f fix: Windows e2e project scaffolding issues (#19938) 2022-01-28 16:10:50 +00:00
Ryan Manuel 56626c62a8 feat: Focus browser from select browser screen and on dashboard login (#19842)
Co-authored-by: Zachary Williams <zachjw34@gmail.com>
2022-01-27 12:04:15 -06:00
Zach Bloomquist dfd70445b1 test(app): fix EBUSY/EPERM errors when running e2e tests on Windows (#19848)
Co-authored-by: Barthélémy Ledoux <bart@cypress.io>
Co-authored-by: ElevateBart <ledouxb@gmail.com>
2022-01-26 19:39:13 +00:00
Zachary Williams c49f045f82 feat: launchpad browser select (#19830)
Co-authored-by: Barthélémy Ledoux <bart@cypress.io>
2022-01-25 16:02:29 -06:00
Jennifer Shehane 3f8c0680b4 Merge pull request #19823 from cypress-io/1f70b21bc4-develop-into-10.0-release 2022-01-24 13:30:06 -06:00
Alejandro Estrada 8f32960ef8 fix: scaffold correct config file (#19776)
* fix: scaffold correct config file

* update setConfigFilePath

* Update test

* Update with code review

* remove default supportFile

* Update supportFile default value

* Add test

* Fix identation

* Update with feedback

* fix english pluralization

Co-authored-by: Tim Griesser <tgriesser10@gmail.com>
2022-01-24 10:23:44 -05:00
Emily Rohrbough f669c101e1 Merge branch '10.0-release' into 1f70b21bc4-develop-into-10.0-release 2022-01-21 15:50:16 -06:00
Tyler Biethman 1f70b21bc4 fix: Correctly parse single --spec globs containing a range (#19789) 2022-01-21 13:12:43 -06:00
Lachlan Miller 721e586625 feat: use unified app for run mode (#19625)
* start graphql server in run mode

* update url logic

* use correct mobx instance

* expose util method for testing selector playground

* add __Cypress__ global

* correctly order aut lifecycle methods

* correct spec url in tests

* fix server integration tests

* add title to html

* update url encoding

* uni test

* encoding

* encode ssr data as base64

* set correct cypress.spec.name

* set arch and os options

* add version to options

* update config test

* update encoding

* temp skip

* more skips

* try to fix launchpad tests

* update test

* update runner

* feat: automation

* ignore error

* remove unused runner steps

* try remove error

* config

* Ensuring a provided testId gets rendered on a consistent element reference within HeaderBar.

* better conditionals

* automation connection

* try applying firefox cdp automation

* skip spec

* skip for now

* skips

* respond to failed visit event correctly

* chore: fix screenshot system tests (#19686)

* set fake  __CYPRESS_MODE__ on window

* vue logic for screenshot + run-mode checks

* Restore AUT wrapper div, make the name more clear

* switch to await for `before:screenshot` event send

* remove skipped tests

* add CYPRESS_INTERNAL_MODE to env

* move logic into component

Co-authored-by: Lachlan Miller <lachlan.miller.1990@outlook.com>

* do not run runner-shared tests anymore

* dont care about runner unit test

* add reference screenshots confirmed to be good

* fix rerun spec

* do not hardcode http protocol, remove old code

* revert protocol and add missing pre-fetch gql query

* correctly pass ssr data, update request policy

* automation element updates

* do not apply CDP automation for firefox

* make assertions more debug-friendly

* up timeout, make firefox pixels slightly looser on CI

* Fix TS

* Try to fix tests

* Try to fix tests

* do not require urql for run mode

* wip: request policy changes

* use separate component for run mode and open mode

* expose selector playground function globally for testing purposes

* fix typescript

* fixing unit tests

* encode ssr data to match production

* fix test

* fix test

* readme

* fix: Run mode for unified runner resolve conflicts (#19743)

* merge in 10.0-release

* Fix merge conflict with client route

* Fail earlier when trying to run cypress in cypress in a browser other than chrome

* Fix some tests

* Set empty obj if config is not set

* Update tests

Co-authored-by: Lachlan Miller <lachlan.miller.1990@outlook.com>
Co-authored-by: Ryan Manuel <ryanm@cypress.io>

* update automation namespace, remove old code

* remove skipped test

* handle non proxied case

* clean up code

* revert png

* do not start graphql server in run mode

* Fix ts error

* revert type.cy.js to original test

* revert change in driver screenshot

* remove unused async

* remove unused env var

* remove old todo comment

* remove needless console.log

* unskip test

* use pause: true to avoid gql request

* remove unused automation element

* remove unused setAutomationStatus method

* change pane -> panel

* reimplement 1px flake fix for firefox type.cy.js

* chore: remove launchpad environment variable (#19778)

* remove LAUNCHPAD conditionals

* add timeout to test

* revert file

* correctly normalize url

Co-authored-by: Tyler Biethman <tbiethman@gmail.com>
Co-authored-by: Mark Noonan <oddlyaromatic@gmail.com>
Co-authored-by: Mark Noonan <mark@cypress.io>
Co-authored-by: Alejandro Estrada <estrada9166@gmail.com>
Co-authored-by: estrada9166 <estrada9166@hotmail.com>
Co-authored-by: Ryan Manuel <ryanm@cypress.io>
2022-01-20 15:02:00 +10:00
Tim Griesser f750aea088 refactor: namespace & consolidate launchpad / graphql routing (#19746)
* refactor: namespace & consolidate launchpad / graphql routing
* fix: ensure vite dev flow works
* fix: proper tslint, fix race condition
2022-01-19 17:43:42 -05:00
Chris Breiding edb4642328 chore: Use @typescript-eslint/indent instead of eslint's indent (#19772) 2022-01-19 13:38:16 -05:00
Rob 273b7035b0 fix: CLI filtering --spec when commas in glob pattern (#19557)
* Added is-glob as dependency for packages/server

* Parsed spec argv for glob patterns.

* Removed setGlob parameter.

* Updated glob implementation to revert side effects

* Removed is-glob dependency.

* Wrote parseSpecArgv method

* Added back resolvePath.

* Added unit tests.

* Added jsdoc & comments.

* pushing trivial update to kick off build

Co-authored-by: Matt Henkes <mjhenkes@gmail.com>
2022-01-18 09:10:07 -08:00
Alejandro Estrada 37a9cdbba3 fix: remove optional chaining from js files (#19702)
* fix: remove optional chaining from js files

* Revert un-needed changes

* Revert unintended changes
2022-01-18 16:01:13 +10:00
Ryan Manuel ed51bcbdda feat: Set up cypress in cypress (#19602)
Co-authored-by: Brian Mann <brian.mann86@gmail.com>
2022-01-14 17:07:07 -06:00
Alejandro Estrada 2755f139d9 feat: use electron folder select (#19692)
* Use electron folder select

* Fix TS

* Do not block mutation response

* Fix TS

* Update with feedback
2022-01-14 12:15:26 -05:00
Tim Griesser 0d5eae1b62 refactor: consistent getCtx in server, optional chaining for this._io calls (#19699)
* refactor: consistent getCtx in server, optional chaining for this._io calls
* fix: ensure the child process is cleaning up after itsself
2022-01-14 11:09:12 -05:00
Tim Griesser a9d0bc952b fix: various lifecycle issues, followup to #19572 (#19683)
* fix: various lifecycle issues, followup to #19572
2022-01-12 17:45:46 -05:00