* fix: chromium installed as a snap is properly detected
* add 5s timeout to browser detection
* remove .profile stuff
* use profilePath for alternative profile dirs
* rename legacyPathToProfiles
* update tests
Co-authored-by: Ben Kucera <14625260+Bkucera@users.noreply.github.com>
* Fix extra spacing in project nav
* Add a snapshot test to ensure nav styling is not mistakenly changed in future
* update yarn.lock
* improve nav css
- use flexbox to make nav respond better to different heights instead of using magic number
- ensure browsers have same heights so changing them doesn't change height of navbar and doesn't cause icons/text to shift
Co-authored-by: Chris Breiding <chrisbreiding@gmail.com>
Co-authored-by: Chris Breiding <chrisbreiding@users.noreply.github.com>
* Move org selector into it's own component
- have state of selected Id tracked and set before render.
* update yarn.lock
* fix/refactor org selector
* Add debug logs around creating project
Co-authored-by: Chris Breiding <chrisbreiding@gmail.com>
Co-authored-by: Chris Breiding <chrisbreiding@users.noreply.github.com>
* add experimental feature for sameSite
* allow experimental descriptions to render markdown
* sameSite support mostly working
* also strip sameSite from setCookie yielded value
* don't use `unspecified` - let browser set default
* add tests
* decaffeinate: Rename cdp_automation_spec.coffee from .coffee to .js
* decaffeinate: Convert cdp_automation_spec.coffee to JS
* decaffeinate: Run post-processing cleanups on cdp_automation_spec.coffee
* cleanup cdp_automation_spec.ts
* update unit tests
* update settings_spec to not render as markdown
* user-friendly error for insecure SameSite=None
* fix styling
* fix markdown renderer
* update types + schema
* use renderInline
* update experiment summary
* bind renderFn to md
* Fix "allowRendererProcessReuse" in open mode
The previous code would only fix it in run mode.
* don't show deprecations in prod, always show stack traces for deprecations
* clone IPC objects and remove unserializable values
* add ipc_bus_spec
* respond to PR feedback
* add Percy plugin and a single desktop-gui snapshot
* add desktop gui visual test to circle workflow
* update desktop-gui to start a server and not just visit dist/index.html
* add a few more visual snapshots for examples
* adjust Percy settings a little
* add start-test to desktop-gui
* update settings spec
* add packages/server experiments
* show experiments in desktop GUI
* add intro experiments text
* conditional message
* add experiments record to start of the headless run
* keep experiments in the config, remove duplicate logic
* small tweaks
* remove experimentalComponentTesting for now, separate PR
* rearrange settings spec into sections per panel
* do not crash if there are no experiments
* return component testing experiment
* work on styling of experiments panel + adding basic tests
* update settings spec text
* add unit tests for experimental features in cypress run output
* Add styling for 'non-enabled' status sign.
* add more experiments and key whitelist in experiments GUI
* add message when there are no experiments
* fix coffeelint
* fix merge in settings spec
* trailing whitespace
* make experiments info all live in one place
* add ts lint exception
* update unit test
* update run spec
* do not show experiments panel at all without experiments
* add more comments
* Update style of ON/OFF status for experimental features.
* remove empty messaging from experiments panel (since panel is no longer shown when empty)
* remove check for 'isEmpty' when showing list
* update lock file
Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
* feat: show collapsed icon on specs list title
* fix: fix conflicts and add tests
* remove duplicated test case - have one test for icon and collapse behavior
Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
* Turn exception message into something human readable
* Pass ipc as parameter to invoke function
* Creating file to validate event name and handler
* Creating tests to validate_event
* Remove ipc from invoke parameter
* Removing ipc parameter being passed to validateEvent
* convert spec to js
* increase line-height for plugins error message
* refactor error messages and implementation
* fix race condition where async error in plugins file could hang run
a quick async error at the root of the plugins file had the potential to hang the run because the ‘exitEarlyWithErr’ listener was registered later than that error was emitted
this enables that error to be tracked so we can properly exit at the appropriate time
it also refactors run.js to not rely on an event emitted on the project and instead passes through an onError handler, which makes more sense since the event was only used in run.js (except for one case). it also makes for easier unit testing
* fix missing reference
* fix duplicate reference
* fix args being passed in incorrectly
* fix way args were handled in server.open
* fix exit early implementation
* fix duplicate logging
* fix unit test
* update snapshot
* fix missing reference
* add e2e test to cover plugin registration validation
* clean up after merge
* add back snapshot
* fix e2e tests
Co-authored-by: Chris Breiding <chrisbreiding@users.noreply.github.com>
Co-authored-by: Zach Bloomquist <github@chary.us>
Co-authored-by: Jennifer Shehane <shehane.jennifer@gmail.com>
* desktop-gui: add toggle buttons to expand/collapse all sub folders. #6282
* lint code changes
* hide collapse/expand buttons when root spec has no folders
* fix indentation
* fix lint issue and refactor a bit
* Move collapse/expand links to right side of folder header
Co-authored-by: Chris Breiding <chrisbreiding@users.noreply.github.com>
Co-authored-by: Jennifer Shehane <shehane.jennifer@gmail.com>
* Adds retry button for project baseUrl warning
* Refactors project retry button
* Refactors to improve testability and adds tests
* Adds back reopenProject method
* Fixes warning message test errors
* Makes requested changes
* improve selectors
* fix dismissing warnings
* rename clear warning to dismiss warning
* refactor / improve
- only add retry button if it's the base url warning
- keep warning around while waiting for retry
- move tests to warning message spec
* disable retry button and show retrying message while retrying base url
Co-authored-by: ngunnarson <56410720+ngunnarson@users.noreply.github.com>
Co-authored-by: Jennifer Shehane <shehane.jennifer@gmail.com>
Co-authored-by: Chris Breiding <chrisbreiding@users.noreply.github.com>
- add needed deps in `ui-components` package
- upgrade `@cypress/webpack-preprocessor`
- refactor some eslint code, remove unused eslint scripts
- rename `build-js` scripts to `build-prod` since they'll only need to run when building for prod / checking for tsc errors
* enable using yarn
* enable lerna and yarn workspaces
No longer can reliably access node_modules via thei node_modules directory; yarn may optimize it via hoisting it up. This meant updating JS tasks that were copying files directly from node_modules directories. In these cases, pulled in a new package to resolve these correctly.
SCSS files remain impacted, but cannot easily import via JS. These paths have been modified, but it feels dangerous and incorrect to reach into a node_module to grab files like this.
Many prebuild steps were removed. I **think** the purpose of `check-deps-pre` is no longer needed, but need to confirm this.
* enabling test-unit script
removal of pretest-unit due to check-deps-pre
* removal of all `check-deps` and `check-deps-pre`
I do not think these are needed anymore
* remove npm run all
Replaced by `lerna run` and `lerna run --scope`
* use yarn in circle CI
appveyor to soon follow
* yarn in appveyor
* remove need for bin-upplaces using bin-up have a dev dependency on some package; mostly mocha. This mocha package will be optimized by yarn workspaces by hoisting it into the root; which is effectively what bin-up usage was mimicing.
* replace npm run with yarn in package files
* replace explict paths to internal packages with yarn bin
* remove unecessary link packages script and references
* properly require package for mocha
* removing yarn test in this package as it was just a proxy for test-*
* yarn test in root now reflects what is run in circle ci
* relax yarn version requirement for circle ci
* @packages/cli is really just cypress
also run test in parallel via `yarn test`; it runs test in all 10 packages
* ensure postinstall is called before prebuild
yarn does not call postinstall when nothing has installed; such is the case when everything has been cached
* vscode config uses yarn
* cannot rely on which node_modules dir a package is in
find the right node_module dir via `resolve-pkg`
* further relax yarn version for OSX build in circle ci
* resolve failing test
Regarding direct access to node_modules
* node version in mac build not sufficient
ignoring check of node/yarn versions when installing
* preinstall script does not exist
I **think** the reason to not install packages' modules (the reason for `--ignore-scripts` may be irrelevant with yarn workspaces managing the packages)
* upgrade mocha that was using --file
`--file` was introduce in >=5
* scope test runs to correct packages
* explictly close connections; otherwise script hangs after tests run
* refactor so npm and npx commads can be created
npx is used to utlize lerna for running across all packages sans cli
* properly resolve socket.io-client node_module
We cannot reach directly into node_modules to grab the socket.io-client file. Furthermore, running it locally will require resolving from a different cwd, the repo root, as opposed to the package's dist directory.
The existence of the file deterimes whether we are building the binary or running locally.
* remove unnecessary arg in vscode debug config
enable debugging in @packages/server to troubleshoot failing test
* another npm command found to be changed to yarn
* properly print colors to terminal
`lerna run` does not appear to print colors to the terminal properly. Changed to leverage `lerna exec`
See https://github.com/lerna/lerna/issues/1168
* add missing test scripts to packages that have partially have them
'test', 'test-unit', 'test-watch', and 'test-debug'
This makes running them from the root easier and enables debugging via IDE on more packages
* properly patch package in yarn workspaces
* another package needing to postinstall
* use existing script over explicit lerna exec
* patches must be copied to dist
* return to building on postinstall
* do not hoist driver's packagesThere are too many places we need driver's packages to not be hoisted when testing. We have *.html files in test with script tags srcing node_modules.
* wait-on is used in circle-ci and needs to be a root dep
No longer hoisted by `@packages/driver`. This previously worked only because it was hoisted. Adding it to root properly.
* update documentation based on new ergonomics
* launcher has unit tests that should be runnable via top level task
* more concise way to run build within cypress scope
* fix for unit test that never seemed to work
`getPathToExample` is really `getPathToExamples`
* bust cache based on yarn.lock changing
* define intra-dependencies among packages
Due to the way we build the binary, all are considered dev dependencies.
* address `jquery.scrollto` mismatched jquery version
Tell yarn to explicitly resolve `jquery@3.1.1` for any dependencies and sub-dependencies. The root issue is that `jquery.scrollto` package specifies jquery as a dependency instead of a peer dependency (which is correct). Its jquery version is set to the `>=1.8` which then resolves to 3.4.1. In doing so, it will patch its jquery instead of ours; meaning that `$.scrollTo` is not defined.
* add/remove deps from renovate
- bin-up is gone in favor of yarn workspaces and lerna from root
- check-deps is gone in favor of `yarn check --integrity`
- lerna added
* few misc yarn lock updates
* hope that this may speed up build binary
installing several of the same dep in >1 package will likely be sped up using yarn due to its machine-wide caching.
* yarn pack prefix version with a `v`
* auto-run `yarn install` when deps become out of date
When switching to a branch with a different set of required deps, running any of the main top level tasks (as seen in the `./CONTRIBUTING.md` guide) will check for deps changes via `yarn check --integrity` and run `yarn` in root if deps are out of sync.
* add clean top level task, remove prebuild
install => build => prebuild => check => install === no good
* address code review to undo formatting changes
* favor default imports over deconstructing imports
* favor @package resolution; pr feedback
* include a specific revision
for some reason, it cannot resolve the original SHA `29dafed297142d3b8a9d8a01842cbdf249a98b72`
using the next closes SHA
* properly cache yarn packagesfollowed guide: https://circleci.com/docs/2.0/yarn/
* lower barrier for contributors to get started
relax node version to be 12.0.0 or higher; will use node version found in `.node-version` in CI
* updates required after merging latest development
was getting type errors when building. recreating the `yarn.lock` file seemed to resolve the issue.
* hidden dep on a specific type version in server
made dep explicit and now it can build.
* update request to patched version
non-breaking changes to request was updated in server, but not everywhere else. It appears that transitive deps were using the 2.88.0 request version instead of the updated one for the server package.
* missing commit from previous commit/merge
* do not force a higher version of yarn than the default on circleci
* exclude e2e.js helper from stop-only command
* trying to bust node_modules cache.https://github.com/yarnpkg/yarn/issues/6412#issuecomment-537787740
* incorrect quotation tick placement
* fix: properly postinstall parse-domain
Do not explicitly script the shell invocation of a dependency's postinstall (parse-domain). The dependency's node_modules may not be where the package thinks they are and are not properly resolved.
It appears that postinstall will automatically be called when installing with yarn.
* run all CI stages
* fix win-appveyor-build.js
* Update CONTRIBUTING.md
Co-Authored-By: Zach Bloomquist <github@chary.us>
* Update CONTRIBUTING.md
Co-Authored-By: Zach Bloomquist <github@chary.us>
* Update CONTRIBUTING.md
Co-Authored-By: Zach Bloomquist <github@chary.us>
* Server package watching a specific test works correctly.
* PR feedback
* Correctly use yarn to pack (to get package size)
* correct size calculation
`yarn pack` does not output the file name like `npm pack` does. Correct this by explictly setting the filename.
* PR feedback
* PR feedback
* update readmes and testing commands from them
* do not include this in default build
* yarn is now installed by default
https://github.com/appveyor/ci/issues/1852
* do not include server in `yarn` auto build
* a few more npm references changed to yarn
* Revert "run all CI stages"
This reverts commit 9256aed99f.
* Update circle.yml
Co-Authored-By: Zach Bloomquist <github@chary.us>
Co-authored-by: Zach Bloomquist <github@chary.us>
* deprecate old API for before:browser:launch
* trigger ci
* allow chrome preferences to be overwritten in before:browser:launch
* add e2e test for chrome preferences
* add launchOptions.windowSize, refactor plugin handling into browser/utils
* async/await-ify chrome.ts, update e2e.js
* add padding to warning, allow more than 1 warning in run mode
* remove psInclude
* bump snap-shot-it, remove patch-package
* fix failing tests, tighten up code
* remove unused Promise.all
* more code cleanup from coffeescript conversion
* fix expectedExitcode
* update snapshot with cross origin error message
* more code cleanup from coffeescript conversion
* remove global state, cleanup normalizing stdout in snapshots
* fix asserting on the expected exit code
* remove firefox a default browser in e2e tests
* remove dupe const
* make onStdout return first arg by default
* remove only
* make expectedExitCode: 0 the default, remove duplicate option from all e2e tests
* fix test for electron
* reuse _getArgs() properly, tighten up dupe code, move perf e2e tests to use new e2e.it helpers
* make e2e test pass properly, and capture snapshot
- this was being overlooked because expectedExitCode wasn’t being set
(until now its the default)
* revert firefox specific changes to reduce PR diff
* remove newline
* temp 02/04/20 [skip ci]
* add more scenarios / return values
* rename plugin deprecation project fixture
* prevent warnings in run mode from being called multiple times in the same browser launch
- add plugin integration tests
- cleanup some promise code in browsers/chrome
- refactor the e2e deprecation tests
* update e2e deprecation specs, test that deprecation warning is displayed once per spec on a run
* cleanup let -> const, coffescript conversion
* bump snap-shot-it, remove patch-package
(cherry picked from commit ba23be5349)
* bump cli snap-shot-it
* cleanup: let -> const, parseFloat, formatting
* revert cross origin normalization
* fix spacing
* add types for plugin events
* dont pad warning message in run mode
* add e2e test for adding extensions before:browser:launch
* fix failing electron unit test, consolidate creating default launch options
* add extensions for electron + warning if install fails
* fix failing tests, yield the right before:browser:launch args signature
* e2e test electron via devtools extension
* remove .only
* add stdout assertions to e2e/1_deprecated_spec
* remove snapshot whitespace
* rename deprecation event
* update deprecated browser launch args warning message
* throw error on unexpected bbl property
* add tests for warning + error on bbl
* update snapshot
* revive 2 useful tests to validate how launchOption args are merged
* try fix e2e fullscreen spec, update snapshots
* tighten up code for throwing errors on unknown launch options properties
- list out the unknown and expected properties using existing
conventions
- tighten up the error message a bit
* rename options -> launchOptions, add e2e test for adding unknown properties to launchOptions, removed dupe snapshots
* fix fullscreen e2e test
* only push user gesture arg if chromium
* add e2e tests for throwing + rejecting errors, run e2e tests on all browsers, avoid ps logic only in electron
* remove conditional args in fullscreen test
* dont automatically install the latest version of chrome in circle
* add stubs for new electron properties
* switch from using port 5555 to 5544 to avoid common conflicts
* temporarily commenting out windowSize launchOption so release is unblocked and all tests pass
- can add it back in later once the e2e tests pass in CI
* make the path to chrome profile correctly dynamic to account for all operating systems
* remove magic length(8) and slice out the first 4 custom args set from the plugin launch options
* add back --start-maximized in chrome
* deleting windowSize-related code... for now!
Co-authored-by: Zach Bloomquist <github@chary.us>
Co-authored-by: Brian Mann <brian.mann86@gmail.com>
Co-authored-by: Chris Breiding <chrisbreiding@users.noreply.github.com>
* fix images in runner
* fix webpack not liking resolve: lodash + lodash/fp
* fix mobx deprecation warnings
* use real images for browser icons
* revert runs.json fixture
was only using changed values for screenshot purposes
* vertically and horizontally align browser icons in nav dropdown.
* Add edge browsers to fixture
* Add tests and icon support for Edge and Firefox variation browsers
* Fix icons resolution for retina displays
- make tests less strict to changes in icon size or extension
* Address situation where user was undefined in test runs.
* Fix vertical alignment of icons in runs list + add more icons to fixture
* Fix size of browser-icons in automation error page
* try not using nodeVersion: system
* try removing webpack resolve values
* put back webpack resolve values
* derp
* add tests for browser icon
* add support for firefox dev edition, firefox nightly, and edge canary
* add edge beta, edge dev, and family fallback
Co-authored-by: Jennifer Shehane <shehane.jennifer@gmail.com>
* Replaces Font Awesome icons with custom icons.svg
* Adds default browser icon, changes tests to display the correct image
* Adds project-nav test
* Fixes browsers icon aligment
* Adds getIcon function, Code refactor
* Fixes displays browsers icons test
* simplify css
* add css style to selected dropdown in order to better target css
* Add back test that was removed for generic icon
* Changes default generic browser icon
* Fixes Custom Browser Alignment
* Fixes default browser icon container
* have electron icon up one pixel to center vertically
Co-authored-by: Jennifer Shehane <shehane.jennifer@gmail.com>
* Update logic when looking for org to check length of orgs excluding default
- Also hide the ‘Me | Org’ selector altogether since it makes to sense
to be there, you can’t choose ‘Me’ because it doesn’t exist.
* Remove radios for 'me' and 'an org' entirely
- have default org show up as ‘Your personal organization’
* Select default org by default
* Preselect 'personal org' or first org in list by default
* clean up test selectors + fix failing runs list spec
* Add react-select for orgs select / add back showing avatar for 'personal org'
* Have loader properly display in setup project model when orgs are still loading