* fix: trim and remove double quotes around CYPRESS_INSTALL_BINARY
* linting
* add one more unit test for dequote
* add one more unit test
* fix jsdoc
* a few more edge unit tests
* fix(deps): update request-progress to 3.0.0 🌟
* Added method to utils to convert percent value to percentage
- Wrote unit tests for both calculateETA and the percent to percentage
conversion
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
* use is-html as a fallback to check if response is HTML
* end response with passthru stream
* clean up network_failures
* add test that visit passes with undef content-type
* handle empty responses too
* try to fix dtslint: bump package version 2
02-00000876
* fix failing tests via develop merge
Co-authored-by: Ben Kucera <14625260+Bkucera@users.noreply.github.com>
Co-authored-by: Brian Mann <brian.mann86@gmail.com>
* [#4461] Change typescript declaration for .writeFile()
* Fix dtslint error
* Add example to tsdoc definition
* Add testing example of new ts definition
* Fix trailling whitespace
* Ensure that test titles are strings before sanitizing them for screenshot names
* Fix linting errors
* stringify non-string title, return '' for null and undefined
* minor cleanup. extract to outer function. refactor to lodash.
Co-authored-by: Brian Mann <brian.mann86@gmail.com>
* fix programmatic blur events, allow typing into currently focused, fix getHostContenteditable
* intercept .blur
* reference issues in tests
* make tests account for conditional number of new lines inserted
- newer browsers insert a double new line, whereas older browsers dont
- write a helper that exposes the multiplier of new lines
* cleanup, remove dead code
* make tests dynamic when browser is or isn't out of focus
* cleanup, remove old notes, add more notes
* add failing tests for when native focus / blur are called multiple times
- need to handle not firing the events conditionally based on whether
or not the element would / should receive them
* remove old code for priming focus/blur events when window is out of focus
* remove dead code
* update focus_blur spec + add chai-subset
* decaffeinate: Rename focus_blur_spec.coffee from .coffee to .js
* decaffeinate: Convert focus_blur_spec.coffee to JS
* decaffeinate: Run post-processing cleanups on focus_blur_spec.coffee
* add failing test
* fix double blur/focus events
* make document.hasFocus always return true, add test
* fix focus events when non-focusable element
* remove unneeded retrun
* fix focusing body/ bluring active element on click
* forgot to call .get() with index
* fix focus issue with body/window
* still allow firefocus on window, skip firing focus if firstfocusable is window during click
* left out return in intercept blur/focus
* cleanup test code for focus_blur spec
* add tests to type_spec, focus_blur_spec
00-00005bfe
* update focus logic for click, fix dtslint error
06-00003d9c
* add tests for selectionchange event in focus_blur spec
01-00000dae
* set dep to exact version
06-00002320
* minor formatting
* intercept focus/blur for SVGElement
* add comment to type-into-already-focused logic
Co-authored-by: Brian Mann <brian.mann86@gmail.com>
Co-authored-by: Jennifer Shehane <shehane.jennifer@gmail.com>
* Fix issue where button of type='reset' would be activated during implicit form submission instead of button type='submit'
* Update to account for the fact that default type of button is 'submit'
Co-authored-by: Ben Kucera <14625260+Bkucera@users.noreply.github.com>
* add "be.focused" to chai_jquery
* add comment explaining the mess
* add type definitions
* refactor assertion to use jquery assertion
* remove trailing whitespace
* add test for multiple elements, update typedefs
* fix failing tests: not.be.visible -> not.exist
* allow should(not.be.visible) for failed selectors
* remove unrelated visibility changes
* extract only focus assertion
* Revert "Merge remote-tracking branch 'origin/develop' into issue-97-focus-assertion"
This reverts commit b401c32a61, reversing
changes made to ab14758d31.
* force jquery to use custom focus pseudo selector
* only force custom matchers for focus selectors
* rewrote matchesSelector wrap code
* add lodash
* Merge in origin/develop
* changes on 3.3.0
Co-authored-by: Brian Mann <brian.mann86@gmail.com>
* tighten up potential xvfb display problems
- improve the warning message on possible display problems
- reuse existing helper functions for platform detection
- instead of relying on timing mechanisms, if a possible display
problem is detected on linux - capture all of the stderr silently and
if the broken gtk message is detected, retry running
* consolidated and simplified smoke testing, xvfb error logging and messaging
- added —dev support to cypress verify cli command
* fix lots of tests, restore one error message
* fixed remaining CLI tests
* console.log pong only in electron mode
* remove dead code
* remove Node 4 support, bump packages that were previously approved but had removed Node 4 support
* Update snapshots to reflect whitespace changes made in commander dep
* bump supports-color dep (was previously not updated due to lack of Node 4 support)
* retry requests, basic e2e test
* basic e2e test for chrome behavior
* don't use timeouts to test
* some minor cleanup
* validate google chrome's retry behavior w/ a proxy
* get retries on network errors workin
* cleanup
* final changes before switching approach
* Reverting previous approach in request.coffee, server.coffee
* add retryOnNetworkFailure
* now works with retryOnStatusCodeFailure
* retry 4 times in addition to the 1 initial attempt
* add tests for subresources
* much improved error handling
* have the e2e test really work
* e2e baseurl check
* retry baseurl check
* remove special handling for node 8.2.1 bug
* WIP: continue making progress building out request retry
- swap out passthrough’s for pumpify / duplexify / pump
- clean up error handling / messaging / retry logic
* pipe clientrequest events
* buffer req body to disk, restore error handling/retrying
* don't bubble up errors from failed attempts
* actually pipe reqstream, oops
* add some e2e tests for request body
* revert lib/request.coffee to 7be1051
* add almost-working lazy-stream
* manually fire the 'pipe' event on the reqStream to copy headers to the outgoing message
- restore the ‘error’ propagation so that all tests pass for now
* cleanup leaking 'undefined' into stdout, causing failing e2e tests
- do not set onWarning as a property of project, just pass as an
argument
* add new options to request_spec, deduplicate default opts
* use stream buffer in request.coffee
* revert request.coffee
* last stream_buffer changes before removing fs stuff
* remove fs stuff from stream_buffer, add stream piping tests
* it works! :tada::tada:🎉 using duplexify to separate delayStream and reqBodyBuffer
* retry for .5s max on ECONNREFUSED
* add error codes
* don't timeout proxied requests
* restore baseurl check
* update new e2e tests
* make delay work with rp
* propagate clientresponse events
* removing tests that don't do anything now that we don't ESOCKETTIMEOUT on proxied requests
* add new visit, req options to index.d.ts
* don't fail on server-performance-test
* make retries with status code work again
* account for different stack trace in ci
* fix test
* retry https requests
* add tests for https passthru retries working
* clean up error handling for https-proxy
* fix failing https-proxy tests, tweak agent error handling to prevent multiple callbacks
* make expectedExitCode actual vs. expected in the correct order
* bump up e2e test timeout so it can retry and still work
* update tests
* retry up to 500ms on proxied requests
* add tests for incompatible options errors
* remove .only
* maybe this will help it act more consistently
* help e2e test work in ci
* don't reconnect on already made connections
* clarify naming
* wip: testing https proxy
* better debug calls
* WIP: getting proxy passthrough retry tests going
* handle retrying upstream proxy errors
- add tests for successfully retrying proxy errors and for unsuccessful
retries
- fix onClose errors when proxy connection is closed before enough data
is received
- fix not returning setTimeout correctly
* group related code accordingly
* do not build typescript by default, drop extension from main
* more TODO notes
* don't set a default NO_PROXY if NO_PROXY = ''
* debugging-proxy@2.0.0
* null out reqBodyBuffer when req finishes
* wip: retry in agent, not https-proxy [skip-ci]
* update https-proxy to use @packages/network retries
* retry after connection but before proxy tunnel established
* appease my linty overlords
* update https-proxy tests
* update agent specs, decided to still use tls.connect
it's easier to test and has less complexity
* test retrying HTTPS passthru
* debugging-proxy@2.0.1
* increase defaultCommandTimeout 100 -> 200 to prevent flake in CI
* auto formatting
* fix test to be dynamic and not rely on magic constants
* copy types field when linking proxy images, update packages/network types field
* linting
* add network index.js file
* linting
* improve error messaging experience when verifying base url
* only insert 1 new line
* fix failing test not binding to localhost
* removed test that's covered by e2e specs
* remove dash in 're-try'
* some cleanup for readability
* use allocUnsafe per perf
* unset NO_PROXY with an empty string
* move retry ensuring the baseUrl into url, cleanup some imperative code
* if the head is already present during connect, make connection, else wait for first head bytes
* minor formatting, clarity around conditions, naming
* rename retryInterval -> retryIntervals
* set defaults for requests during creation for clarity
* rename send -> sendPromise to pair better with sendStream
* use retryIntervals instead of juggling MAX_REQUEST_RETRIES
- ensure debug messages are consistent between request streams +
promises
- set static constants
* DRY up status check + network failure + retry logic
- keeps the debug logic identical between promises + streams
- ensures all logic paths are also consistent
- consolidates the pop’ing of intervals in a single place
* find / replace fail
* derp
* make the logic actually correct, set intervals as cloned defaults for recursive lookup
* pass arg correctly
* reduce debugging noise, formatting
* rename intervals -> delaysRemaining for clarity
* added unit tests around getDelayForRetry
* set retryIntervals as default options correctly, add unit tests
Co-authored-by: Brian Mann <brian.mann86@gmail.com>
Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
Co-authored-by: Gleb Bahmutov <gleb.bahmutov@gmail.com>
* cli: debug explanation for XVFB
* linting
* add chai-as-promised to CLI dev
* show Linux specific error solution if cannot verify
* add todo
* chore: consolidate github issue url logic
* linting
* add npm script lint-changed to quickly eslint fix changes JS files
* retry verify with our XVFB
* update errors and tests
* update CLI tests
* add test for display error message
* fix unit test
* add successful test with retry
* finish verify retry test
* warn users if hit display problem on first verify
* try to detect display problem when running electron and retry with our xvfb
* add warning message to spawn when attempting xvfb re-run
* add test for display retry behavior on spawn
* more comments for clarity
* fix typo
* fix(deps): update debug to 4.1.1 🌟
* bump cli 'debug' down to 3.2.6 - last version that still supports Node 4
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
Gleb Bahmutov