4 Commits

Author	SHA1	Message	Date
Zach Bloomquist	b8a6baaca3	Retry certain requests on failure (#4015) ... * retry requests, basic e2e test * basic e2e test for chrome behavior * don't use timeouts to test * some minor cleanup * validate google chrome's retry behavior w/ a proxy * get retries on network errors workin * cleanup * final changes before switching approach * Reverting previous approach in request.coffee, server.coffee * add retryOnNetworkFailure * now works with retryOnStatusCodeFailure * retry 4 times in addition to the 1 initial attempt * add tests for subresources * much improved error handling * have the e2e test really work * e2e baseurl check * retry baseurl check * remove special handling for node 8.2.1 bug * WIP: continue making progress building out request retry - swap out passthrough’s for pumpify / duplexify / pump - clean up error handling / messaging / retry logic * pipe clientrequest events * buffer req body to disk, restore error handling/retrying * don't bubble up errors from failed attempts * actually pipe reqstream, oops * add some e2e tests for request body * revert lib/request.coffee to 7be1051 * add almost-working lazy-stream * manually fire the 'pipe' event on the reqStream to copy headers to the outgoing message - restore the ‘error’ propagation so that all tests pass for now * cleanup leaking 'undefined' into stdout, causing failing e2e tests - do not set onWarning as a property of project, just pass as an argument * add new options to request_spec, deduplicate default opts * use stream buffer in request.coffee * revert request.coffee * last stream_buffer changes before removing fs stuff * remove fs stuff from stream_buffer, add stream piping tests * it works! :tada::tada:🎉 using duplexify to separate delayStream and reqBodyBuffer * retry for .5s max on ECONNREFUSED * add error codes * don't timeout proxied requests * restore baseurl check * update new e2e tests * make delay work with rp * propagate clientresponse events * removing tests that don't do anything now that we don't ESOCKETTIMEOUT on proxied requests * add new visit, req options to index.d.ts * don't fail on server-performance-test * make retries with status code work again * account for different stack trace in ci * fix test * retry https requests * add tests for https passthru retries working * clean up error handling for https-proxy * fix failing https-proxy tests, tweak agent error handling to prevent multiple callbacks * make expectedExitCode actual vs. expected in the correct order * bump up e2e test timeout so it can retry and still work * update tests * retry up to 500ms on proxied requests * add tests for incompatible options errors * remove .only * maybe this will help it act more consistently * help e2e test work in ci * don't reconnect on already made connections * clarify naming * wip: testing https proxy * better debug calls * WIP: getting proxy passthrough retry tests going * handle retrying upstream proxy errors - add tests for successfully retrying proxy errors and for unsuccessful retries - fix onClose errors when proxy connection is closed before enough data is received - fix not returning setTimeout correctly * group related code accordingly * do not build typescript by default, drop extension from main * more TODO notes * don't set a default NO_PROXY if NO_PROXY = '' * debugging-proxy@2.0.0 * null out reqBodyBuffer when req finishes * wip: retry in agent, not https-proxy [skip-ci] * update https-proxy to use @packages/network retries * retry after connection but before proxy tunnel established * appease my linty overlords * update https-proxy tests * update agent specs, decided to still use tls.connect it's easier to test and has less complexity * test retrying HTTPS passthru * debugging-proxy@2.0.1 * increase defaultCommandTimeout 100 -> 200 to prevent flake in CI * auto formatting * fix test to be dynamic and not rely on magic constants * copy types field when linking proxy images, update packages/network types field * linting * add network index.js file * linting * improve error messaging experience when verifying base url * only insert 1 new line * fix failing test not binding to localhost * removed test that's covered by e2e specs * remove dash in 're-try' * some cleanup for readability * use allocUnsafe per perf * unset NO_PROXY with an empty string * move retry ensuring the baseUrl into url, cleanup some imperative code * if the head is already present during connect, make connection, else wait for first head bytes * minor formatting, clarity around conditions, naming * rename retryInterval -> retryIntervals * set defaults for requests during creation for clarity * rename send -> sendPromise to pair better with sendStream * use retryIntervals instead of juggling MAX_REQUEST_RETRIES - ensure debug messages are consistent between request streams + promises - set static constants * DRY up status check + network failure + retry logic - keeps the debug logic identical between promises + streams - ensures all logic paths are also consistent - consolidates the pop’ing of intervals in a single place * find / replace fail * derp * make the logic actually correct, set intervals as cloned defaults for recursive lookup * pass arg correctly * reduce debugging noise, formatting * rename intervals -> delaysRemaining for clarity * added unit tests around getDelayForRetry * set retryIntervals as default options correctly, add unit tests Co-authored-by: Brian Mann <brian.mann86@gmail.com> Co-authored-by: Jennifer Shehane <jennifer@cypress.io> Co-authored-by: Gleb Bahmutov <gleb.bahmutov@gmail.com>	2019-05-15 12:46:55 -04:00
Zach Bloomquist	c1a345dce2	Improved proxy support (#3531) ... * https-proxy: unused file * server: wrap all https requests that use a proxy * server: use request lib in ensureUrl if proxy is in use. this makes runs tab work behind a proxy * electron: pass --proxy-server to app itself, so the embedded github login page works * cli: first attempt at env vars from windows registry * cli: api cleanup * cli: lint * cli: fix crash on no proxy, add tests * add desktop-gui watch to terminals.json * cli: pass along --proxy-source * electron: pass --proxy-bypass-list too * server: whitelist proxy* args * cli: better wording * desktop-gui: display proxy settings * extension: force proxy [wip] * extension: finally, i am victorious over coffeescript * extension: add -loopback to bypasslist * extension: revert changes Revert "extension: force proxy [wip]" This reverts commit 3ab6ba42a763f25ee65f12eb8b79eb597efc9b11. * desktop-gui: skip proxysettings if there aren't any * https-proxy, server: proxy directConnections using https-proxy-agent * https-agent: pool httpsAgents * https-proxy: work when they're not on a proxy * https-proxy: ci - use agent 1.0 * https-proxy: tests * desktop-gui: hide proxy settings when not using proxy * https-proxy: pass req through to https-proxy-agent callback * cli: use get-windows-proxy * desktop-gui: always show proxy settings * server: use get-windows-proxy * electron, server: supply electron proxy config when window launched * server: fix * https-proxy: cleanup * server: clean up ensureUrl * https-proxy: cleanup * cli: fix * cli: fix destructuring * server: enable ForeverAgent to pool HTTPS/HTTP connections #3192 * server: updating snapshot * https-proxy: don't crash, do error if proxy unreachable * https-proxy: * get-windows-proxy@1.0.0 * https-proxy: use proxy-from-env to decide on a proxy for a url * server: fallback to HTTP_PROXY globally if HTTPS_PROXY not set * server: proxy args test * cli: add proxy tests * cli: add test that loadSystemProxySettings is called during download * cli, server: account for the fact that CI has some proxy vars set * https-proxy: "" * cli, https-proxy, server: "" * desktop-gui: update settings gui * desktop-gui: cypress tests for proxy settings * server: strict undefined check * cli, server: move get-windows-proxy to scope, optionalDeps * server, cli: use new and improved get-windows-proxy * cli, server: 1.5.0 * server: re-check for proxy since cli may have failed to load the lib * server, cli: 1.5.1 * server: NO_PROXY=localhost by default, clean up * https-proxy: disable Nagle's on proxy sockets \#3192 * https-proxy: use setNoDelay on upstream, cache https agent * https-proxy: test basic auth * https-proxy: add todo: remove this * server: add custom HTTP(s) Agent implementation w keepalive, tunneling * server: typescript for agent * add ts to zunder * server: more ts * ts: add missing Agent type declaration * server: create CombinedAgent * server: use agent in more places * ts: more declarations * server: make script work even if debug port not supplied * server: begin some testing * server, ts: agent, tests * server: test * server: agent works with websockets now * server: update snapshot * server: work out some more bugs with websockets * server: more websockets * server: add net_profiler * https-proxy: fix dangling socket on direct connection * server: fix potential 'headers have already been sent' * https-proxy: nab another dangler * server: update test to expect agent * https-proxy: fix failing test * desktop-gui: change on-link * server: add tests for empty response case * server: tests * server: send keep-alive with requests * server: make net profiler hook on socket.connect * server: only hook profiler once * server: update tests, add keep-alive test * server: only regen headers if needed * server: move http_overrides into CombinedAgent, make it proxy-proof for #112 * server: update snapshot * server: undo * server: avoid circular dependency * https-proxy, server: use our Agent instead of https-proxy-agent * server: add dependency back * cli: actually use proxy for download * server, launcher, ts: typescript * Revert "server, launcher, ts: typescript" This reverts commit d3f8b8bbb6. * Revert "Revert "server, launcher, ts: typescript"" This reverts commit 818dfdfd00. * ts, server: respond to PR * server, ts: types * ts: really fix types * https-proxy, server: export CA from https-proxy * agent, server, https-proxy: move agent to own package * agent => networking, move connect into networking * fix tests * fix test * networking: respond to PR changes, add more unit tests * rename ctx * networking, ts: add more tests * server: add ensureUrl tests * https-proxy: remove https-proxy-agent * server: use CombinedAgent for API * server: updates * add proxy performance tests * add perf tests to workflow * circle * run perf tests with --no-sandbox * networking, ts: ch-ch-ch-ch-changes * server, networking: pr changes * run networking tests in circle * server: fix performance test * https-proxy: test that sockets are being closed * https-proxy: write, not emit * networking: fix test * networking: bubble err in connect * networking: style * networking: clean p connect error handling * networking => network * server: make perf tests really work * server: really report * server: use args from browser * server: use AI to determine max run time * server: load electron only when needed Co-authored-by: Brian Mann <brian@cypress.io>	2019-03-31 23:39:10 -04:00
Gleb Bahmutov	a5b7c20182	fix done callback	2017-08-15 15:25:13 -04:00
Chris Breidng	6efcf64005	remove core- prefixes from packages	2017-04-21 10:34:19 -04:00