Commit Graph

37 Commits

Author SHA1 Message Date
Ben Kucera fbd523615e [internal] Lint typescript, json, new eslint rules (#4449)
* temp 07/01/19 [skip ci] main lint files

* use lint-staged scripts

* fix all auto-fixable eslint errors

* manually fix lint issues in files

* temp 07/01/19 [skip ci]

* bump eslint plugin versions, update circle.yml

* [lint fix] remaining js files

* update vscode/settings.json

* add back stop-only

* use stop-only for linting .onlys

* fix verify_spec, build_spec

* update json plugin

* relint & apply corrections

* fix appveyor.yml not cleansing env vars (very bad)

* dont echo commit message in appveyor script

* retry build &

* re-add & upgrade lint-staged

* update contributing docs

* only let stop-only catch staged changes
2019-07-12 13:59:44 -04:00
Brian Mann 6850e68b48 do not mutate process.env when verifying (#4281) 2019-05-22 17:12:13 -04:00
Jennifer Shehane cacd122c67 Fix mixed use of both XVFB and Xvfb to all be Xvfb (#4262) 2019-05-21 10:33:59 -04:00
Brian Mann 77c62e010b improve CLI verify + run display warnings (#4230)
* tighten up potential xvfb display problems

- improve the warning message on possible display problems
- reuse existing helper functions for platform detection
- instead of relying on timing mechanisms, if a possible display
problem is detected on linux - capture all of the stderr silently and
if the broken gtk message is detected, retry running

* consolidated and simplified smoke testing, xvfb error logging and messaging

- added —dev support to cypress verify cli command

* fix lots of tests, restore one error message

* fixed remaining CLI tests

* console.log pong only in electron mode

* remove dead code
2019-05-17 09:12:03 -04:00
Gleb Bahmutov ebb8afdff4 logger warn from CLI should strip all indent from nested message (#4188) 2019-05-13 18:27:26 -04:00
Gleb Bahmutov d25cfacc6f Automatically retry verify and run commands on Linux if suspect DISPLAY problem (#4165)
* cli: debug explanation for XVFB

* linting

* add chai-as-promised to CLI dev

* show Linux specific error solution if cannot verify

* add todo

* chore: consolidate github issue url logic

* linting

* add npm script lint-changed to quickly eslint fix changes JS files

* retry verify with our XVFB

* update errors and tests

* update CLI tests

* add test for display error message

* fix unit test

* add successful test with retry

* finish verify retry test

* warn users if hit display problem on first verify

* try to detect display problem when running electron and retry with our xvfb

* add warning message to spawn when attempting xvfb re-run

* add test for display retry behavior on spawn

* more comments for clarity

* fix typo
2019-05-13 15:19:53 -04:00
Ben Kucera 1f0071002b Add timeout for cli/verify smoke test (#4080)
* temp 04/29/19 [skip ci] cli verify timeout

* add smoke test timeout error and tests

* cleanup code

* normalize snapshots for ci

* remove promise cancellation config

* cleanup error messaging and spacing for displaying the error details + descriptions


Co-authored-by: Brian Mann <brian.mann86@gmail.com>
2019-05-02 15:20:58 -04:00
Ben Kucera 5f771936e3 Fix flaky cli unit test (#3988)
* fix cli unit tests with mockfs

* mockfs fix flaky verify_spec
2019-04-17 19:10:48 -04:00
Gleb Bahmutov e0042a2009 Upgrade snap shot it to v6 in CLI package (#3761)
* update cli_spec

* linting

* update named snapshot to have 1 to match snap-shot-it v5

* update errors spec

* linting

* update snapshot use in download_spec

* update install_spec snapshot

* linting

* update use of snapshot in unzip_spec

* update snapshot use in verify_spec

* enable all CLI specs

* no need to skip snapshot sorting

* upgrade snap-shot-it to v6 in root

* update snap-shot-it to v6 in packages/server

* need to add build script to transpile

* update cypress_spec snapshot use with names
2019-03-21 10:39:28 -04:00
Gleb Bahmutov 1a7f631032 Reject promise stub with an error instance (#3751)
* reject promise stub with Error instance

* pass linter
2019-03-20 09:47:13 -04:00
Ben Kucera 0ffa701bdb update cypress install message (#2755)
fix #2754
2018-12-25 23:00:17 -08:00
Ben Kucera f90bfbec90 update ci error msg (#1928) 2018-06-20 00:14:15 -04:00
Ben Kucera db4a4a6d22 Improve Error logging around Cypress verify (#1986)
close #1984 improve error logging for `cypress verify`
close #1985 remove "skipping install" message to local users, keep in CI
2018-06-19 21:52:25 -04:00
Ben Kucera ca9cb8f10b env vars from configs, respect loglevel from npm (#1855) 2018-06-05 15:14:51 -04:00
Brian Mann 1d0b35bd47 Cli env var changes (#1734)
* wip [skip ci] update

* wip [skip ci] update test

* [skip ci] fix env var

* bump sinon, create helper utility to always throw when a stub is called without being given stubbed behavior

* update failing specs

* fix some error messages

* update snapshot

* warning -> note, add snapshot tests

* change snapshot os.release, test env vars
2018-05-19 15:37:52 -04:00
Ben Kucera 8a55864ae9 CLI caching (#1699)
* WIP [skip ci] tests passing -1

* WIP [skip ci] tests passing -1

* [WIP] [skip ci] more passing tests

* add run,open,verify cli tests

* fix package.json

* fix install_spec

* rename info_spec -> state_spec

* refactor cli options

* more useful logging

* change binary location, change folder name

* fix --binary-path arg

* update error message for cache

* lib/tasks/install.js changes

* add progress for direct unzip, prefer cache with override version with url/zip

* update cli logs

* prettier logs, remove arg

* fix failing test- stub os.release

* fix cli_spec snapshot, remove group and groupid args
2018-05-16 04:34:12 -04:00
Gleb Bahmutov 99302267df Banner to separate test output (#1190)
* cli: add mocha-banner so we can see what each test outputs

* linting
2018-01-16 13:22:00 -05:00
Gleb Bahmutov d22eb13e92 Verify command 545 (#550)
* find single line with ping value, close #545

* linting
2017-10-03 20:50:11 +00:00
Gleb Bahmutov 94b1d11856 Bring back commits (#522)
* add run serially console message

* linting

* root: add npm run all prune command (#513)

* build and install binary and NPM package locally on Circle

* pass env variable differently

* remove console.log from launcher

* listr delay

* longer listr delay in tests
2017-09-28 11:59:44 -04:00
Gleb Bahmutov 7d46fcde06 cli: extend test delay to avoid listr animation 2017-09-26 15:19:30 -04:00
Brian Mann 2b415cab4c cli: verify against installed version not package version when displaying first time opening message 2017-09-16 19:21:00 -04:00
Brian Mann 8255d37168 cli: add some delay to give listr some padding to update stdout 2017-09-06 16:39:01 -04:00
Brian Mann c1db121dd6 cli: disable welcome message when manually verifying, otherwise display 2017-09-05 01:26:37 -04:00
Brian Mann 90a0198e94 cli: move normalize function out of core lib, and into test support 2017-09-05 01:13:00 -04:00
Brian Mann 8e9183fa2d cli: continually normalize snapshots to get passing in CI 2017-09-04 20:31:04 -04:00
Brian Mann 335553f94b cli: when running in CI, use a different renderer to prevent ugly stream of stdout updates 2017-09-04 16:24:41 -04:00
Brian Mann 51c8da3afe cli: hopefully stripped the bad line by now 2017-09-04 15:10:41 -04:00
Brian Mann 1ed6f36e92 cli: try adding a delay for listr 2017-09-04 14:40:57 -04:00
Brian Mann 84950fe3aa cli: try stripping ansi codes, who knows 2017-09-04 14:39:52 -04:00
Brian Mann ddb2a43f2b cli: dealing with stupid whitespace snapshot issue 2017-09-04 14:05:46 -04:00
Brian Mann 1178c67a29 cli: better stdout normalization 2017-09-04 13:52:38 -04:00
Brian Mann 303db4d07f cli: update snapshots to unique name 2017-09-04 13:31:05 -04:00
Brian Mann 257357762d cli: normalize snapshot by removing lines that won't show up in CI 2017-09-04 13:15:35 -04:00
Brian Mann bbe2db065d cli: snapshot tests around verify 2017-09-04 11:25:11 -04:00
Brian Mann 7d41987b7b cli: WIP iterating on verify snapshots 2017-09-04 02:55:51 -04:00
Brian Mann ff55669874 cli: extract verify tests out of info, get tests passing 2017-09-04 01:55:08 -04:00
Brian Mann 77ea4fc5c2 WIP: rename all the specs, move them around, get it going! 2017-09-04 00:16:59 -04:00