From e287d745cbdcef789ca0af1dfd3b8c2d2e59f551 Mon Sep 17 00:00:00 2001
From: wd2365151147 <2365151147@qq.com>
Date: Tue, 23 Aug 2022 16:46:02 +0800
Subject: [PATCH] =?UTF-8?q?[inner-1830]=20fix=EF=BC=9Aresult=20of=20the=20?=
 =?UTF-8?q?a=20group=5Fconcat()=20is=20incorrect?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .../common/item/function/sumfunc/ItemFuncGroupConcat.java    | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/main/java/com/actiontech/dble/plan/common/item/function/sumfunc/ItemFuncGroupConcat.java b/src/main/java/com/actiontech/dble/plan/common/item/function/sumfunc/ItemFuncGroupConcat.java
index 10ceeaa6e..92db4a91f 100644
--- a/src/main/java/com/actiontech/dble/plan/common/item/function/sumfunc/ItemFuncGroupConcat.java
+++ b/src/main/java/com/actiontech/dble/plan/common/item/function/sumfunc/ItemFuncGroupConcat.java
@@ -102,8 +102,9 @@ public class ItemFuncGroupConcat extends ItemSum {
             String s = item.valStr();
             if (item.isNull())
                 return false;
-            rowStr.append(s).append(seperator);
+            rowStr.append(s);
         }
+        rowStr.append(seperator);
         if (orders != null) {
             if (sourceFields != null && rowComparator == null) {
                 rowComparator = new RowDataComparator(sourceFields, orders);
@@ -163,7 +164,7 @@ public class ItemFuncGroupConcat extends ItemSum {
                 append(orderResult.result);
             }
         }
-        return resultSb.substring(0, resultSb.length() - 1);
+        return resultSb.substring(0, resultSb.length() - seperator.length());
     }
 
     // append a row string