mirror of
https://github.com/decompme/decomp.me.git
synced 2026-05-04 05:51:43 -05:00
Partially incorporate PR feedback from Alex
- Reference `asm_differ` issue 56 - Add Typescript type for `DiffResponse` - Make `FormatDiffText` a JSX component - Handle missing `row.base`/`row.current`
This commit is contained in:
@@ -117,7 +117,8 @@ class AsmDifferWrapper:
|
||||
|
||||
display = Display(basedump, mydump, config)
|
||||
|
||||
# TODO: It would be nice to get a python object from `run_diff()` to avoid the JSON roundtrip
|
||||
# TODO: It would be nice to get a python object from `run_diff()` to avoid the
|
||||
# JSON roundtrip. See https://github.com/simonlindholm/asm-differ/issues/56
|
||||
result = json.loads(display.run_diff()[0])
|
||||
result["error"] = None
|
||||
|
||||
|
||||
Reference in New Issue
Block a user