mirror/dolt
1
0
Fork 0
mirror of https://github.com/dolthub/dolt.git synced 2026-02-11 02:59:34 -06:00
Code Issues Packages Projects Releases 128 Wiki Activity

Diff: We can never get nil as a Value (#2108)

Browse Source 
...so remove the handling of that and panic.
This commit is contained in:
Erik Arvidsson
2016-07-20 14:53:09 -07:00
committed by GitHub
parent 74200673d4
commit 00105d649e
1 changed files with 1 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
cmd/noms/diff/diff.go
View File

@@ -34,12 +34,7 @@ func Diff(w io.Writer, v1, v2 types.Value) (err error) {
err = d.Try(func() {
for di, ok := dq.PopFront(); ok; di, ok = dq.PopFront() {
p, key, v1, v2 := di.path, di.key, di.v1, di.v2
if v1 == nil && v2 != nil {
line(w, addPrefix, key, v2)
}
if v1 != nil && v2 == nil {
line(w, subPrefix, key, v1)
}
d.Chk.True(v1 != nil && v2 != nil) // nil is not a valid types.Value and we should never get one
if !v1.Equals(v2) {
if !canCompare(v1, v2) {
line(w, subPrefix, key, v1)