From 052d3d73c8ec69a2e6707b1dc53032cb33b7abd3 Mon Sep 17 00:00:00 2001 From: Ian Davis Date: Sun, 3 Sep 2017 16:22:50 +0100 Subject: [PATCH] Don't ignore spec split error in ForDatasetOpts --- go/spec/spec.go | 3 +++ go/spec/spec_test.go | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/go/spec/spec.go b/go/spec/spec.go index 822af50326..9346946140 100644 --- a/go/spec/spec.go +++ b/go/spec/spec.go @@ -90,6 +90,9 @@ func ForDataset(spec string) (Spec, error) { // ForDatasetOpts parses a spec for a Dataset. func ForDatasetOpts(spec string, opts SpecOptions) (Spec, error) { dbSpec, pathStr, err := splitDatabaseSpec(spec) + if err != nil { + return Spec{}, err + } sp, err := newSpec(dbSpec, opts) if err != nil { diff --git a/go/spec/spec_test.go b/go/spec/spec_test.go index ec4e18cffc..b0934cd259 100644 --- a/go/spec/spec_test.go +++ b/go/spec/spec_test.go @@ -91,7 +91,7 @@ func TestMemDatasetPathSpec(t *testing.T) { db := spec.GetDatabase() ds := db.GetDataset("test") - ds, err = db.CommitValue(ds, types.NewList(db, types.Number(42))) + _, err = db.CommitValue(ds, types.NewList(db, types.Number(42))) assert.NoError(err) assert.Equal(types.Number(42), spec.GetValue())