Merge pull request #1534 from dolthub/andy/select-into-auto-increment

/go/libraries/doltcore/sqle: Fix `SELECT INTO ...` bug for `AUTO_INCREMENT` columns
This commit is contained in:
AndyA
2021-04-12 18:16:53 -07:00
committed by GitHub
3 changed files with 19 additions and 7 deletions

View File

@@ -18,7 +18,7 @@ require (
github.com/denisbrodbeck/machineid v1.0.1
github.com/dolthub/dolt/go/gen/proto/dolt/services/eventsapi v0.0.0-20201005193433-3ee972b1d078
github.com/dolthub/fslock v0.0.2
github.com/dolthub/go-mysql-server v0.9.1-0.20210408173909-fac6d728eba4
github.com/dolthub/go-mysql-server v0.9.1-0.20210409231014-6ce64dcb9c6c
github.com/dolthub/ishell v0.0.0-20210205014355-16a4ce758446
github.com/dolthub/mmap-go v1.0.4-0.20201107010347-f9f2a9588a66
github.com/dolthub/sqllogictest/go v0.0.0-20201105013724-5123fc66e12c

View File

@@ -141,12 +141,8 @@ github.com/dgrijalva/jwt-go v3.2.0+incompatible/go.mod h1:E3ru+11k8xSBh+hMPgOLZm
github.com/dgryski/go-sip13 v0.0.0-20181026042036-e10d5fee7954/go.mod h1:vAd38F8PWV+bWy6jNmig1y/TA+kYO4g3RSRF0IAv0no=
github.com/dolthub/fslock v0.0.2 h1:8vUh47iKovgrtXNrXVIzsIoWLlspoXg+3nslhUzgKSw=
github.com/dolthub/fslock v0.0.2/go.mod h1:0i7bsNkK+XHwFL3dIsSWeXSV7sykVzzVr6+jq8oeEo0=
github.com/dolthub/go-mysql-server v0.9.1-0.20210407215342-cf396ae74c61 h1:noGlmT++VHYsWt14Vl6v5UavA/OkW04/rxKmTHH7BiY=
github.com/dolthub/go-mysql-server v0.9.1-0.20210407215342-cf396ae74c61/go.mod h1:44ueL8vpS1wc/YN02RvRB+G0rjq1nC/IAKEoDPoEZbg=
github.com/dolthub/go-mysql-server v0.9.1-0.20210407235314-7c641a48ecc2 h1:MLJDS8q8nMGkP5SadwILP+vL0qFh2B4W0sYyZuBu4JM=
github.com/dolthub/go-mysql-server v0.9.1-0.20210407235314-7c641a48ecc2/go.mod h1:44ueL8vpS1wc/YN02RvRB+G0rjq1nC/IAKEoDPoEZbg=
github.com/dolthub/go-mysql-server v0.9.1-0.20210408173909-fac6d728eba4 h1:3Z1vxrEO9/KUmtErowTb81pP4UvoKU+WHDdgOzSY/p0=
github.com/dolthub/go-mysql-server v0.9.1-0.20210408173909-fac6d728eba4/go.mod h1:44ueL8vpS1wc/YN02RvRB+G0rjq1nC/IAKEoDPoEZbg=
github.com/dolthub/go-mysql-server v0.9.1-0.20210409231014-6ce64dcb9c6c h1:5xvrm/gmOUrUVMGtBvB7U3maPUA1wksa2Gtb4tufbfo=
github.com/dolthub/go-mysql-server v0.9.1-0.20210409231014-6ce64dcb9c6c/go.mod h1:44ueL8vpS1wc/YN02RvRB+G0rjq1nC/IAKEoDPoEZbg=
github.com/dolthub/ishell v0.0.0-20210205014355-16a4ce758446 h1:0ol5pj+QlKUKAtqs1LiPM3ZJKs+rHPgLSsMXmhTrCAM=
github.com/dolthub/ishell v0.0.0-20210205014355-16a4ce758446/go.mod h1:dhGBqcCEfK5kuFmeO5+WOx3hqc1k3M29c1oS/R7N4ms=
github.com/dolthub/mmap-go v1.0.4-0.20201107010347-f9f2a9588a66 h1:WRPDbpJWEnPxPmiuOTndT+lUWUeGjx6eoNOK9O4tQQQ=

View File

@@ -319,4 +319,20 @@ SQL
[[ "${lines[4]}" =~ "4,4" ]] || false
[[ "${lines[5]}" =~ "5,5" ]] || false
[[ "${lines[6]}" =~ "6,6" ]] || false
}
@test "auto_increment: INSERT INTO SELECT ..." {
dolt sql <<SQL
CREATE TABLE other (pk int PRIMARY KEY);
INSERT INTO other VALUES (1),(2),(3);
SQL
dolt sql -q "INSERT INTO test (c0) SELECT pk FROM other;"
run dolt sql -q "SELECT * FROM test;" -r csv
[ "$status" -eq 0 ]
[[ "${lines[0]}" =~ "pk,c0" ]] || false
[[ "${lines[1]}" =~ "1,1" ]] || false
[[ "${lines[2]}" =~ "2,2" ]] || false
[[ "${lines[3]}" =~ "3,3" ]] || false
}