From 459d98defe63368cda2efc1611ba839e779e9708 Mon Sep 17 00:00:00 2001 From: Aaron Son Date: Tue, 12 Oct 2021 15:39:49 -0700 Subject: [PATCH] Add a TODO to seek in FindCommonAncestor implementation. --- go/store/datas/commit.go | 1 + 1 file changed, 1 insertion(+) diff --git a/go/store/datas/commit.go b/go/store/datas/commit.go index 65ec48c0a3..6ffad66b30 100644 --- a/go/store/datas/commit.go +++ b/go/store/datas/commit.go @@ -193,6 +193,7 @@ func FindCommonAncestor(ctx context.Context, c1, c2 types.Ref, vr1, vr2 types.Va return r, true, nil } if pi1.Less(vr1.Format(), pi2) { + // TODO: Should pi2.Seek(pi1.curr), but MapIterator does not expose Seek yet. if !pi2.Next(ctx) { return types.Ref{}, false, firstError(pi1.Err(), pi2.Err()) }