From e4558453aabbccde2e73acb6f4e5781d46435c35 Mon Sep 17 00:00:00 2001 From: Aaron Son Date: Fri, 31 Mar 2023 14:45:39 -0700 Subject: [PATCH] go/libraries/doltcore/doltdb: durable/table: Always write the table value we are refing. Ensures it always makes it across the GC safepoint. --- go/libraries/doltcore/doltdb/durable/table.go | 22 +------------------ 1 file changed, 1 insertion(+), 21 deletions(-) diff --git a/go/libraries/doltcore/doltdb/durable/table.go b/go/libraries/doltcore/doltdb/durable/table.go index df60b20f85..9de813af49 100644 --- a/go/libraries/doltcore/doltdb/durable/table.go +++ b/go/libraries/doltcore/doltdb/durable/table.go @@ -668,27 +668,7 @@ func (t nomsTable) DebugString(ctx context.Context) string { } func refFromNomsValue(ctx context.Context, vrw types.ValueReadWriter, val types.Value) (types.Ref, error) { - valRef, err := types.NewRef(val, vrw.Format()) - - if err != nil { - return types.Ref{}, err - } - - targetVal, err := valRef.TargetValue(ctx, vrw) - - if err != nil { - return types.Ref{}, err - } - - if targetVal == nil { - _, err = vrw.WriteValue(ctx, val) - - if err != nil { - return types.Ref{}, err - } - } - - return valRef, err + return vrw.WriteValue(ctx, val) } func schemaFromRef(ctx context.Context, vrw types.ValueReadWriter, ref types.Ref) (schema.Schema, error) {