From 71fd4c2e04690d4472fc21fe9f85bf10a25edf12 Mon Sep 17 00:00:00 2001 From: Zach Musgrave Date: Fri, 6 Feb 2026 18:06:55 -0800 Subject: [PATCH 1/2] fix panic for empty table names, now a normal error --- go/libraries/doltcore/doltdb/root_val_storage.go | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/go/libraries/doltcore/doltdb/root_val_storage.go b/go/libraries/doltcore/doltdb/root_val_storage.go index 6a7deabe57..fdc5b32db8 100755 --- a/go/libraries/doltcore/doltdb/root_val_storage.go +++ b/go/libraries/doltcore/doltdb/root_val_storage.go @@ -472,6 +472,10 @@ func encodeTableNameForSerialization(name TableName) string { // decodeTableNameFromSerialization decodes a table name from a serialized string. See notes on serialization in // |encodeTableNameForSerialization| func decodeTableNameFromSerialization(encodedName string) (TableName, bool) { + if len(encodedName) == 0 { + return TableName{}, false + } + if encodedName[0] != 0 { return TableName{Name: encodedName}, true } else if len(encodedName) >= 4 { // 2 null bytes plus at least one char for schema and table name @@ -492,8 +496,8 @@ func decodeTableNameForAddressMap(encodedName, schemaName string) (string, bool) if schemaName == "" && encodedName[0] != 0 { return encodedName, true } else if schemaName != "" && encodedName[0] == 0 && - len(encodedName) > len(schemaName)+2 && - encodedName[1:len(schemaName)+1] == schemaName { + len(encodedName) > len(schemaName)+2 && + encodedName[1:len(schemaName)+1] == schemaName { return encodedName[len(schemaName)+2:], true } return "", false From 7ef81ec08cfe5915eda27833773bd337e2cb9a60 Mon Sep 17 00:00:00 2001 From: zachmu Date: Sat, 7 Feb 2026 02:16:19 +0000 Subject: [PATCH 2/2] [ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/update.sh --- go/libraries/doltcore/doltdb/root_val_storage.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/go/libraries/doltcore/doltdb/root_val_storage.go b/go/libraries/doltcore/doltdb/root_val_storage.go index fdc5b32db8..60dfc67d14 100755 --- a/go/libraries/doltcore/doltdb/root_val_storage.go +++ b/go/libraries/doltcore/doltdb/root_val_storage.go @@ -496,8 +496,8 @@ func decodeTableNameForAddressMap(encodedName, schemaName string) (string, bool) if schemaName == "" && encodedName[0] != 0 { return encodedName, true } else if schemaName != "" && encodedName[0] == 0 && - len(encodedName) > len(schemaName)+2 && - encodedName[1:len(schemaName)+1] == schemaName { + len(encodedName) > len(schemaName)+2 && + encodedName[1:len(schemaName)+1] == schemaName { return encodedName[len(schemaName)+2:], true } return "", false