From b2a8e85a12501c5251e27ab81bdb444190dd616d Mon Sep 17 00:00:00 2001 From: Lars Lehtonen Date: Tue, 9 Mar 2021 14:34:21 -0800 Subject: [PATCH 1/2] libraries/doltcore/table/untyped/csv: fix dropped errors --- go/libraries/doltcore/table/untyped/csv/writer_test.go | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/go/libraries/doltcore/table/untyped/csv/writer_test.go b/go/libraries/doltcore/table/untyped/csv/writer_test.go index 775963a4b7..bd85621b8f 100644 --- a/go/libraries/doltcore/table/untyped/csv/writer_test.go +++ b/go/libraries/doltcore/table/untyped/csv/writer_test.go @@ -101,6 +101,9 @@ Andy Anderson,27, writeToCSV(csvWr, rows, t) results, err := fs.ReadFile(path) + if err != nil { + t.Fatal(err) + } if string(results) != expected { t.Errorf(`%s != %s`, results, expected) } @@ -130,6 +133,9 @@ Andy Anderson|27| writeToCSV(csvWr, rows, t) results, err := fs.ReadFile(path) + if err != nil { + t.Fatal(err) + } if string(results) != expected { t.Errorf(`%s != %s`, results, expected) } From ce52ad1fae7f37b3a1749e238231cd73bbb6e1b3 Mon Sep 17 00:00:00 2001 From: Lars Lehtonen Date: Tue, 9 Mar 2021 14:35:21 -0800 Subject: [PATCH 2/2] libraries/doltcore/table/untyped/xlsx: fix dropped error --- go/libraries/doltcore/table/untyped/xlsx/reader.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/go/libraries/doltcore/table/untyped/xlsx/reader.go b/go/libraries/doltcore/table/untyped/xlsx/reader.go index 93a6ede080..d0a11a63d5 100644 --- a/go/libraries/doltcore/table/untyped/xlsx/reader.go +++ b/go/libraries/doltcore/table/untyped/xlsx/reader.go @@ -78,6 +78,9 @@ func OpenXLSXReader(ctx context.Context, vrw types.ValueReadWriter, path string, br := bufio.NewReaderSize(r, ReadBufSize) colStrs, err := getColHeadersFromPath(path, info.SheetName) + if err != nil { + return nil, err + } data, err := getXlsxRowsFromPath(path, info.SheetName) if err != nil {