integration-tests/go-sql-server-driver: Move some magic numbers/strings to constants.

This commit is contained in:
Aaron Son
2022-10-03 15:19:59 -07:00
parent 04947a44a0
commit b3dc25fc57
2 changed files with 11 additions and 5 deletions

View File

@@ -31,6 +31,12 @@ import (
var DoltPath string
const TestUserName = "Bats Tests"
const TestEmailAddress = "bats@email.fake"
const ConnectAttempts = 50
const RetrySleepDuration = 10 * time.Millisecond
func init() {
var err error
DoltPath, err = exec.LookPath("dolt")
@@ -64,11 +70,11 @@ func NewDoltUser() (DoltUser, error) {
if err != nil {
return DoltUser{}, err
}
err = res.DoltExec("config", "--global", "--add", "user.name", "Bats Tests")
err = res.DoltExec("config", "--global", "--add", "user.name", TestUserName)
if err != nil {
return DoltUser{}, err
}
err = res.DoltExec("config", "--global", "--add", "user.email", "bats@email.fake")
err = res.DoltExec("config", "--global", "--add", "user.email", TestEmailAddress)
if err != nil {
return DoltUser{}, err
}
@@ -286,12 +292,12 @@ func (s *SqlServer) DB() (*sql.DB, error) {
if err != nil {
return nil, err
}
for i := 0; i < 50; i++ {
for i := 0; i < ConnectAttempts; i++ {
err = db.Ping()
if err == nil {
return db, nil
}
time.Sleep(10 * time.Millisecond)
time.Sleep(RetrySleepDuration)
}
if err != nil {
return nil, err

View File

@@ -337,7 +337,7 @@ func RetryTestRun(t *testing.T, attempts int, test func(require.TestingT)) {
var rtt *retryTestingT
for i := 0; i < attempts; i++ {
if i != 0 {
time.Sleep(50 * time.Millisecond)
time.Sleep(RetrySleepDuration)
}
rtt = new(retryTestingT)
rtt.T = t