PR feedback

This commit is contained in:
Zach Musgrave
2021-08-05 12:51:29 -07:00
parent 5b1aa2f3ef
commit bfe976375f
3 changed files with 3 additions and 1 deletions

View File

@@ -12,6 +12,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.
// Package testcommands TODO: kill off this package, replace with the non-test commands directly
package testcommands
import (

View File

@@ -26,7 +26,7 @@ func StageTables(ctx context.Context, roots doltdb.Roots, docs doltdocs.Docs, tb
var err error
roots.Working, err = doltdocs.UpdateRootWithDocs(ctx, roots.Working, docs)
if err != nil {
return doltdb.Roots{}, nil
return doltdb.Roots{}, err
}
}

View File

@@ -946,6 +946,7 @@ func (dEnv *DoltEnv) TempTableFilesDir() string {
}
// GetGCKeepers returns the hashes of all the objects in the environment provided that should be perserved during GC.
// TODO: this should be unnecessary since we now store the working set in a noms dataset, remove it
func GetGCKeepers(ctx context.Context, env *DoltEnv) ([]hash.Hash, error) {
workingRoot, err := env.WorkingRoot(ctx)
if err != nil {