From f4e91667b0c7f5c53111afa23dadc4b15095b5dc Mon Sep 17 00:00:00 2001 From: Taylor Bantle Date: Thu, 12 Jan 2023 16:40:46 -0800 Subject: [PATCH] Some clean up, completely skip TestErrorIfDangling --- go/store/nbs/gc_copier.go | 5 ----- go/store/types/value_store_test.go | 4 +--- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/go/store/nbs/gc_copier.go b/go/store/nbs/gc_copier.go index 16ffea88e0..6dbd4c6e25 100644 --- a/go/store/nbs/gc_copier.go +++ b/go/store/nbs/gc_copier.go @@ -83,12 +83,7 @@ func (gcc *gcCopier) copyTablesToDir(ctx context.Context, tfp tableFilePersister return nil, err } - // file already exists if exists { - // TODO(taylor) - // if gcc.writer.ContentLength() != uint64(tfp.ContentLength()) { - // return nil, fmt.Errorf("'%s' already exists with different contents.", filename) - // } return []tableSpec{ { name: addr, diff --git a/go/store/types/value_store_test.go b/go/store/types/value_store_test.go index a3b502da75..92cdc06a08 100644 --- a/go/store/types/value_store_test.go +++ b/go/store/types/value_store_test.go @@ -319,10 +319,8 @@ func TestPanicOnBadVersion(t *testing.T) { } func TestErrorIfDangling(t *testing.T) { + t.Skip("WriteValue errors with dangling ref error") vs := newTestValueStore() - if vs.Format() == Format_DOLT { - t.Skip("WriteValue errors with dangling ref error") - } r, err := NewRef(Bool(true), vs.Format()) require.NoError(t, err)