Commit Graph

20 Commits

Author SHA1 Message Date
Dan Willhite
46586ee928 Remove msg args from d.PanicIfTrue and d.PanicIfFalse. (#2757)
Should discourage people from writing code that does unnecessary work
to generate a msg every time that an error condition is checked. Fixes #2741
2016-11-03 11:43:57 -07:00
Mike Gray
4e54c44d56 no functional changes, improving code quality (#2410)
fix misspellings; fix code that was not gofmt'd - plus take advantage of gofmt -s too; couple of unreachable golint reported fixes; reference go report card results and tests
2016-08-23 13:51:38 -04:00
Aaron Boodman
1d752e3101 Update license: Noms will be copyright Attic Labs. (#1976) 2016-07-05 22:07:42 -07:00
Dan Willhite
095d49fa84 New error handling. 2016-06-22 12:11:31 -07:00
Aaron Boodman
155a388c64 Fix build break in tools/ 2016-06-05 02:46:02 -07:00
Aaron Boodman
40d485bd03 Licensify everything 2016-05-30 14:32:28 -07:00
Ben Kalman
6187e76325 Replace stretchr/testify with attic-labs/testify (#1637)
This removes the httptest flag in usage for every command.
2016-05-25 13:13:55 -07:00
Aaron Boodman
cff0de3696 non-vendor changes 2016-02-08 23:15:09 -08:00
Benjamin Kalman
071c89f77d Make runner.Serial ignore file not found errors. 2016-01-25 17:28:28 -08:00
Aaron Boodman
37fcdf8b2c runner: add support for custom env variables
This is needed to build attic ui.
2016-01-19 15:41:16 -08:00
Chris Masone
5c89d91b5d Add RunInDir()
Another helper function to run a command in a given directory,
but without panicing on failure.
2015-12-23 15:47:21 -08:00
Chris Masone
703ed765b2 Add ForceRunInDir()
This helper allows the caller to run a command in a given directory,
and panic on failure.
2015-12-21 15:45:24 -08:00
Chris Masone
a47edc8431 Tools cleanup
Add a python test, clean up some error messages, and trim
env vars that don't need to be passed to build/staging scripts.
2015-12-15 11:18:00 -08:00
Chris Masone
6e316d9975 Move build scripts to python
Finding and running build scripts remains in Go
(tools/run_all_build.go and supporting libs), but the build scripts
themselves are in python now.  This is because Go doesn't have much
support for copying files and directories around, which is kind of the
primary focus of build and packaging scripts.

Towards issue 677
2015-12-11 14:46:16 -08:00
Chris Masone
2a5747bd19 Preserve environment when running subprocesses.
Trying to whitelist needed env vars is just going to be a maintenance
headache, so don't do it.
2015-12-09 10:51:17 -08:00
Chris Masone
2fd0d57c16 Correctly add GOROOT to empty subprocess environments
The way I was forcing GOROOT wound up clearing the execution environment
of subprocesses when the caller intended to simply re-use the current
execution environment. This path correctly adds GOROOT in all cases.
2015-12-05 16:38:41 -08:00
Chris Masone
cd77f4ad37 Pass GOROOT in subprocess environment
Apparently, Travis runs a Go binary that was built with GOROOT=/usr/local/go,
but sets GOROOT to some other path in its execution environment. Tolerate this
by _always_ grabbing the current binary's GOROOT and setting it in the
execution environment used by subprocesses.
2015-12-04 11:23:15 -08:00
Chris Masone
86cc69faf2 Speculative fix for serial_test.go on Travis
This test already worked fine locally, but Travis seems to be different.
2015-12-04 10:59:05 -08:00
Chris Masone
426487a576 Fix up bad patch split
There's a subsequent patch I split out that I messed up with a bit.
2015-12-04 10:24:47 -08:00
Chris Masone
8180c41bf0 Build scripts/tools written in Go
This patch introduces tools/run_all_build.go, a tool that looks for
files called build.go in our source tree and executes them using
'go run'. Currently, they're run in serial.

Also, some node projects are tweaked to make it clear that 'go run build.go'
is the supported mechanism for installing deps and building code.
2015-12-04 10:18:23 -08:00