The ordering of the primary key columns in returned by Schema.GetAllCols() should not determine diffability.
If and only if the primary key tags, their relative ordering, and their types (in the new format) are equal, two schemas are diffable.
Schema.GetPkCols() always returns the columns in ordinal order.
Get rid of TupleRowStorage and use SerialMessage everywhere. In turn, change
SerialMessage so that it carries its kind and size prefix as part of itself.
* In __DOLT_1__, throw error if schemas have different primary key types
* [ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/update.sh
* schema integration test fix
* [ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/update.sh
* Compare SQL types
Co-authored-by: druvv <druvv@users.noreply.github.com>
* reimplement dolt_transaction_merge_stomp at merge layer
add idx
* [ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/update.sh
* fix tests
* remove stomp conflicts
* conflict reader must be reset each time PartitionRows is called
* reimplement dolt conflict resolve --theirs|--ours through sql path
Also drops manual conflict resolving through cli
* add cardinality columns to dolt_conflicts_table_name for keyless tables
* Adds keyless conflict deleting for new format
* dolt conflicts resolve sql impl for keyless tables
* [ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/update.sh
* delete cli.ParseKeyValues
* fix tests
* temporarily allow dolt_docs to be mutated from SQL path
Because conflicts resolve uses the SQL path, dolt_docs needs to be editable.
* fix untested code, comment out docs tests
* bats
* fix a couple found merge bugs
* [ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/update.sh
* if statements...
* add comments
Co-authored-by: druvv <druvv@users.noreply.github.com>
* add our_diff_type and their_diff_type to dolt_conflicts_table_name
* pr comments
* [ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/update.sh
Co-authored-by: druvv <druvv@users.noreply.github.com>
* persistable vars
* [no-release-notes] text and json types written as byte trees
* fmt
* more tests, fix other failing tests
* GMS bump
* fix remaining tests
* small fixes
* [ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/update.sh
* bats failures
* revert
* [ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/update.sh
* tidy
* update plans
* [ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/update.sh
* more plan changes
* delete todo
* better docstring
* zach comments
Co-authored-by: max-hoffman <max-hoffman@users.noreply.github.com>
* [no-release-notes] New format blob read/write
Use blob chunker to write blobs out of band. Tests for
round tripping and address walking at the tree level.
Run Blob enginetests and extra large file blob tests.
* NodeStore ref refactors
* fix index
* run verify
* fix more bats
* small PR cleanup
* more changes
* last bats errors
Daylon Wilkins