Commit Graph

25831 Commits

Author SHA1 Message Date
Aaron Son
7dadc7ceed go: remotestorage: PR feedback on ChunkCache. 2025-02-19 15:13:26 -08:00
Aaron Son
fc100694f6 Merge remote-tracking branch 'origin/main' into aaron/remotestorage-cache-cleanup 2025-02-14 13:33:45 -08:00
Aaron Son
4c93a25fbc Merge pull request #8863 from dolthub/reltuk-1e0e5e8f
[auto-bump] [no-release-notes] dependency by reltuk
2025-02-14 13:31:51 -08:00
Aaron Son
449318ac97 go: remotestorage: Fix data race in writebuffer_test.go. 2025-02-14 12:43:43 -08:00
reltuk
c9133db51f [ga-bump-dep] Bump dependency in Dolt by reltuk 2025-02-14 20:43:09 +00:00
Aaron Son
5d4d380f72 go: remotestorage: Make write buffer machinery more robust. Add some testing. 2025-02-14 12:32:59 -08:00
Aaron Son
9b267b47c5 go: remotestorage: writebuffer: Fix write buffer chunk caching on failed commits. 2025-02-14 11:22:34 -08:00
Aaron Son
bfa2739516 Merge remote-tracking branch 'origin/main' into aaron/remotestorage-cache-cleanup 2025-02-14 10:47:15 -08:00
Neil Macneale IV
eb91821ce1 Merge pull request #8857 from dolthub/macneale4/archive-clone-fetch
[no-release-notes] archive clone/fetch
2025-02-13 17:55:34 -08:00
Aaron Son
d4a62c13b7 Merge pull request #8848 from dolthub/aaron/async-push-hook-session-lifecycle
[no-release-notes] go: sqle: Change how we run background threads for replication hooks. Add session lifecycle callbacks for replication hooks.
2025-02-13 17:14:11 -08:00
Aaron Son
f662a63b1e Merge pull request #8858 from dolthub/aaron/gc-clear-caches
[no-release-notes] go: sqle: dolt_gc: Purge read caches associated with the DoltDB as we begin GC.
2025-02-13 17:12:50 -08:00
Neil Macneale IV
2cab73a144 Archive test updates to account for default dictionaries 2025-02-13 16:47:01 -08:00
Aaron Son
cd8372b9c8 go: prolly/tree: node_store.go: Doc comment on PurgeCaches. 2025-02-13 16:38:32 -08:00
Aaron Son
ced4653888 go: store: nbs: Improve goroutine cleanup on gc_copier, some robustness improvements on KillConnection safepoint controller. 2025-02-13 16:36:43 -08:00
Neil Macneale IV
b086492018 Account for empty chunks in archive.getManyCompressed 2025-02-13 16:05:48 -08:00
Neil Macneale IV
77a4e59fc2 More PR Feedback 2025-02-13 15:44:57 -08:00
Neil Macneale IV
2434b63eae PR Feedback 2025-02-13 15:39:06 -08:00
Neil Macneale IV
63e29a790d rollback the change to the getMany interface 2025-02-13 15:24:08 -08:00
Aaron Son
d459962770 Merge pull request #8851 from dolthub/aaron/valuestore-gc-states-unit-tests
[no-release-notes] go/store/types: value_store: Add some unit tests for gc states and gcAddChunk behavior.
2025-02-13 14:48:20 -08:00
Aaron Son
ea5615dae2 go: store/types: value_store_test.go: PR feedback, some comments. 2025-02-13 14:47:39 -08:00
Aaron Son
64cef607e3 Merge pull request #8854 from dolthub/aaron/statspro-session-lifecycle
[no-release-notes] go: statspro: Add session lifecycle callbacks to integrate with session-aware GC safepoint controller.
2025-02-13 14:40:07 -08:00
Aaron Son
5eea56b79d go: remotestorage: chunk_store.go: Clean up ChunkCache.
When DoltChunkStore was implemented, it needed to do write buffering in order
to read its own writes and to flush table files to the upstream. At some point,
read caching and caching of has many results was added onto the write buffer,
creating confusion and despair. This change separates back out the use cases.
2025-02-13 13:01:59 -08:00
Neil Macneale IV
ecac26bf2b Remove the FullCompressedChunkLen function from ToChunker interface 2025-02-13 12:23:47 -08:00
Neil Macneale IV
c76ab7e7d9 more cleanup 2025-02-13 10:55:01 -08:00
reltuk
caa1e47e8a [ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/update.sh 2025-02-13 18:32:20 +00:00
Aaron Son
c8353bb053 go: Fix some tests for new ValueStore cache purging behavior where we rely on a safepoint controller to do it. 2025-02-13 10:24:23 -08:00
Aaron Son
78d451b883 go: remotestorage: chunk_fetcher: Ranges carry the Dict{Offset,Len}, instead of a GetDict callback. 2025-02-13 09:53:42 -08:00
Aaron Son
52fab61a3d go: remotestorage: Some cleanups to ChunkFetcher. 2025-02-13 09:32:15 -08:00
Aaron Son
4a3d7f8177 go: remotestorage: Rework how dictionary fetching and dictionary cache is populated. 2025-02-12 18:34:20 -08:00
Zach Musgrave
21547c4027 Merge pull request #8847 from dolthub/zachmu/ignore
Added an extension point for doltgres to lookup values in the dolt_ignore table
2025-02-12 16:05:30 -08:00
macneale4
dbef286672 [ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/update.sh 2025-02-12 23:09:24 +00:00
Neil Macneale IV
72e7029580 More ToChunker refactor 2025-02-12 14:55:37 -08:00
reltuk
6561f452ac [ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/update.sh 2025-02-12 22:09:31 +00:00
Aaron Son
18d7ceb847 [no-release-notes] go: sqle: dolt_gc: Purge read caches associated with the DoltDB as we begin GC.
The right place to do this is in the safepoint controller, at BeginGC. We need
to do it after keeperFunc is installed on the NomsBlockStore, so that all read
dependencies are taken. We also need to do it before we register all sessions
whose cached state we need to visit.
2025-02-12 14:01:23 -08:00
macneale4
c3440f0d22 [ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/update.sh 2025-02-12 13:49:45 -08:00
Neil Macneale IV
57c6a21cb2 Small refactor and clean up 2025-02-12 13:49:45 -08:00
Neil Macneale IV
f8330ff852 Make metadata code aware of newgen archives 2025-02-12 13:47:43 -08:00
Neil Macneale IV
1f498f832c Use better dictionary cache 2025-02-12 13:47:43 -08:00
Neil Macneale IV
6c270b1d2c First steel thread for archive fetch. 2025-02-12 13:47:43 -08:00
macneale4
66f1b9f73c [ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/update.sh 2025-02-12 13:47:43 -08:00
Neil Macneale IV
8f933ce76a Clone tests passing again 2025-02-12 13:47:43 -08:00
Neil Macneale IV
564c1f1820 Checkpoint: url generation fixed, and no longer blocking incorrectly 2025-02-12 13:47:43 -08:00
Neil Macneale IV
5fbe0d1d87 Munge the location path in GetChunkLocationsWithPaths 2025-02-12 13:47:43 -08:00
Neil Macneale IV
0ae4d51b86 Revert tableSpec field changes 2025-02-12 13:47:43 -08:00
Neil Macneale IV
6c0a0396b6 Add test for cloning archived repository. 2025-02-12 13:47:43 -08:00
Neil Macneale IV
0e78d7b91f Use darc suffix const 2025-02-12 13:47:43 -08:00
Neil Macneale IV
d45e0427d2 First successful clone. No tests yet. 2025-02-12 13:47:43 -08:00
Neil Macneale IV
38f80df9e1 Generated Proto code 2025-02-12 13:18:00 -08:00
Neil Macneale IV
a73bfed8ba Simplest possible update to gRPC interface for archive spans 2025-02-12 13:18:00 -08:00
Aaron Son
349d1475cb go: statspro: Add session lifecycle callbacks to integrate with session-aware GC safepoint controller. 2025-02-11 16:29:19 -08:00