Commit Graph

54 Commits

Author SHA1 Message Date
Andy Arthur 7efba0e1a6 refactored 2019-11-14 12:41:32 -08:00
Andy Arthur 6fd64dfcfd rows of new tables are inserting, woof 2019-11-13 17:29:02 -08:00
Andy Arthur 36805ea6db removed dead code 2019-11-12 17:01:25 -08:00
Andy Arthur 5f7bcd7fda responding to PR comments 2019-11-12 16:28:36 -08:00
Andy Arthur 4dc34f1686 merging master and fixing conflicts 2019-11-11 10:12:33 -08:00
Andy Arthur eb05be2297 refactored branch 2019-11-11 09:02:26 -08:00
Andy Arthur 735fbee264 sql diffs working correcrtly now 2019-11-08 17:08:30 -08:00
Andy Arthur 97ea32eade cleanup 2019-11-07 15:46:43 -08:00
Andy Arthur c3ac9a0835 simple sql diff update working 2019-11-07 15:21:52 -08:00
Andy Arthur 7c8a354e63 diff sql insert working 2019-11-07 12:13:53 -08:00
Andy Arthur 2b353d6fc9 plummed tableName 2019-11-06 17:59:45 -08:00
Andy Arthur 4e8612b09d added sql flags and new sql sink to diff 2019-11-06 16:00:36 -08:00
Brian Hendriks 69398406e6 Bh/diff summary opt (#117)
* diff --summary optimizations (moved to use an AsyncDiffer)
* Fixed cell modification count calculations
* Added additional incremental output.
* Extra tests
2019-10-07 15:43:43 -07:00
Taylor Bantle 4da04bc843 Combine summary and diffSummaryValueChanged functions 2019-10-03 13:09:25 -07:00
Taylor Bantle 58ee619005 Move summary display functions to cmd, replace returning verr to using atomicerr, change type of values to map 2019-10-02 12:45:16 -07:00
Taylor Bantle 0b43e06e2e Diff summary includes cells modified 2019-10-01 17:16:19 -07:00
Taylor Bantle 93f07b64fc diff summary printing added, deleted, modified, unmodified 2019-09-27 15:46:26 -07:00
Brian Hendriks 55c2412db3 error changes (#7)
The existing noms codebase uses panics for signaling errors in most cases.  This is not idiomatic go, and it is not the optimal behavior when building cloud services, or products on top of noms as a panic in any go routine causes the entire process to exit.

This is a large step in removing panics, and bubbling errors up through the code.
2019-08-06 15:00:02 -07:00
Aaron Son 5fc6fd5d6a go: Update for dolt at root of repository. 2019-07-24 10:28:54 -07:00
Aaron Son 23a0f5a33e Merge remote-tracking branch 'origin/master' into aaron/dolt-3pdeps-license-fetching 2019-07-23 16:07:50 -07:00
Aaron Son e50cf78cdb Merge remote-tracking branch 'origin/master' into aaron/dolt-go-govet 2019-07-23 15:52:54 -07:00
Aaron Son 3ade997ec7 dolt/go: Fix all go vet errors. 2019-07-23 12:33:04 -07:00
Aaron Son 6619700b5a dolt/go: Add utils/repofmt/check_fmt.sh, and standardize goimports config across repository. 2019-07-23 11:59:06 -07:00
Aaron Son 732086a9c7 dolt/go: Add copyright notices to every file. For files from noms, retain and reference the previous copyright notice as well. 2019-07-22 17:06:35 -07:00
Aaron Son 15973f60c1 dolt/go: store/types: Rename Format to NomsBinFormat.
Standardize parameter name for *NomsBinFormat to nbf. Standardize `nbf` as
first (after `ctx`) parameter. Remove unnecessary `nbf` parameters when format
is available from incoming `Value` or `ValueReader`.
2019-07-16 13:27:26 -07:00
Aaron Son c0e1cb0458 dolt/go/libraries/doltcore/diff: AsyncDiffer.Start takes Maps, does not need *Format. 2019-07-12 10:23:45 -07:00
Aaron Son b5d78b4cdc dolt/go/libraries/doltcore/row: FromNoms uses format from the supplied tuples. 2019-07-12 10:23:45 -07:00
Aaron Son 30b85b3177 dolt/go/libraries/doltcore: Remove some Format_7_18 references. 2019-07-12 10:23:45 -07:00
Aaron Son 1f6241f7dc dolt/go/libraries/doltcore/row: Thread Format() through Row. 2019-07-12 10:23:45 -07:00
Aaron Son b27c57c6da dolt/go/cmd/dim: Clean up some Format_7_18 references. 2019-07-12 10:23:44 -07:00
Aaron Son ffd88adbba dolt/go/store: *Format goes away some places... 2019-07-12 10:23:44 -07:00
Aaron Son 9aec33361c dolt/go/libraries/doltcore/diff: Remove Format_7_18 references. 2019-07-12 10:19:45 -07:00
Aaron Son 79062329e6 dolt/go/store: diff: Remove Format_7_18 references. 2019-07-12 10:17:04 -07:00
Aaron Son 4af7c75639 dolt/go/store: types: Thread *Format in Type. 2019-07-12 10:14:22 -07:00
Brian Hendriks de36628918 update paths 2019-06-21 12:06:08 -07:00
Brian Hendriks 6ae6d7e595 move store files to the structure we want 2019-06-21 11:55:01 -07:00
Aaron Son feb2839099 dolt/go: diff/async_differ: Catch a panic in the go routine spawned from AsyncDiffer.Start(). 2019-06-13 11:09:49 -07:00
Zach Musgrave fc36a87728 Fixed unicode printing width problems by counting runes instead of bytes. Also fixed an unrelated bug in diff output, where 2 table header rows were always being printed regardless of whether there was a schema diff. 2019-05-21 12:38:28 -07:00
Zach Musgrave 0778507b21 Fixed output bug for git diff when there were schema diffs 2019-05-14 15:28:13 -07:00
Zach Musgrave 6be695936a Pretty colors for diffs. Changed columns are now colored independently from the rest of their line, with old values in red and new in green. Added and removed rows are bolded red and green. 2019-05-03 13:11:39 -07:00
Zach Musgrave a751500888 Made dolt diff use the tabular output format 2019-05-02 15:06:06 -07:00
Aaron Son dcedb2ee5c Merge remote-tracking branch 'origin/master' into aaron/dolthubapi-context-everywhere-and-always 2019-04-30 15:54:45 -07:00
Aaron Son e8071437fe libraries/doltcore/diff: Iterate on ctx. 2019-04-26 15:44:56 -07:00
Aaron Son 20126ba9cf go,dolt/go: Update for noms context propagation. 2019-04-26 14:34:06 -07:00
Brian Hendriks 4331380ddf PR feedback 2019-04-25 11:34:21 -07:00
Brian Hendriks 3bb2bf5f86 fix 2019-04-25 11:34:21 -07:00
Brian Hendriks 5775309e4a diff row changes 2019-04-25 11:34:21 -07:00
Brian Hendriks b3cd044fad new SchemaChangeType 2019-04-25 11:34:21 -07:00
Brian Hendriks 258b81a244 diff schemas 2019-04-25 11:34:21 -07:00
Zach Musgrave 1a85f131c4 Addressed review feedback and extracted a constant for the printed NULL value, used it everywhere. 2019-04-17 09:34:36 -07:00