Commit Graph

7907 Commits

Author SHA1 Message Date
Jason Fulghum 960f24df8a More debugging 2023-10-11 14:20:59 -07:00
Jason Fulghum 52932c5577 Debugging windows-specific erorr about chunk journal being closed multiple times 2023-10-11 12:32:35 -07:00
Jason Fulghum de41c42f0d Tidying up test runner func 2023-10-10 14:34:20 -07:00
Jason Fulghum d976b46b0d PR Feedback: normalizing physical directory names when moving them to the dropped dbs directory, so that they will always match the logical name of the database when they are restored. 2023-10-10 14:12:20 -07:00
Jason Fulghum 1f7cbe03ed Adding enginetests for dolt_undrop 2023-10-10 11:32:33 -07:00
Jason Fulghum 7bb886d9d5 PR feedback: changing the directory name for dropped databases to ".dolt_dropped_databases" so that it's a hidden directory 2023-10-09 16:31:32 -07:00
Jason Fulghum a47c4f8b7c PR feedback: removing some duplication around use of TryLock to assert that mutexes are locked and adding some extra comments. 2023-10-09 16:29:35 -07:00
Jason Fulghum 68a771bbca Tidying up 2023-10-05 16:05:42 -07:00
Jason Fulghum b25a6555d3 Fixes for inmemfs implementation of MoveDir 2023-10-05 14:09:11 -07:00
Jason Fulghum c953bda067 Tidying up 2023-10-05 14:01:21 -07:00
Jason Fulghum 905b55fd2e Tidying up 2023-10-04 15:19:52 -07:00
Jason Fulghum 8c2c30fca0 Merge branch 'fulghum/undrop' of https://github.com/dolthub/dolt into fulghum/undrop 2023-10-04 15:02:11 -07:00
Jason Fulghum 8d49d9c1fe Making dolt_purge_dropped_databases() require SUPER privileges 2023-10-04 15:01:59 -07:00
fulghum 3089faade0 [ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/update.sh 2023-10-04 19:37:23 +00:00
Jason Fulghum 34c59e1b14 Fix missing interface method impl for test 2023-10-04 12:26:47 -07:00
Jason Fulghum b21317a480 Merge branch 'main' into fulghum/undrop 2023-10-04 12:17:54 -07:00
Jason Fulghum 24764496f1 Adding support for new dolt_purge_dropped_databases stored procedure 2023-10-04 12:13:37 -07:00
James Cor 927ac2ccfa test for joining diff table function with alias (#6768) 2023-10-04 10:47:32 -07:00
Jason Fulghum 14a026601a Stubbing out the PurgeAllDroppedDatabases function 2023-10-04 10:30:47 -07:00
Jason Fulghum 0570288de0 Tidying up 2023-10-04 10:18:53 -07:00
Aaron Son e8e122b2d4 Merge pull request #6767 from dolthub/aaron/fix-cluster-drop-database-race
go: sqle: cluster: Improvements for DROP DATABASE replication.
2023-10-04 10:13:48 -07:00
Jason Fulghum 5f2c3c284d Switching to pointer receivers after picking up changes from main 2023-10-04 09:39:54 -07:00
Jason Fulghum d4f4945e16 Merge branch 'main' into fulghum/undrop 2023-10-04 09:31:27 -07:00
Jason Fulghum 947adf2bb0 Bug fix for case-insensitive file search helper function 2023-10-04 09:29:59 -07:00
Jason Fulghum 3fd6e5534c Adding helper methods for case-insensitive matching code and fixing a couple bugs 2023-10-03 17:03:55 -07:00
Jason Fulghum 109159f098 Renaming ListUndroppableDatabases -> ListDroppedDatabases 2023-10-03 17:03:09 -07:00
Aaron Son 7a7f26b70d [no-release-notes] go: sqle: DoltDatabaseProvider: Change it to a pointer receiver so updates to its state are much easier to reason about. 2023-10-03 16:05:36 -07:00
Jason Fulghum 93b044f233 Various small fixes 2023-10-03 15:58:00 -07:00
Aaron Son 9e66c4eae2 go: sqle: cluster: Improve how we handle sql.Context for replication api. 2023-10-03 15:47:17 -07:00
Aaron Son 7d412a14e8 go: sqle: cluster: Improvements for DROP DATABASE replication.
Fix a bug in session handling for the replication api endpoint which would
prevent a dropped database from being recreated on a replica.

Fix a race condition when a database is recreated after it is dropped. In that
case, we stop attempting to replicate the drop, so that it does not replicate
after the new database does.
2023-10-03 14:50:57 -07:00
Nick Tobey b27db84190 Merge pull request #6703 from dolthub/nicktobey/tuples
When a three-way merge contains an altered column, convert values to the new column type in order to prevent conflicts.
2023-10-03 14:49:09 -07:00
Jason Fulghum 1cb66beede Bug fixes for inmemfs MoveDir implementation 2023-10-03 14:11:44 -07:00
Jason Fulghum c813142a6d First pass at implementation and tests for MoveDir method in InMemFS 2023-10-03 13:20:58 -07:00
Nick Tobey 3f11c838dd Update documentation. 2023-10-03 11:50:47 -07:00
Nick Tobey 645c9e2835 Update callback method signature in tests. 2023-10-03 10:54:42 -07:00
fulghum e949388106 [ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/update.sh 2023-10-03 17:24:36 +00:00
Jason Fulghum 256b1ecb85 Pulling out drop/undrop code from provider into a new type to encapsulate it 2023-10-03 10:13:29 -07:00
Zach Musgrave 3ebdfb61c3 Fixed tests broken by add check type change 2023-10-03 09:28:43 -07:00
Jason Fulghum 7ac5799066 First pass on support for dolt_undrop() stored procedure to "undrop" a database after it has been dropped. 2023-10-02 18:32:53 -07:00
stephanie 5ea0e18d55 Merge pull request #6738 from dolthub/steph/push
migrate dolt push to use sql queries
2023-10-02 18:09:46 -07:00
Nick Tobey 6f93045954 Allow error propagation when merging cells in schema merges. 2023-10-02 16:07:44 -07:00
Aaron Son 0e44fffd56 pr feedback. 2023-10-02 15:39:10 -07:00
Aaron Son e4f8ff3b23 dolt backup: Fix dropped error on the final stage of updating the destination with the newly pushed backup. 2023-10-02 13:57:44 -07:00
Aaron Son aabb4b6dda Merge remote-tracking branch 'origin/main' into aaron/replicate-drop-database 2023-10-02 10:48:28 -07:00
Aaron Son 74cac7d43e Merge pull request #6752 from dolthub/aaron/fix-cluster-setRole-deadlock-in-perms-replication
go/libraries/doltcore/sqle/cluster: Fix a possible deadlock in permissions replication.
2023-10-02 10:47:51 -07:00
nicktobey dfeeed37f8 [ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/update.sh 2023-10-02 05:51:55 +00:00
Nick Tobey d47b6b3137 Add clarifying comment to processColumn 2023-10-01 22:35:58 -07:00
Nick Tobey 394956bb1f Implement Serialize in terms of PutField. 2023-10-01 22:35:35 -07:00
Stephanie You 942d9dfd31 up to date error returns 0 status code 2023-09-29 15:10:38 -07:00
Stephanie You cc11d1a53a migrate dolt push to use sql queries 2023-09-29 15:10:32 -07:00