Commit Graph

17271 Commits

Author SHA1 Message Date
Daylon Wilkins b010a2106d Added document explaining how branch control works 2023-02-01 02:13:29 -08:00
James Cor 4c3e3ac557 go mod 2023-01-31 23:40:08 -08:00
James Cor 359758b85b uncomment tests 2023-01-31 23:39:17 -08:00
James Cor d4032a572b maybe? 2023-01-31 23:38:23 -08:00
James Cor 26ef0a7fd7 compare secondary even if empty 2023-01-31 20:00:38 -08:00
Aaron Son a8bf4f6399 go/store/nbs: store.go: Ensure we clear nbs.mt when we see a dangling ref. 2023-01-31 18:43:06 -08:00
zachmu 3391a40422 [ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/update.sh 2023-02-01 02:14:07 +00:00
Zach Musgrave ff9e278b85 Reverting nil check 2023-01-31 17:32:57 -08:00
Zach Musgrave 454f2d596d Rename 2023-01-31 17:31:24 -08:00
Zach Musgrave c383aef862 Huge efficiency gain and logging for progress 2023-01-31 17:30:37 -08:00
Aaron Son 5253e3c85a go/store/nbs: store.go: Change memtable reference sanity check to happen at table_set.append() instead of trying to check novel chunk sources.
Removes enforce completeness functionality from ValueStore, which becomes
superfluous.
2023-01-31 17:02:58 -08:00
Aaron Son 9639786b13 Merge pull request #5267 from dolthub/aaron/sqle-dprocedures-disable-dolt_gc
go/libraries/doltcore/sqle/dprocedures: Do not register dolt_gc.
2023-01-31 16:21:49 -08:00
Aaron Son a8af02d350 Merge pull request #5268 from dolthub/aaron/nbs-memtable-getMany-getRecord-found
go/store/nbs: mem_table: getMany,getManyCompressed: Make certain to set getRecord.found = true.
2023-01-31 16:21:40 -08:00
Aaron Son 9488644cf3 go/store/types: ValueStore: Fix deadlocks for concurrent writes, bufferMu and NBSStore.
At times ValueStore calls into ChunkStore.PutChunk, for example, with bufferMu
held. With online-GC, that call can block until a GC process is finished. So a
calling goroutine would block with bufferMu held. However, in order for the GC
process to finish, ValueStore.GC needs to grab bufferMu in order to finalize
its bookkeeping state after ChunkStore GC is successful.

This change allows reads to proceed against ValueStore while it waits for GC to
complete by adding a condition variable which we toggle before we start GC and
broadcast on after we're done.
2023-01-31 16:17:25 -08:00
bheni e7bae47cc3 [ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/update.sh 2023-01-31 23:55:44 +00:00
reltuk e23e7ee84a [ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/update.sh 2023-01-31 23:51:44 +00:00
Brian Hendriks 56706c0826 add another layer of batching 2023-01-31 15:51:11 -08:00
Aaron Son ff63732b49 go/store/types: value_store.go: Change GC implementation to call TableFileStore.PruneTableFiles after the copy is complete. 2023-01-31 15:48:39 -08:00
Zach Musgrave 41ee59f90d Second pass, made arg optional 2023-01-31 15:16:34 -08:00
Aaron Son 73187a3ec6 go/store/nbs: store.go: Fix some lock ordering issues with GC and mm.LockByName. Change swapTables to not drop tables.novel or nbs.mt. 2023-01-31 15:13:00 -08:00
Aaron Son 754a84ca03 go/store/nbs: mem_table: getMany,getManyCompressed: Make certain to set getRecord.found = true.
This keeps NBSStore from returning the same chunk twice if it appears in both
memtable and a chunkSourceSet.
2023-01-31 14:42:22 -08:00
reltuk c690a702f2 [ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/update.sh 2023-01-31 22:41:48 +00:00
Aaron Son de9892237e go/libraries/doltcore/sqle/dprocedures: Do not register dolt_gc. 2023-01-31 14:23:40 -08:00
Zach Musgrave 9c5af6c12c First draft at a walk command 2023-01-31 14:07:03 -08:00
AndyA ef53a45421 Merge pull request #5266 from dolthub/andy/gc-integration-test
[no-release-notes] GC integration test
2023-01-31 14:06:46 -08:00
andy-wm-arthur 6f63d326f9 [ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/update.sh 2023-01-31 21:33:52 +00:00
Andy Arthur e769ac8020 go/libraries/doltdb: converted aaron's repro to unittest 2023-01-31 12:39:04 -08:00
Andy Arthur 90d6cc838c go/libraries/doltcore: outline concurrent gc tests 2023-01-31 11:48:32 -08:00
max-hoffman bb1d211819 [ga-bump-release] Update Dolt version to 0.52.16 and release v0.52.16 v0.52.16 2023-01-31 14:41:10 +00:00
Maximilian Hoffman e0ce194973 [no-release-notes] gms bump merge join (#5263) 2023-01-31 06:39:38 -08:00
max-hoffman 1be0dadecf [ga-bump-release] Update Dolt version to 0.52.15 and release v0.52.15 v0.52.15 2023-01-31 05:02:18 +00:00
jennifersp 77a0bb6d68 add bats test for release all locks on session end (#5257) 2023-01-30 19:43:21 -08:00
Dustin Brown 7b9310e208 [ga-bump-dep] Bump dependency in Dolt by max-hoffman (#5261)
Co-authored-by: max-hoffman <maximilian.wolfgang1@gmail.com>
2023-01-30 19:38:44 -08:00
Daylon Wilkins ff157e29bc Merge pull request #5238 from dolthub/daylon/tree-branch-control
Rewrote dolt_branch_control to use tree searching
2023-01-30 18:21:32 -08:00
Aaron Son 45efc05746 Merge pull request #5256 from dolthub/aaron/blobstore-gcs-get-one-round-trip
go/store/blobstore: gcs.go: Make Get() make one round trip instead of reading the metadata in a separate request.
2023-01-30 15:58:18 -08:00
Max Hoffman 9684edf397 delete old struct 2023-01-30 15:57:06 -08:00
Max Hoffman 6e40d2ddf7 exclude keyless tables from merge optimization 2023-01-30 15:51:22 -08:00
Zach Musgrave 1958e5f1cc Nil panic fix: 2023-01-30 15:02:40 -08:00
Aaron Son dc064b0d83 go/store/blobstore: gcs.go: Make Get() make one round trip instead of reading the metadata in a separate request. 2023-01-30 14:49:58 -08:00
jennifersp e956ba9516 add dolt_cherry_pick procedure (#5233) 2023-01-30 10:46:28 -08:00
Daylon Wilkins 17d08737d1 PR feedback 2023-01-30 05:45:32 -08:00
Daylon Wilkins 5c45b06382 Merge branch 'daylon/tree-branch-control' of https://github.com/dolthub/dolt into daylon/tree-branch-control 2023-01-30 03:26:10 -08:00
max-hoffman 699174a286 [ga-bump-release] Update Dolt version to 0.52.14 and release v0.52.14 v0.52.14 2023-01-30 05:32:51 +00:00
Max Hoffman 4746d825aa fix test 2023-01-28 22:28:37 -08:00
Max Hoffman e2fa0bf30d starter 2023-01-28 20:18:29 -08:00
Arnie97 8dc1d82580 Fix int overflow on 32-bit architectures 2023-01-28 19:58:03 +08:00
Daylon Wilkins b0b0e2c4b8 Branch control tables now use a map for divergences 2023-01-28 03:09:36 -08:00
jennifersp abbca2f460 Merge pull request #5250 from dolthub/jennifersp-a7e02bab
[auto-bump] [no-release-notes] dependency by jennifersp
2023-01-27 18:09:13 -08:00
AndyA acf0f056b0 Merge pull request #5244 from dolthub/andy/gcs-blobstore-push-parts
go/store/nbs: upload table parts on push for GCS backed NBS
2023-01-27 16:51:57 -08:00
jennifersp 53228b39f7 [ga-bump-dep] Bump dependency in Dolt by jennifersp 2023-01-28 00:46:47 +00:00