Commit Graph

2066 Commits

Author SHA1 Message Date
Maximilian Hoffman
b86b2b2011 Fix point lookup bug w/ prefix matching secondary (#5670)
* Fix point lookup bug w/ prefix matching secondary

* docstring
2023-04-03 11:39:44 -07:00
AndyA
9a604d1b6d Merge pull request #5635 from dolthub/andy/swiss-map
go/store/nbs: replace builtin golang map with swiss.Map
2023-03-31 14:48:12 -07:00
Andy Arthur
bd4f3585e9 go/store/nbs: pr feedback on rangeIndex lifecycle 2023-03-31 11:44:37 -07:00
Andy Arthur
e6a9b20c33 go/store/nbs: safeguard chunkJournal tablePersister methods for read-only journals 2023-03-31 10:22:45 -07:00
Andy Arthur
51ffc2d54e go/store/nbs: use 16byte addr prefixes to save space in chunk journal index 2023-03-30 16:05:47 -07:00
Andy Arthur
2f1f02286d Merge remote-tracking branch 'origin/main' into andy/swiss-map 2023-03-30 15:42:25 -07:00
Andy Arthur
6f25f7370b Merge remote-tracking branch 'origin/main' into andy/locking-journal-manifest 2023-03-30 12:24:57 -07:00
Aaron Son
4998109a96 Merge remote-tracking branch 'origin/main' into aaron/nbs-table-file-finalizer-panic-always-on 2023-03-29 10:13:27 -07:00
Zach Musgrave
84da4b789a Merge pull request #5621 from dolthub/zachmu/commit-concurrency
Correctly handle merging of staged changes across concurrent sessions
2023-03-28 10:36:48 -07:00
Andy Arthur
c6ec539768 go/store/nbs: replace builtin golang map with swiss.Map 2023-03-28 10:20:48 -07:00
Andy Arthur
b288911fb7 go/store/nbs: refactor journal close method 2023-03-27 11:37:36 -07:00
Andy Arthur
41b5a7a613 go/store/nbs: pr feedback 2023-03-27 11:15:38 -07:00
Andy Arthur
21d8bc23ce Merge remote-tracking branch 'origin/main' into andy/locking-journal-manifest 2023-03-27 09:21:41 -07:00
Aaron Son
f7a9172e9b go/store/nbs: journal.go: Pass along UpdateGCGen calls for updating the manifest when the chunk journal is not bootstraped. 2023-03-24 09:49:01 -07:00
zachmu
6698da1996 [ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/update.sh 2023-03-23 21:03:05 +00:00
Andy Arthur
26528a26ce go/store/nbs: close file manifest after parsing 2023-03-22 16:37:22 -07:00
Andy Arthur
e3a24df37d go/store/nbs: release manifest file lock before exiting process 2023-03-22 16:03:47 -07:00
Andy Arthur
41c6ab1938 go/store/nbs: added readOnly guard to journal manifest, updated integration tests 2023-03-22 14:51:12 -07:00
Andy Arthur
e295af8b0c Merge remote-tracking branch 'origin/main' into andy/locking-journal-manifest 2023-03-22 12:05:21 -07:00
Jason Fulghum
e388d43f7c Update go/store/datas/fun_commit_hash.go 2023-03-22 09:15:14 -07:00
Solipsis
81b6643c7c Merge branch 'main' of https://github.com/dolthub/dolt into fun_commits 2023-03-21 23:11:47 -07:00
Solipsis
12eaab749d Only computer regex for "fun" hashes once.
And only if it's needed.
2023-03-21 23:10:21 -07:00
Andy Arthur
9081917b24 go/store/nbs: added sentinel error for read-only manifest, fixed true-up 2023-03-21 17:06:41 -07:00
Zach Musgrave
24625ae9bf Made noms commands work with chunk journal 2023-03-21 13:18:10 -07:00
Solipsis
021e15fdec Add comments. 2023-03-21 12:07:52 -07:00
Andy Arthur
34ceddca1e Merge remote-tracking branch 'origin/main' into andy/locking-journal-manifest 2023-03-21 11:02:02 -07:00
Solipsis
db7d3a2687 Fix typos in dolt init --fun implementation 2023-03-20 18:29:12 -07:00
Solipsis
abe39d5b35 Detect repeated calls to simpleCommitMetaGenerator.Next
This shouldn't be possible, the check is a precaution to prevent infinite loops.
2023-03-20 17:26:11 -07:00
Solipsis
48d22d054a Move CommitMetaGenerator to datas package. 2023-03-20 17:21:55 -07:00
reltuk
76cc243795 [ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/update.sh 2023-03-20 23:42:02 +00:00
Aaron Son
d024ea8ea6 go/store/nbs: store.go: Conjoin if we need to when we add new table files to a manifest.
This allows us to avoid huge manifests with lots of table files when we run
multiple full GCs over a period of time.
2023-03-20 16:39:52 -07:00
Aaron Son
df1f87fadf Merge pull request #5600 from dolthub/aaron/enable-dolt_gc-procedure
sql: dolt_gc: Enable the dolt_gc stored procedure. Make dolt_gc safe to use.
2023-03-20 12:58:11 -07:00
Andy Arthur
e8c1986e6d go/store/nbs: add dedicated journalManifest that hold the file lock from startup time 2023-03-20 10:23:32 -07:00
Aaron Son
b442af83f2 go/store/nbs: store.go: Ensure we keeperFunc on chunkExists result into the memtable as well. 2023-03-17 19:19:10 -07:00
Aaron Son
774c100678 go/store/types: gc: Establish safepoint after we are finalizing but before we swap tables. 2023-03-17 15:40:01 -07:00
Andy Arthur
8ee9d04f76 Revert "go/store/nbs: cleanup old manifest migration"
This reverts commit 2a4bcb2bdd.
2023-03-17 14:31:29 -07:00
Andy Arthur
2a4bcb2bdd go/store/nbs: cleanup old manifest migration 2023-03-17 12:30:29 -07:00
Aaron Son
cf4b81217a dolt_gc support: Make waitForGC unblock with error on context canceled. Use more agressive retry-with-backoff policy on awaiting process quiesence in dolt_gc. 2023-03-17 11:48:18 -07:00
AndyA
a9b8cd3727 Merge pull request #5593 from dolthub/andy/fix-journal-lock-hash-on-bootstrap
go/store/nbs: compute fresh lock hash during manifest true-up on chun…
2023-03-17 11:27:00 -07:00
Andy Arthur
01a9c13521 go/store/nbs: compute fresh lock hash during manifest true-up on chunk journal bootstrap 2023-03-15 17:49:55 -07:00
Solipsis
b8730abec1 Move comment so documentation generates correctly. 2023-03-15 15:44:55 -07:00
Aaron Son
34717a04e2 Merge branch 'aaron/gc-inprogress-writes' into aaron/gc-safepoint-teardown-connections 2023-03-15 12:53:33 -07:00
Aaron Son
78d9499270 Merge remote-tracking branch 'origin/main' into aaron/gc-inprogress-writes 2023-03-15 12:50:14 -07:00
Aaron Son
652afbb334 go/store/types: ValueStore: Call safepoint before we start newgen gc, while writes are not blocked. 2023-03-15 10:30:31 -07:00
AndyA
6be00f0532 Merge pull request #5565 from dolthub/andy/chunk-journal-gc-lifecycle
go/store/nbs: teardown chunk journal in swap tables during GC
2023-03-14 15:29:03 -07:00
Solipsis
e94200a523 Merge branch 'main' of https://github.com/dolthub/dolt into fun_commits 2023-03-14 15:19:34 -07:00
Aaron Son
337bcd7138 go/store/types: ValueStore: Establish a safepoint at the end of the GC cycle, before finalizing GC. 2023-03-14 14:42:57 -07:00
Aaron Son
93743a4df3 Merge remote-tracking branch 'origin/main' into aaron/gc-inprogress-writes 2023-03-14 14:42:49 -07:00
Maximilian Hoffman
af987d213c Three way differ and merge optimizations (#5464)
* add three way differ for merge optimizations

* [ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/update.sh

* docstrings

* prog

* [ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/update.sh

* fix tests

* format

* more test fixes

* rewrite chunk of table merge, still need to rewrite unique lookup checking

* [ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/update.sh

* more test fixes

* [ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/update.sh

* test

* [ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/update.sh

* fix tests

* batching test

* larger buffer for secondary mutableMap

* [ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/update.sh

* refactor, fix buffer sizing

* fix more tests

* [ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/update.sh

* restore proto

* sort unique checks by secondary

* [ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/update.sh

* fix keyless pk len

* fmt

* revert edits

* merge conflicts

* merge conflict

---------

Co-authored-by: max-hoffman <max-hoffman@users.noreply.github.com>
2023-03-14 14:37:11 -07:00
Andy Arthur
e542e199f6 go/store/nbs: tweak chunk journal IO parameters 2023-03-14 10:30:19 -07:00