Commit Graph

11023 Commits

Author SHA1 Message Date
James Cor ccdf2cddff use main 2023-02-20 10:08:12 -08:00
James Cor 3ebc08c4cf merge with main 2023-02-20 10:01:38 -08:00
stephanie ea98ddaa5c Merge pull request #5380 from dolthub/steph/dolt-5226
`dolt_diff` respects qualified database
2023-02-20 09:37:55 -08:00
Aaron Son ec1bcab2f9 go/store/nbs: aws_table_persister.go: Fix conjoin code to not error on a single short Read() by using io.ReadFull.
In #5307 we started returning a real io.Reader for chunkSource.reader(ctx).
That means the Read() calls can come back short if they are directly attached
to a net.TCPConn, for example. It is not an error for a Read() to come back
short. Use io.ReadFull to correctly express the intent in the conjoin code for
AWS remotes.

Fixes a bug where doltremoteapi fails commits sometimes.
2023-02-17 16:40:20 -08:00
Stephanie You c796767300 edit param order on UnscopedDiffTable 2023-02-17 16:31:04 -08:00
Aaron Son 6880634515 Merge pull request #5382 from dolthub/reltuk-09205e0f
[auto-bump] [no-release-notes] dependency by reltuk
2023-02-17 16:25:03 -08:00
AndyA c1208e0d07 Merge pull request #5378 from dolthub/andy/journal-reader-writer
[no-release-notes] go/store/nbs: refactor `journalWriter` to manage chunk record hashmap
2023-02-17 15:58:58 -08:00
James Cor 3aecae85e9 go bump 2023-02-17 15:05:31 -08:00
James Cor 7f270a50db fixes to prepareds, ran into to_column issue 2023-02-17 15:04:33 -08:00
reltuk ec9d0c8516 [ga-bump-dep] Bump dependency in Dolt by reltuk 2023-02-17 22:56:57 +00:00
James Cor 8b104c5342 unscoped diff table prepared fixes 2023-02-17 14:49:44 -08:00
Stephanie You 3d4c0e3b82 dolt_diff respects qualified database 2023-02-17 13:59:06 -08:00
Andy Arthur a2b7ce923c go/store/nbs: cleanup, rename methods of journalWriter 2023-02-17 13:01:01 -08:00
Zach Musgrave 71e18afe0a Merge pull request #5346 from dolthub/zachmu/schema-safety
Block `schema import` when table has rows
2023-02-17 12:14:45 -08:00
Andy Arthur 4036810654 go/store/nbs: flush journal writer before returning record ranges 2023-02-17 11:32:38 -08:00
Andy Arthur 2ddf1fd9f5 go/store/nbs: move chunk index hashmap into journal writer 2023-02-17 09:45:42 -08:00
Maximilian Hoffman 9be1e16de9 ArtifactEditor now resets after flushing (#5367)
ArtifactEditor held on to keys after flushing because it was
a value receiver. Before the flush threshold, constraint violations
only flush once, so we don't notice this bug. For >50k constraint
violations, every incremental CV will write the previous duplicate 40k
CV's.
2023-02-17 09:30:35 -08:00
Aaron Son c455099b07 Merge pull request #5374 from dolthub/aaron/nbs-quota-testing
go/store/nbs: Fix some quota leaks in conjoin, GC.
2023-02-16 18:52:53 -08:00
James Cor 77a29f87de skip old format 2023-02-16 17:00:32 -08:00
Andy Arthur 4b3c909bb1 go/store/nbs: refactor chunk journal record lookups into journalWriter 2023-02-16 16:40:54 -08:00
Aaron Son 7406c4658a go/store/nbs: Fix some quota leaks in conjoin, GC.
Adds a paranoid mode where we noisely detect unclosed table files. The mode can
be enabled by setting an environment variable.

Fixes some unit tests, including all of go/store/... to run cleanly under the
paranoid mode.

Changes the quota interface to:
* Release |sz int| bytes instead of requiring a []byte with the correct length
  to show up.
* Work with |int| instead of |uint64|, since MaxUint64 is never allocatable and
  MaxInt32+z is only allocatable on 64-bit platforms.
* Not return an error on Release(). Implementations should not fail to release
  quota.
2023-02-16 16:01:20 -08:00
AndyA 1e3c0533fd Merge pull request #5373 from dolthub/andy/journal-renames
go/store/nbs: rename chunks journal constants in preparation for jour…
2023-02-16 15:33:43 -08:00
James Cor 0c4e205ecf cleaning up 2023-02-16 15:21:18 -08:00
James Cor ac8558d42a decrementing skip prepareds count 2023-02-16 15:07:29 -08:00
James Cor f5f254bcb9 bump 2023-02-16 15:00:39 -08:00
James Cor 2bb6ca0723 adding tests 2023-02-16 14:58:08 -08:00
Zach Musgrave b81126f596 Merge pull request #5368 from dolthub/zachmu/drop-add-views
Make dropping and adding the same view produce no diff
2023-02-16 14:54:02 -08:00
JCOR11599 2ced0f775f [ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/update.sh 2023-02-16 22:10:18 +00:00
James Cor dee84ffeac fixing z ordering tests 2023-02-16 14:08:41 -08:00
James Cor 72f02442a1 bump 2023-02-16 13:37:48 -08:00
James Cor aa582ebd55 Merge branch 'main' into james/spatial-index-test 2023-02-16 13:35:05 -08:00
James Cor 0c92fea148 go bump 2023-02-16 13:31:55 -08:00
James Cor a99ef68375 omitempty 2023-02-16 13:29:13 -08:00
Andy Arthur 2513f49e2c go/store/nbs: write code that compiles 2023-02-16 13:01:28 -08:00
Daylon Wilkins b9da4ea3e9 Merge pull request #5365 from dolthub/daylon/multiline-tabular-diff
Handle multiple lines in tabular diffs
2023-02-16 12:51:36 -08:00
Andy Arthur 5a662bd8b1 go/store/nbs: rename chunks journal constants in preparation for journal index 2023-02-16 12:49:40 -08:00
James Cor ec4203af78 Merge pull request #5327 from dolthub/james/show-fk-diff
print something for FK diffs
2023-02-16 12:46:52 -08:00
James Cor 3fff17a2eb adding tests to dolt 2023-02-16 12:46:41 -08:00
James Cor 608d2bfda5 oopsies 2023-02-16 12:45:20 -08:00
Zach Musgrave cdc3baadfa More annoying json formatting fixes 2023-02-16 12:33:56 -08:00
Zach Musgrave 0cf3a7b5d3 Merge branch 'zachmu/drop-add-views' of github.com:dolthub/dolt into zachmu/drop-add-views 2023-02-16 12:21:12 -08:00
Zach Musgrave 493c674e6c Another test fix 2023-02-16 12:21:09 -08:00
James Cor 22cdf09116 Merge branch 'main' into james/spatial-index-test 2023-02-16 11:52:15 -08:00
zachmu ca469929a7 [ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/update.sh 2023-02-16 19:51:30 +00:00
Zach Musgrave d9acefa0ee Fix test for older dolt format 2023-02-16 11:50:06 -08:00
Zach Musgrave b7353c7b68 PR feedback 2023-02-16 11:35:59 -08:00
Dustin Brown da034ccbb5 [ga-bump-dep] Bump dependency in Dolt by max-hoffman (#5363)
Co-authored-by: max-hoffman <maximilian.wolfgang1@gmail.com>
Co-authored-by: Max Hoffman <max@dolthub.com>
2023-02-15 19:10:11 -08:00
zachmu de049c87f3 [ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/update.sh 2023-02-16 02:04:19 +00:00
Zach Musgrave 69286e50ac Rewrote test to not compare json docs, which is failing in CI for some reason 2023-02-15 18:02:55 -08:00
zachmu 695666b60a [ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/update.sh 2023-02-16 01:41:11 +00:00