Commit Graph

322 Commits

Author SHA1 Message Date
Aaron Boodman 69a86f3036 Rewrite walk() to walk value tree instead of chunks
Also fix quad_tree to take advantage of that to be generic again.

Fixes #445, #497
2015-11-05 16:12:02 -08:00
Chris Masone c40b57fc41 Generated code 2015-11-05 15:15:07 -08:00
Erik Arvidsson 329e13e0ae Generated code 2015-11-05 16:33:25 -05:00
Chris Masone 5bda67180d Run go generate ./... at top level to pick up codegen changes from rebase 2015-11-05 12:15:23 -08:00
Chris Masone 2e68c39b14 Fix xml_importer and pitchmap/index to correctly use typed containers.
Fixes #554
2015-11-05 12:08:22 -08:00
Erik Arvidsson 2fcd3ce3af Merge pull request #575 from arv/register-ref
Clean up registration of Ref values
2015-11-05 14:51:37 -05:00
Erik Arvidsson 460841e3ed Clean up registration of Ref values
Ref values use the TargetRef to get the internal implementation

RegisterFromValFunction and ToNomsValueFromTypeRef were only used by
ref values at this point so these were renamed and simplified to be
more specific for ref values
2015-11-05 14:32:45 -05:00
Aaron Boodman f0a83992e3 Merge pull request #570 from aboodman/quadtree
Get quadtree client working with newbindings
2015-11-05 11:29:15 -08:00
Chris Masone 7b55efa9b6 Generated Code 2015-11-05 08:42:22 -08:00
Aaron Boodman 6f77a9d14e quad_tree: Call WriteValue() with SQuadTree, not *SQuadTree
This is a temporary fix for issue #566.
2015-11-04 20:22:36 -08:00
Aaron Boodman 980770965e quad_tree: add usage 2015-11-04 20:22:36 -08:00
Aaron Boodman 8d0e850880 sfcrime_importer: add usage 2015-11-04 20:22:32 -08:00
Erik Arvidsson 8c98964fee Generated code 2015-11-04 18:57:27 -05:00
Aaron Boodman ed64ce9af2 Merge pull request #557 from aboodman/build
Improve Splore build experience
2015-11-04 13:10:27 -08:00
Aaron Boodman 8f77860805 Improve Splore build experience 2015-11-04 13:10:10 -08:00
Rafael Weinstein ba6072e664 Merge pull request #559 from rafael-atticlabs/testSplore
Run tests in clients/splore
2015-11-04 13:00:44 -08:00
Erik Arvidsson 07414d0a9e Remove InternalImplementation from structs
By adding a reader to structs we can remove the function that exposes
the internal implementation details of a struct.
2015-11-04 14:57:52 -05:00
Rafael Weinstein d314df9d3e Run tests in clients/splore 2015-11-04 11:11:06 -08:00
Erik Arvidsson 756b893e8f Remove FromVal functions
The generated objects are all type.Values now so FromVal is not needed
2015-11-04 12:13:55 -05:00
Erik Arvidsson 9aadd85004 Add types.Struct and improve typed structs
The generated code for typed structs now uses a Go struct which
implements Value directly. The fields in this struct uses the "user"
type. (The union value still uses types.Value though.)

When a typed struct is created by the decoder, it asks for a struct
builder which returns a channel that the values of the fields of the
struct are sent to.
2015-11-04 11:55:07 -05:00
Erik Arvidsson eeaac87d5f Make Chunks return all reachable Refs from the current Value
We now do a recursive call which bottoms out with a ref.Ref for RefKind
Values. This means that we traverse into nested structures consistently.

The effect of this is that we get all the refs that the current chunk
references.
2015-11-03 17:13:20 -05:00
Erik Arvidsson 8f7416b4e6 splore: Align versions of browserify and watchify
This is so that they "use" the same version
2015-11-03 17:01:32 -05:00
Dan Willhite fd7a8973ce Migrate to use nomsdl codegen.
Use shared RemotePhoto object that flick examples uses. Add GeoPos information.
2015-11-02 17:06:13 -08:00
Rafael Weinstein 8330394fcd splore now uses js2 2015-11-02 14:23:53 -08:00
Aaron Boodman c5b8de8174 Collapse list.go and list_leaf.go since we only have one impl. 2015-11-02 13:20:38 -08:00
Erik Arvidsson 62fad2d615 Merge pull request #536 from arv/equals-by-ref
Make Equals compare by Ref (after comparing TypeRef)
2015-10-30 18:35:08 -04:00
Aaron Boodman 894e615696 Merge pull request #535 from aboodman/blob-future
Convert NewBlob() away from using resolvedFutures
2015-10-30 15:05:09 -07:00
Erik Arvidsson 30cc7d518f Make Equals compare by Ref (after comparing TypeRef)
This changes equal to compare by ref. Since computing the ref can be
expensive we first check that the type refs are equal.

Fixes #532
2015-10-30 16:50:49 -04:00
Aaron Boodman c52bf0bbf5 Convert NewBlob() away from using resolvedFutures
Instead, use a backing MemoryStore. This is part of removing Futures.
2015-10-30 12:50:56 -07:00
Dan Willhite 80be862fda Regroup common code. 2015-10-30 10:36:34 -07:00
Dan Willhite 42bac09422 Make sfcrime/quad_tree apps work with new nomsdl types.
Change generated files to <base>.noms.go
2015-10-30 10:23:15 -07:00
Aaron Boodman a9bc416a2f Change Chunks() to return []ref.Ref 2015-10-30 09:24:58 -07:00
Erik Arvidsson c98b3af833 Add test to tagdex 2015-10-29 12:41:40 -04:00
Erik Arvidsson 35a30eeae7 NomDL: Update tagdex
This changes clients/tagdex to use nomdl

To make this work we crippled it a bit and it no longer takes a dataset
ID but a ref to a `Set(Ref(RemotePhoto))`
2015-10-29 10:49:41 -04:00
Aaron Boodman 1939602844 Merge pull request #510 from aboodman/shove-test
shove: Add a unit test
2015-10-28 18:15:15 -07:00
Aaron Boodman 12c63649f2 shove: Add a unit test 2015-10-28 18:03:59 -07:00
Rafael Weinstein 0e0be1c59b Remove trailing newline from json encoding in typed serialization 2015-10-28 17:07:34 -07:00
Aaron Boodman 7d325acb2f Merge pull request #505 from aboodman/csv_reland
Add tests to csv_importer
2015-10-28 14:34:15 -07:00
Dan Willhite 84b99fbc37 Check in generated files with new names and delete old ones. 2015-10-28 14:28:20 -07:00
Aaron Boodman e55558bfa3 Revert "Revert "csv_importer: add unit tests""
This reverts commit 6245bbcde0.
2015-10-28 14:09:35 -07:00
Aaron Boodman ab66e113dd csv_importer: missing wg.Add() 2015-10-28 14:08:49 -07:00
Aaron Boodman 6245bbcde0 Revert "csv_importer: add unit tests" 2015-10-28 11:41:15 -07:00
Aaron Boodman aec21e3a49 csv_importer: add unit test 2015-10-28 09:52:32 -07:00
Aaron Boodman f4819debf0 counter: factor the client test util better 2015-10-27 22:31:32 -07:00
Aaron Boodman 2e106bd508 csv_importer: Import from file, not URL 2015-10-27 21:44:38 -07:00
Aaron Boodman a4be5d386f Merge pull request #493 from aboodman/counter-test
counter: add a unit test
2015-10-27 17:51:07 -07:00
Aaron Boodman 9cf0f8b2c5 counter: add a unit test 2015-10-27 17:42:23 -07:00
Erik Arvidsson 81f80d5ce6 NomDL: Encode compound blobs as structs
Before encoding a compoundBlob we create a compoundBlobStruct and
encode that instead.

After decoding we check if the value is a compoundBlobStruct and if so
we convert it to a compoundBlob.

Fixes #455, #165
2015-10-27 17:53:16 -04:00
Aaron Boodman 482e00f196 fix the build 2015-10-26 13:46:44 -07:00
Aaron Boodman 9343a385e1 break the build further 2015-10-26 13:43:05 -07:00