Maximilian Hoffman
e0b2d36878
[no-release-notes]Stats bump ( #6997 )
...
* Get index statistics enginetests working w/ Dolt
* gms bump
* fix stats collecting, bump
* fix test build
2023-11-13 08:46:05 -08:00
Zach Musgrave
b903f78428
Merge pull request #6974 from dolthub/zachmu/virtual-merge
...
Support merging schemas with virtual / generated columns
2023-11-10 21:56:46 -08:00
zachmu
27d4c05be5
[ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/update.sh
2023-11-11 00:32:49 +00:00
Zach Musgrave
d26755805e
Always use a new sql context when parsing schemas
2023-11-10 16:22:20 -08:00
Zach Musgrave
64ea7fe269
PR feedback
2023-11-10 15:54:03 -08:00
Zach Musgrave
83542cc84d
Fixed fast forward flag in test results
2023-11-10 15:23:46 -08:00
Zach Musgrave
3122380244
Used sql.Context in more places it made sense
2023-11-10 15:06:59 -08:00
Zach Musgrave
d7af14c4a3
Better assertions for merge calls
2023-11-10 14:56:35 -08:00
Aaron Son
038343ac96
go/libraries/doltcore/remotesrv: For the grpcSrv.Stop() call in the port multiplexed case, add a wait group and explicitly wait for requests to be finished for now.
...
The functionality where all request handler threads are cleaned up when Stop()
returns is not in the released version of grpc-go yet.
2023-11-10 14:27:17 -08:00
Aaron Son
5deea65347
go: sqle: cluster: commithook: When shutting down the server, the cluster replication commithook could deadlock after the replication thread missed a wakeup signal.
...
Fix it so that the wakeup thread is guaranteed to see the canceled context or
the wakeup signal.
2023-11-10 12:00:05 -08:00
Aaron Son
0fda70e4ea
Merge pull request #6993 from dolthub/aaron/atomic-write-utility
...
[no-release-notes] go/libraries/utils/file: Small refactor so attempts to do atomic file writes use a common helper method.
2023-11-10 11:18:53 -08:00
Aaron Son
faa0f91ba2
Fix for regression in relative base dir functionality of go/libraries/utils/filesys/localfs.go
2023-11-10 09:35:17 -08:00
Aaron Son
1dc224e325
[no-release-notes] go/libraries/utils/file: Small refactor so attempts to do atomic file writes use a common helper method.
2023-11-10 08:07:00 -08:00
Aaron Son
4decabd766
Merge remote-tracking branch 'origin/main' into aaron/sql-server-cluster-cleanup
2023-11-10 07:52:33 -08:00
Aaron Son
ce15b1f51e
PR feedback for remotesrv gRPC shutdown improvement.
2023-11-10 06:35:29 -08:00
Zach Musgrave
abb3b9ffc3
Merge upstream
2023-11-09 17:09:12 -08:00
Zach Musgrave
c52141602e
Bug fix for sql contexts with no current db. Also cleaned up a bit of useless code
2023-11-09 17:08:23 -08:00
zachmu
166553a87b
[ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/update.sh
2023-11-10 01:02:55 +00:00
Zach Musgrave
ace740508f
Cleared up import cycle in test
2023-11-09 16:53:00 -08:00
Zach Musgrave
5c00056f61
Changes from merging main
2023-11-09 16:39:50 -08:00
Zach Musgrave
bfc39481b2
Merge branch 'main' into zachmu/virtual-merge
2023-11-09 16:19:27 -08:00
Zach Musgrave
5d5cdaffee
Re skip debug test
2023-11-09 16:19:11 -08:00
Zach Musgrave
3dbe3b1660
Skip a failing test
2023-11-09 16:18:05 -08:00
Zach Musgrave
8a9c4ee669
Skipped failing test
2023-11-09 16:17:07 -08:00
Aaron Son
d1ec1d5fc4
go/libraries/doltcore/remotesrv: Ensure we stop the gRPC server and cancel inflight requests when we are multiplexing one port for HTTP and gRPC traffic.
2023-11-09 15:54:37 -08:00
Zach Musgrave
1d15424624
Bug fix for iter construction
2023-11-09 15:51:15 -08:00
Zach Musgrave
0f66c5f718
Fix comment
2023-11-09 15:48:20 -08:00
Zach Musgrave
02078d32a2
Bug fix: need to make a row the length of the projections, not the length of physical columns
2023-11-09 15:28:09 -08:00
Aaron Son
ce592c4ddc
go/libraries/doltcore/env: Close sql-server.lock file after we open it for read.
2023-11-09 14:54:09 -08:00
Aaron Son
28c9d47a8e
go/libraries/doltcore/dtestutils/sql_server_driver: Ensure we add server name prefix on output log lines even after a server restart in a test.
2023-11-09 14:47:55 -08:00
Aaron Son
8eeb38bf21
go/libraries/doltcore/dtestutils/sql_server_driver: Ensure we add server name prefix on output log lines even after a server restart in a test.
2023-11-09 14:47:34 -08:00
Aaron Son
41bcbb93f7
go: filesys: Take a FileMode on WriteFile. Fix sql-server.lock file handling to not leak file handles and keep correct perms when creating the file.
2023-11-09 14:35:28 -08:00
Zach Musgrave
54d718b179
More tests
2023-11-09 13:15:31 -08:00
Zach Musgrave
a63c1588eb
Fixed a test defn
2023-11-09 13:09:20 -08:00
Zach Musgrave
5f66f8b603
Bug fix for rewriting the left-hand index
2023-11-09 13:06:03 -08:00
Aaron Son
f8bd026a92
Merge branch 'main' into aaron/mysqldb-atomic-file-write
2023-11-09 12:48:04 -08:00
James Cor
a3f4b5ecd9
bumping feature version ( #6985 )
...
Co-authored-by: James Cor <james@dolthub.com >
2023-11-09 12:22:04 -08:00
Zach Musgrave
fae0b1cc94
Another failing test
2023-11-09 12:16:56 -08:00
Zach Musgrave
449d1bc97d
bug fix for validation of indexes for schemas that include virtual cols
2023-11-09 11:31:13 -08:00
Zach Musgrave
dfcd5817e9
Bug fixes for not skipping over virtual columns when doing merges
2023-11-09 09:49:29 -08:00
Zach Musgrave
b15c755fd9
New schema merge test
2023-11-09 09:20:44 -08:00
Zach Musgrave
48fceb315f
Bug fixes, correct some tests
2023-11-08 17:29:49 -08:00
Aaron Son
41b738fcdf
Change to use a crash resistant, atomic file update protocol for a number of file writes.
...
Makes updates to branch_control, repo_state.json and some persisted config
files atomic and crash resistant.
2023-11-08 15:18:34 -08:00
Zach Musgrave
1bcc976901
New approach for default vals
2023-11-08 15:18:27 -08:00
reltuk
b424f28291
[ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/update.sh
2023-11-08 23:11:06 +00:00
Aaron Son
a6d05f75d6
go/libraries/doltcore/sqle/mysql_file_handler: Change the permissions for the file used to store users and grants to 0600 instead of 0777.
2023-11-08 15:01:27 -08:00
Aaron Son
53d05f4a60
go/libraries/doltcore/sqle/mysql_file_handler: fsync the directory inode after the chmod+rename.
2023-11-08 14:58:38 -08:00
Aaron Son
1aae1b24bc
go/libraries/doltcore/sqle/mysql_file_handler: Change the write procedure for MySQLDb, the persisted privileges of the database, to be crash resistant.
...
The USERs and GRANTs on a sql-server instance are stored in a separate file
from the Merkle DAG table data that makes up the Dolt databases themselves.
Previously, the contents of this file were not written in a crash reisistant
way, and they could be lost or corrupted after a crash or when taking a
block-device snapshot.
This change makes it so that every update to the persisted USERs and GRANTs of
a sql-server instance is atomic and durable with regards to the block device
that the persisted premissions are stored on.
2023-11-08 14:51:31 -08:00
Zach Musgrave
036692006b
Better default resolution
2023-11-08 12:27:24 -08:00
Zach Musgrave
29f5009317
Comment changes
2023-11-08 11:59:52 -08:00