Commit Graph

6602 Commits

Author SHA1 Message Date
Nick Tobey ebcaabc5b4 Rename ArgParser.TooManyArgsError to TooManyArgsErrorFunc 2023-04-19 11:36:18 -07:00
Nick Tobey 4f8ba2dda1 Merge branch 'main' of github.com:dolthub/dolt into nicktobey/merge-stored-proceduce-extra-params 2023-04-18 13:38:44 -07:00
Nick Tobey c0a8cb33d2 Fix typo in parser.go error string. 2023-04-18 11:49:35 -07:00
Nick Tobey 19ef9a1d21 ArgParser now takes the name of the command being parsed.
This allows us to print the command name in error messages and disambiguate cases where `dolt_sql` calls a procedure that corresponds to another dolt command.
2023-04-18 11:45:58 -07:00
Nick Tobey f73e7d98f1 Revert "Add error when commands have extra arguments." 2023-04-17 14:36:05 -07:00
Nick Tobey 62bef8d972 Merge pull request #5753 from dolthub/nicktobey/merge-stored-proceduce-extra-params
Add error when commands have extra arguments.
2023-04-17 14:12:25 -07:00
Jason Fulghum ac61d0ea79 Merge pull request #5626 from dolthub/fulghum/schema-merge
Schema merge support for adding/dropping/renaming/reordering columns
2023-04-17 14:03:04 -07:00
Jason Fulghum 375ae93fc7 Adding a check for primary index and secondary index row count to ensure the secondary index doesn't contain extra, bogus data. 2023-04-17 12:34:37 -07:00
Tim Sehn 1b920087a8 Merge pull request #5760 from dolthub/tim/fix-typo
Fix error message in remote command
2023-04-17 12:23:51 -07:00
Jason Fulghum cf297bfe29 Updating skipped test 2023-04-17 11:54:10 -07:00
Tim Sehn a99d4a0dc4 Fix error message in remote command 2023-04-17 11:09:55 -07:00
Jason Fulghum 1f56259a9c Adding a skipped test for a new case found while testing 2023-04-17 11:06:25 -07:00
Jason Fulghum e9190e613d Passing ctx param 2023-04-17 09:58:23 -07:00
Nick Tobey 6b2bec33b3 Allow any number of arguments when MaxArgs is set to -1. 2023-04-14 15:23:54 -07:00
Nick Tobey b6abad268b Allow commands to specify a more helpful error message when too many args are passed. 2023-04-14 14:45:11 -07:00
Nick Tobey ed1e44a814 Merge branch 'main' of github.com:dolthub/dolt into nicktobey/merge-stored-proceduce-extra-params 2023-04-14 10:19:23 -07:00
Nick Tobey 9fad10d8fe Replace argparser.NewArgParser with NewArgParserWithMaxArgs and NewArgParserWithVariableArgs
This requires commands to specify the max number of positional arguments they expect.
This makes it harder to accidentally accept extra arguments and ignore them.
2023-04-14 10:18:33 -07:00
Maximilian Hoffman 3843fe40a3 [no-release-notes] Refactor RowIter builder (#5737)
* [ga-bump-dep] Bump dependency in Dolt by timsehn

* fix test

* fix bats test

* fix test

* Revert "fix test"

This reverts commit 27c9a31c6b.

* Refactor RowIter builder

* [ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/update.sh

* GMS bump

* [ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/update.sh

* restore proto

* simpler

* [ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/update.sh

* edits

* sort in marshalToString of noms json value

* interface refactors

* remove local ref

* [ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/update.sh

* bump dump procs fix

* [ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/update.sh

* fix manual ordering of json result of fk and unique key violations in new format

* [ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/update.sh

* no proto

* bump

* [ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/update.sh

---------

Co-authored-by: timsehn <tim@dolthub.com>
Co-authored-by: jennifersp <jennifer@dolthub.com>
Co-authored-by: max-hoffman <max-hoffman@users.noreply.github.com>
Co-authored-by: jennifersp <jennifersp@users.noreply.github.com>
2023-04-14 08:59:59 -07:00
jennifersp 612201a938 support EVENT storage handling (#5717) 2023-04-13 23:54:11 -07:00
Nick Tobey 8a33ee716f Update uses of go-mysql-server error objects to point to new package. (#5742) 2023-04-13 19:43:21 -07:00
Tim Sehn 766ca0992c Merge pull request #5734 from dolthub/zachmu/diff-panic
Fixed panic in dolt_commit_diff tables when referring to commits where the table doesn't exist
2023-04-13 16:19:06 -07:00
Dustin Brown 8f7459f524 [auto-bump] [no-release-notes] dependency by timsehn (#5727) 2023-04-13 15:57:57 -07:00
AndyA 135bdbd424 Merge pull request #5733 from dolthub/zachmu/autoinc-bug
Fixed a bug in auto increment tracking
2023-04-13 15:35:47 -07:00
Jason Fulghum 8ad8f3bd61 More minor cleanup 2023-04-13 14:52:09 -07:00
Jason Fulghum 604b444097 Follow up fixes from merge from main 2023-04-13 14:40:44 -07:00
Jason Fulghum 0b6b06da25 Merge branch 'main' into fulghum/schema-merge 2023-04-13 14:38:12 -07:00
AndyA e1721a2e1f Merge pull request #5728 from dolthub/andy/uniq-validate
go/libraries/doltcore/merge: refactored unique index validation
2023-04-13 10:24:44 -07:00
Andy Arthur db8166a23f go/doltcore/sqle/index: fix copyright header for key_builder_test.go 2023-04-13 10:00:01 -07:00
Andy Arthur 26817133c3 go/doltcore/merge: fix for issue #4547 2023-04-12 17:51:38 -07:00
Andy Arthur 0aa5a48aff go/doltcore/sqle/index: fix off-by-one in key converter, unskip keyless merge tests 2023-04-12 17:16:32 -07:00
Andy Arthur c91f4ec04f go: factored out common patterns for index key conversion, uniq key validation 2023-04-12 16:46:41 -07:00
zachmu 4a063cdbb6 [ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/update.sh 2023-04-12 22:02:37 +00:00
Zach Musgrave 7d5e99a528 Fixed panic in dolt_commit_diff tables when referring to commits where the table doesn't exist 2023-04-12 15:00:32 -07:00
zachmu 8d9a64876f [ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/update.sh 2023-04-12 19:59:42 +00:00
Zach Musgrave e31d29ba61 Consider remote refs when determining a table's auto increment 2023-04-12 12:30:59 -07:00
Andy Arthur 5b5206b340 go/doltcore/sqle/enginetest: repro for issue #5719 2023-04-12 11:51:36 -07:00
Zach Musgrave 926c97a01b Merge pull request #5708 from dolthub/zachmu/kill-repo-state
[no-release-notes] got rid of the last uses of UpdateWorkingRoot, UpdateStagedRoot
2023-04-12 11:38:59 -07:00
Andy Arthur 9695a8cdb4 go/doltcore/merge: refactored uniq index validation, keyless tables still todo 2023-04-11 17:52:40 -07:00
Zach Musgrave 7b641b36d1 Refactored reset command to not be such a readability disaster 2023-04-11 12:31:04 -07:00
Zach Musgrave bb71faa8ec Bug fix for reset hard 2023-04-11 12:19:02 -07:00
Zach Musgrave 07f23362a8 Bug fix that broke checkout 2023-04-10 18:04:20 -07:00
Zach Musgrave 709d646891 Bug fix 2023-04-10 17:21:51 -07:00
zachmu 94087615d0 [ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/update.sh 2023-04-10 23:05:36 +00:00
Zach Musgrave 6e5b68ae27 Bug fixes 2023-04-10 16:01:53 -07:00
zachmu 0d3489df62 [ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/update.sh 2023-04-10 22:28:18 +00:00
Zach Musgrave c06169e6b5 Fixed some comments 2023-04-10 15:22:46 -07:00
Zach Musgrave 3d04770f7b Bug fixes in dolt checkout. Also fixed a major oversight in doltEnv.UpdateWorkingSet, that's a yikes from me 2023-04-10 14:37:09 -07:00
Maximilian Hoffman af4d8eeaba Lookup int out of range error (#5690)
* Fix lookup type error

* reset old file

* bump GMS

* update to GMS bump

* get updates

* bump

* bump

* syntax error

* [ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/update.sh

* tidy

* go-sql-server tidy

* unnecessary test

* fix int_test

* bump

* bump

* skip ld convert

* ld enginetests

---------

Co-authored-by: max-hoffman <max-hoffman@users.noreply.github.com>
2023-04-07 17:11:14 -07:00
zachmu 4bc64f35e0 [ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/update.sh 2023-04-07 22:38:31 +00:00
Zach Musgrave 3d098e9b28 Removed unused parts of session state adapter 2023-04-07 15:24:31 -07:00