ef77c9e31e
[ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/update.sh
2025-02-05 20:14:49 +00:00
79b6e1d23d
Bug repro from dolthub
2025-02-05 12:05:31 -08:00
3fa6a29735
[kvexec] literal types cast to lookup expr type ( #8808 )
2025-02-04 14:05:20 -08:00
094fc7b3f6
[kvexec] fix left join nullability bug ( #8812 )
2025-02-04 14:05:01 -08:00
04498d5544
Merge pull request #8732 from dolthub/fulghum/journal
...
Tidy up journal writer code comments and error handling
2025-02-04 12:28:42 -08:00
c0c9c64e4f
PR Feedback: Making processJournalRecords() less aggressive on error'ing out for invalid journal records, to preserve graceful crash consistency
2025-02-04 11:55:06 -08:00
55001efed8
Tidying up journal writer code comments and error handling
2025-02-04 11:55:06 -08:00
b4b6d7110a
Merge pull request #8783 from dolthub/nicktobey/lazy-load
...
Avoid loading DB for commands where it's not necessary.
2025-02-03 15:02:48 -08:00
00cacf4ea6
printf
2025-02-03 13:54:04 -08:00
3cf7df20d9
print start server log
2025-02-03 13:14:03 -08:00
2911085fc0
Merge remote-tracking branch 'origin/main' into nicktobey/lazy-load
2025-02-03 12:45:10 -08:00
3d5d419cef
Update tag_test.go
2025-02-03 12:13:49 -08:00
b44469d58f
go: sqle/remotesrv.go: Fix session lifecycle callbacks interceptors.
2025-02-03 10:25:42 -08:00
52b625f3f2
Merge remote-tracking branch 'origin/main' into aaron/dsess-lifecycle
2025-02-03 10:01:27 -08:00
ed1af8feeb
Merge pull request #8805 from dolthub/aaron/binlog-tests-parallel
...
[no-release-notes] go: binlogreplication: tests: Parallelize the test suite, slightly improve process management.
2025-01-31 15:03:02 -08:00
f131fb8f0b
go/libraries/doltcore/sqle/binlogreplication: Fix windows build tags.
2025-01-31 13:42:13 -08:00
0ef447e2a0
Merge pull request #8797 from dolthub/aaron/sql-server-remotesapi-session-lifecycle
...
[no-release-notes] go: sqle,remotesrv: Implement sql.Session lifecycle callbacks for sql.Contexts used in remotesrv RPCs.
2025-01-31 13:27:17 -08:00
f33c9fcbf4
Merge pull request #8801 from dolthub/aaron/ivff-gc
...
go: store/types: Fix dolt_gc on databases that use vector indexes.
2025-01-31 13:26:57 -08:00
16ae96b4c6
[no-release-notes] go: binlogreplication: tests: Parallelize the test suite, slightly improve process management.
...
Move the global state to a harness struct, and change all interactions to go
through the harness, so that we can run these tests in parallel.
We also clean up the process management a bit, since it was subject to leaving
straggling sql-server and mysqld instances for me, usually because I would ^C
it when it took too long after I ran `go test ./...`. The two major changes
are:
1) In the happy case, we now gracefully terminate the child and assert that it
exited success.
2) We now explicitly try to get helpful signals to all children when the test
binary itself receives a SIGINT.
2025-01-31 13:22:07 -08:00
3821a7a410
Include deleteErr message in returned error.
2025-01-31 11:14:00 -08:00
9fd5d56c5b
[ga-bump-dep] Bump dependency in Dolt by Hydrocharged
2025-01-31 11:07:12 +00:00
b1aa361eed
Merge remote-tracking branch 'origin/main' into nicktobey/lazy-load
2025-01-30 15:21:30 -08:00
b9f6a56cf9
go: sqle: dprocedures: dolt_gc: Get the safepoint controller from the session. Fixes special-case lifecycle for dolt_gc procedure.
2025-01-30 13:44:33 -08:00
f79db4a576
[ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/update.sh
2025-01-30 20:13:23 +00:00
5826451024
Merge remote-tracking branch 'origin/main' into aaron/dsess-lifecycle
2025-01-30 11:58:56 -08:00
153d46b97f
go: sqle: gc_safepoint_controller: PR feedback, comments to explain some things.
2025-01-30 11:30:14 -08:00
337671ae3c
Merge pull request #8774 from dolthub/db/tags-3
...
/go/libraries/doltcore/env/actions: make iter resolved tags paginated sort in lexicographical order
2025-01-30 10:58:39 -08:00
ddaa922cf9
Fix typo in error message.
...
Co-authored-by: Maximilian Hoffman <max@dolthub.com >
2025-01-30 10:20:00 -08:00
3dd50f534d
Merge pull request #8796 from dolthub/aaron/gc-read-dependencies-oldgen-fixup
...
[no-release-notes] go/store/nbs: generational_chunk_store.go: In GCMode_Full, also take dependencies on chunks read from OldGen.
2025-01-30 10:19:16 -08:00
8356ba7ecc
go: store/types: Fix dolt_gc on databases that use vector indexes.
2025-01-30 10:15:06 -08:00
09dd814fd8
/go/libraries/doltcore/env/actions/tag.go: reinstage iterresolved tags for better deprecation process
2025-01-30 09:29:28 -08:00
cda466f022
/go/libraries/doltcore/env/actions: make iter resolved tags paginated, sort in lexicographical order
2025-01-29 14:52:59 -08:00
d27b998aaf
prevent nil panic on DoltEnv::loadDBOnce
2025-01-29 11:31:15 -08:00
819136d699
go: dtables: help_table: Manually specify that dolt_gc exists for now.
2025-01-29 09:45:36 -08:00
caaa4bd302
Merge pull request #8795 from dolthub/zachmu-3f5bb8c5
...
[auto-bump] [no-release-notes] dependency by zachmu
2025-01-28 23:29:12 -08:00
13c9ddf104
go: sqlserver,binlogreplication: Clean up session usage a little to have more principled lifecycle. Starting replication never uses the replcation execution context.
2025-01-28 16:58:38 -08:00
fc3217e92c
go: sqle: dolt_gc: Add DOLT_GC_SAFEPOINT_CONTROLLER_CHOICE env variable to control dolt_gc safepoint behavior.
...
This is a short-term setting which will allow choosing the session-aware
gc safepoint behavior, instead of the legacy behavior which kills all
in-flight connections when performing a GC.
2025-01-28 15:46:46 -08:00
bdc8ff1ab6
dolt_gc,dsess: Add VisitGCRoots to dsess.Session and call it from dolt_gc safepoint controller.
2025-01-28 15:12:54 -08:00
ef954d0425
go: sqle/dprocedures: dolt_gc: Implement a session aware safepoint controller.
2025-01-28 15:12:54 -08:00
915e392b10
go: sqle: dsess: Make DoltSession Lifecycle aware. Move towards a GCSafepointController which can work with it.
2025-01-28 15:12:54 -08:00
366e466a7e
go: sqle/dprocedures: dolt_gc: Move to an intantiated instance.
...
Allows dolt_gc implementation to carry state, such as a session
manager. This prepares for it to implement more robust GC safepoints.
2025-01-28 15:12:54 -08:00
c401029a75
Merge pull request #8794 from dolthub/aaron/sql-replication-session-lifecycle
...
[no-release-notes] go: binlogreplication: Add Session{{Begin,End}Command,End} lifecycle callbacks to the replica controller execution context session.
2025-01-28 14:55:12 -08:00
a6b1a269c9
go: sqle,remotesrv: Implement sql.Session lifecycle callbacks for sql.Contexts used in remotesrv RPCs.
...
This PR changes each RPC invocation against the gRPC and HTTP servers
implementing remotesapi and cluster replication to create a sql.Context
which lives the duration of the call. The Session for that call gets
SessionCommand{Begin,End} and SessionEnd lifecycle callbacks so that it
can participate in GC safepoint rendezvous appropriately.
Previously the remotesrv.DBCache and the user/password remotesapi
authentication implementation would simply create new sql.Contexts
whenever they needed them. There could be multiple sql.Contexts for the
single server call.
2025-01-28 14:28:44 -08:00
5b55d324e3
go: sqlserver: Clean up how remotesrv gets a handle to the mrEnv.FileSystem, remove the confusing indirection through ctxFactory.
2025-01-28 13:30:47 -08:00
1b594208aa
go/store/nbs: generational_chunk_store.go: In GCMode_Full, also take dependencies on chunks read from OldGen.
2025-01-28 12:02:24 -08:00
78e9a8a633
Merge pull request #8760 from dolthub/aaron/gc-read-dependencies
...
[no-release-notes] go/store/nbs: During a GC process, take dependencies on chunks that are read through the ChunkStore.
2025-01-28 12:02:07 -08:00
4895747d11
[ga-bump-dep] Bump dependency in Dolt by zachmu
2025-01-28 18:30:59 +00:00
89eb2afb7c
go: cmd/dolt: sqlengine: Actually call DoltBinlogReplicaController.Close when closing the SqlEngine.
2025-01-27 17:57:35 -08:00
003e2d1411
go: binlogreplication: Add Session{{Begin,End}Command,End} lifecycle callbacks to the replica controller execution context session.
...
This makes small clean ups to the lifecycle around replica applier and the
ownership and lifecycle of the mysql.Conn read connection.
This PR also includes some changes to slightly improve the performance and
reliability of the tests when running them locally. In particular, some of the
changes include:
1) Since `go run ./cmd/dolt` takes about four seconds to validate the existing
cached build on my laptop, we just go ahead and use a cached build everywhere.
2) We use t.Log{f,} instead of fmt.Prin.. to improve the ergonomics of test
running and getting output from a failure in particular.
3) We try to minimize global process state changes like unnecessary `os.Chdir`
calls, since it would be nice to parallelize these tests eventually.
4) We get rid of the unused and seemingly unnecessary --socket= argument to
Dolt, where we had to use a directory not corresponding to $TMPDIR, for
example, because max pathlength on a sun_path on MacOS is 104 characters or
whatever.
2025-01-27 17:46:24 -08:00
bde0bf9fe0
[ga-bump-release] Update Dolt version to 1.48.0 and release v1.48.0
2025-01-28 00:01:37 +00:00
zachmu