Commit Graph

29 Commits

Author SHA1 Message Date
Neil Macneale IV 338997f624 PR Feedback 2024-03-13 17:07:03 -07:00
Neil Macneale IV 66da338dfe Clean up the redundant encoder 2024-03-12 17:35:24 -07:00
Neil Macneale IV f01cee4f28 Test changes to account for dropping nbs.addr 2024-03-12 17:35:24 -07:00
Aaron Son 7406c4658a go/store/nbs: Fix some quota leaks in conjoin, GC.
Adds a paranoid mode where we noisely detect unclosed table files. The mode can
be enabled by setting an environment variable.

Fixes some unit tests, including all of go/store/... to run cleanly under the
paranoid mode.

Changes the quota interface to:
* Release |sz int| bytes instead of requiring a []byte with the correct length
  to show up.
* Work with |int| instead of |uint64|, since MaxUint64 is never allocatable and
  MaxInt32+z is only allocatable on 64-bit platforms.
* Not return an error on Release(). Implementations should not fail to release
  quota.
2023-02-16 16:01:20 -08:00
Andy Arthur cbeb25e27f pr feedback 2022-11-04 11:23:24 -07:00
Andy Arthur 90fd4e6788 refactored MemoryQuotaProvider to manage buffers more directly 2022-11-03 17:03:51 -07:00
Dhruv Sringari 69c8021920 Push ReleaseQuota down into onHeapTableIndex Close() 2022-03-28 16:06:33 -07:00
Dhruv Sringari 6a1c332a19 fix tests 2022-02-15 10:20:21 -08:00
Dhruv Sringari c78e02b2b3 ordinals and prefixes should err 2022-02-09 19:03:57 -08:00
Aaron Son abffd995df go/libraries/doltcore/remotestorage: Interface for cache returns true if cache is full / truncated in size. 2021-10-04 16:51:58 -07:00
Lars Lehtonen ce633a4fad store/nbs: require.NoError replaces most assert.NoError 2021-03-09 14:05:54 -08:00
Aaron Son 84c3066348 go/**/*.go: Update copyright headers for company name change. 2020-11-02 10:17:02 -08:00
Aaron Son 623606c07c format_repo.sh 2020-10-14 17:06:32 -07:00
Aaron Son c713363972 go/store/nbs: Convert chunkReader interfaces from atomicerr/waitgroup to errgroup. 2020-10-14 16:17:08 -07:00
Aaron Son cbc28198b9 go/store/chunks: Convert ChunkStore GetMany interface to send results to callback instead of output channel. 2020-10-14 14:28:18 -07:00
Daylon Wilkins b5bb663233 Reference new org name and updated trigger logic 2020-09-25 15:35:04 -07:00
Brian Hendriks 55c2412db3 error changes (#7)
The existing noms codebase uses panics for signaling errors in most cases.  This is not idiomatic go, and it is not the optimal behavior when building cloud services, or products on top of noms as a panic in any go routine causes the entire process to exit.

This is a large step in removing panics, and bubbling errors up through the code.
2019-08-06 15:00:02 -07:00
Aaron Son 5fc6fd5d6a go: Update for dolt at root of repository. 2019-07-24 10:28:54 -07:00
Aaron Son 23a0f5a33e Merge remote-tracking branch 'origin/master' into aaron/dolt-3pdeps-license-fetching 2019-07-23 16:07:50 -07:00
Aaron Son 6619700b5a dolt/go: Add utils/repofmt/check_fmt.sh, and standardize goimports config across repository. 2019-07-23 11:59:06 -07:00
Aaron Son 732086a9c7 dolt/go: Add copyright notices to every file. For files from noms, retain and reference the previous copyright notice as well. 2019-07-22 17:06:35 -07:00
Brian Hendriks 46355538e3 more panics 2019-07-17 14:20:58 -07:00
Brian Hendriks 6f86048d02 more panic shit 2019-07-10 17:38:51 -07:00
Brian Hendriks 2deb36fddd PR feedback 2019-07-09 10:28:46 -07:00
Brian Hendriks ccddbc6354 removing more panics 2019-07-09 10:28:46 -07:00
Brian Hendriks 3694a68a49 test fix 2019-07-09 10:28:46 -07:00
Brian Hendriks 39592b523e table reader panics 2019-07-09 10:28:46 -07:00
Brian Hendriks de36628918 update paths 2019-06-21 12:06:08 -07:00
Brian Hendriks 6ae6d7e595 move store files to the structure we want 2019-06-21 11:55:01 -07:00