From 3434b5cf08d4a4d81b291190594b71b2af90b2fb Mon Sep 17 00:00:00 2001
From: Johannes <72809645+jobenjada@users.noreply.github.com>
Date: Mon, 29 Dec 2025 06:58:15 -0800
Subject: [PATCH] fix: tweak edit attributes for contact UI (#7046)

Co-authored-by: Dhruwang <dhruwangjariwala18@gmail.com>
---
 .../edit-contact-attributes-modal.tsx         | 37 ++++++++++---------
 .../components/segment-table-data-row.tsx     |  2 +-
 2 files changed, 20 insertions(+), 19 deletions(-)

diff --git a/apps/web/modules/ee/contacts/components/edit-contact-attributes-modal.tsx b/apps/web/modules/ee/contacts/components/edit-contact-attributes-modal.tsx
index 5f8a775175..11ac5202bc 100644
--- a/apps/web/modules/ee/contacts/components/edit-contact-attributes-modal.tsx
+++ b/apps/web/modules/ee/contacts/components/edit-contact-attributes-modal.tsx
@@ -218,33 +218,34 @@ export const EditContactAttributesModal = ({
                         <FormItem className="flex-1">
                           <FormLabel>{t("environments.contacts.attribute_value")}</FormLabel>
                           <FormControl>
-                            <Input
-                              {...valueField}
-                              placeholder={t("environments.contacts.attribute_value_placeholder")}
-                              className="w-full"
-                            />
+                            <div className="flex space-x-2">
+                              <Input
+                                {...valueField}
+                                placeholder={t("environments.contacts.attribute_value_placeholder")}
+                                className="w-full"
+                              />
+                              <div className="flex items-end pb-0.5">
+                                <Button
+                                  type="button"
+                                  variant="outline"
+                                  disabled={["email", "userId", "firstName", "lastName"].includes(field.key)}
+                                  size="sm"
+                                  onClick={() => handleRemoveAttribute(index)}
+                                  className="h-10 w-10 p-0">
+                                  <TrashIcon className="h-4 w-4" />
+                                </Button>
+                              </div>
+                            </div>
                           </FormControl>
                           <FormError />
                         </FormItem>
                       )}
                     />
-
-                    <div className="flex items-end pb-2">
-                      <Button
-                        type="button"
-                        variant="ghost"
-                        disabled={["email", "userId", "firstName", "lastName"].includes(field.key)}
-                        size="sm"
-                        onClick={() => handleRemoveAttribute(index)}
-                        className="h-10 w-10 p-0">
-                        <TrashIcon className="h-4 w-4" />
-                      </Button>
-                    </div>
                   </div>
                 ))}
               </div>
 
-              <Button type="button" variant="outline" onClick={handleAddAttribute} className="w-fit">
+              <Button type="button" variant="secondary" onClick={handleAddAttribute} className="w-fit">
                 <PlusIcon className="mr-2 h-4 w-4" />
                 {t("environments.contacts.add_attribute")}
               </Button>
diff --git a/apps/web/modules/ee/contacts/segments/components/segment-table-data-row.tsx b/apps/web/modules/ee/contacts/segments/components/segment-table-data-row.tsx
index d85511ec79..e1a0ff8282 100644
--- a/apps/web/modules/ee/contacts/segments/components/segment-table-data-row.tsx
+++ b/apps/web/modules/ee/contacts/segments/components/segment-table-data-row.tsx
@@ -29,7 +29,7 @@ export const SegmentTableDataRow = ({
     <>
       <button
         key={id}
-        className="grid h-12 w-full cursor-pointer grid-cols-7 content-center rounded-lg p-2 text-left transition-colors ease-in-out hover:bg-slate-100"
+        className="grid h-12 w-full cursor-pointer grid-cols-7 content-center p-2 text-left transition-colors ease-in-out hover:bg-slate-100"
         onClick={() => setIsEditSegmentModalOpen(true)}>
         <div className="col-span-4 flex items-center pl-6 text-sm">
           <div className="flex items-center gap-4">