From 4dfd15d6dd32de220948ee401b4439ec8c965731 Mon Sep 17 00:00:00 2001
From: Anshuman Pandey <54475686+pandeymangg@users.noreply.github.com>
Date: Thu, 17 Apr 2025 14:33:44 +0530
Subject: [PATCH] fix: adds no-cache header when debug mode is ON (#5405)

---
 packages/js-core/src/lib/common/api.ts                 | 3 +--
 packages/js-core/src/lib/common/tests/api.test.ts      | 2 +-
 packages/react-native/src/lib/common/api.ts            | 2 +-
 packages/react-native/src/lib/common/tests/api.test.ts | 2 +-
 4 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/packages/js-core/src/lib/common/api.ts b/packages/js-core/src/lib/common/api.ts
index 120d15c2d3..d4613c6eeb 100644
--- a/packages/js-core/src/lib/common/api.ts
+++ b/packages/js-core/src/lib/common/api.ts
@@ -12,13 +12,12 @@ export const makeRequest = async <T>(
 ): Promise<Result<T, ApiErrorResponse>> => {
   const url = new URL(appUrl + endpoint);
   const body = data ? JSON.stringify(data) : undefined;
-
   const res = await wrapThrowsAsync(fetch)(url.toString(), {
     method,
     headers: {
       "Content-Type": "application/json",
+      ...(isDebug && { "Cache-Control": "no-cache" }),
     },
-    ...(isDebug && { "Cache-Control": "no-cache" }),
     body,
   });
 
diff --git a/packages/js-core/src/lib/common/tests/api.test.ts b/packages/js-core/src/lib/common/tests/api.test.ts
index f1f5679056..8de1d0617e 100644
--- a/packages/js-core/src/lib/common/tests/api.test.ts
+++ b/packages/js-core/src/lib/common/tests/api.test.ts
@@ -164,8 +164,8 @@ describe("api.ts", () => {
         method: "GET",
         headers: {
           "Content-Type": "application/json",
+          "Cache-Control": "no-cache",
         },
-        "Cache-Control": "no-cache",
       });
     });
   });
diff --git a/packages/react-native/src/lib/common/api.ts b/packages/react-native/src/lib/common/api.ts
index 120d15c2d3..ff1a66423f 100644
--- a/packages/react-native/src/lib/common/api.ts
+++ b/packages/react-native/src/lib/common/api.ts
@@ -17,8 +17,8 @@ export const makeRequest = async <T>(
     method,
     headers: {
       "Content-Type": "application/json",
+      ...(isDebug && { "Cache-Control": "no-cache" }),
     },
-    ...(isDebug && { "Cache-Control": "no-cache" }),
     body,
   });
 
diff --git a/packages/react-native/src/lib/common/tests/api.test.ts b/packages/react-native/src/lib/common/tests/api.test.ts
index f1f5679056..8de1d0617e 100644
--- a/packages/react-native/src/lib/common/tests/api.test.ts
+++ b/packages/react-native/src/lib/common/tests/api.test.ts
@@ -164,8 +164,8 @@ describe("api.ts", () => {
         method: "GET",
         headers: {
           "Content-Type": "application/json",
+          "Cache-Control": "no-cache",
         },
-        "Cache-Control": "no-cache",
       });
     });
   });