From 5da6faa972a976c0113a2ce8096c9c29ba5d7ae2 Mon Sep 17 00:00:00 2001 From: Anshuman Pandey <54475686+pandeymangg@users.noreply.github.com> Date: Fri, 17 Jan 2025 19:28:15 +0530 Subject: [PATCH] fix: overlapping UI and translations (#4615) --- apps/web/modules/ee/contacts/components/csv-table.tsx | 10 ++++++---- packages/lib/messages/de-DE.json | 1 + packages/lib/messages/en-US.json | 1 + packages/lib/messages/fr-FR.json | 1 + packages/lib/messages/pt-BR.json | 1 + 5 files changed, 10 insertions(+), 4 deletions(-) diff --git a/apps/web/modules/ee/contacts/components/csv-table.tsx b/apps/web/modules/ee/contacts/components/csv-table.tsx index 4ba9bedf82..afdf85d2be 100644 --- a/apps/web/modules/ee/contacts/components/csv-table.tsx +++ b/apps/web/modules/ee/contacts/components/csv-table.tsx @@ -18,9 +18,11 @@ export const CsvTable = ({ data }: CsvTableProps) => { className="grid gap-4 border-b-2 border-slate-100 bg-slate-100 p-4 text-left" style={{ gridTemplateColumns: `repeat(${columns.length}, minmax(0, 1fr))` }}> {columns.map((header, index) => ( -
+ {header.replace(/_/g, " ")} -
+ ))} @@ -30,9 +32,9 @@ export const CsvTable = ({ data }: CsvTableProps) => { className="grid gap-4 border-b border-gray-200 bg-white p-4 text-left last:border-b-0" style={{ gridTemplateColumns: `repeat(${columns.length}, minmax(0, 1fr))` }}> {columns.map((header, colIndex) => ( -
+ {row[header]} -
+ ))} ))} diff --git a/packages/lib/messages/de-DE.json b/packages/lib/messages/de-DE.json index e38e2c9dda..c3ea7596fb 100644 --- a/packages/lib/messages/de-DE.json +++ b/packages/lib/messages/de-DE.json @@ -567,6 +567,7 @@ "this_action_will_be_triggered_when_the_page_is_loaded": "Diese Aktion wird ausgelöst, wenn die Seite geladen ist.", "this_action_will_be_triggered_when_the_user_scrolls_50_percent_of_the_page": "Diese Aktion wird ausgelöst, wenn der Benutzer 50% der Seite scrollt.", "this_action_will_be_triggered_when_the_user_tries_to_leave_the_page": "Diese Aktion wird ausgelöst, wenn der Benutzer versucht, die Seite zu verlassen.", + "this_is_a_code_action_please_make_changes_in_your_code_base": "Dies ist eine Code-Aktion. Bitte nehmen Sie Änderungen an Ihrem Code vor.", "this_is_a_code_action_you_can_only_change_the_description": "Das ist eine Code-Aktion. Du kannst nur die Beschreibung ändern.", "track_new_user_action": "Neue Benutzeraktion verfolgen", "track_user_action_to_display_surveys_or_create_user_segment": "Benutzeraktionen verfolgen, um Umfragen anzuzeigen oder Benutzersegmente zu erstellen.", diff --git a/packages/lib/messages/en-US.json b/packages/lib/messages/en-US.json index 5356ad5fb7..fa787804f2 100644 --- a/packages/lib/messages/en-US.json +++ b/packages/lib/messages/en-US.json @@ -567,6 +567,7 @@ "this_action_will_be_triggered_when_the_page_is_loaded": "This action will be triggered when the page is loaded.", "this_action_will_be_triggered_when_the_user_scrolls_50_percent_of_the_page": "This action will be triggered when the user scrolls 50% of the page.", "this_action_will_be_triggered_when_the_user_tries_to_leave_the_page": "This action will be triggered when the user tries to leave the page.", + "this_is_a_code_action_please_make_changes_in_your_code_base": "This is a code action. Please make changes in your code base.", "this_is_a_code_action_you_can_only_change_the_description": "This is a code action. You can only change the description.", "track_new_user_action": "Track New User Action", "track_user_action_to_display_surveys_or_create_user_segment": "Track user action to display surveys or create user segment.", diff --git a/packages/lib/messages/fr-FR.json b/packages/lib/messages/fr-FR.json index 65c8a95181..c751fcba69 100644 --- a/packages/lib/messages/fr-FR.json +++ b/packages/lib/messages/fr-FR.json @@ -567,6 +567,7 @@ "this_action_will_be_triggered_when_the_page_is_loaded": "Cette action sera déclenchée lorsque la page sera chargée.", "this_action_will_be_triggered_when_the_user_scrolls_50_percent_of_the_page": "Cette action sera déclenchée lorsque l'utilisateur fera défiler 50 % de la page.", "this_action_will_be_triggered_when_the_user_tries_to_leave_the_page": "Cette action sera déclenchée lorsque l'utilisateur essaiera de quitter la page.", + "this_is_a_code_action_please_make_changes_in_your_code_base": "Ceci est une action de code. Veuillez apporter des modifications à votre base de code.", "this_is_a_code_action_you_can_only_change_the_description": "Ceci est une action de code. Vous ne pouvez changer que la description.", "track_new_user_action": "Suivre l'action des nouveaux utilisateurs", "track_user_action_to_display_surveys_or_create_user_segment": "Suivre l'action de l'utilisateur pour afficher des enquêtes ou créer un segment d'utilisateur.", diff --git a/packages/lib/messages/pt-BR.json b/packages/lib/messages/pt-BR.json index 9f0454ae93..9c5bf68504 100644 --- a/packages/lib/messages/pt-BR.json +++ b/packages/lib/messages/pt-BR.json @@ -567,6 +567,7 @@ "this_action_will_be_triggered_when_the_page_is_loaded": "Essa ação vai ser disparada quando a página carregar.", "this_action_will_be_triggered_when_the_user_scrolls_50_percent_of_the_page": "Essa ação vai ser acionada quando o usuário rolar 50% da página.", "this_action_will_be_triggered_when_the_user_tries_to_leave_the_page": "Essa ação será acionada quando o usuário tentar sair da página.", + "this_is_a_code_action_please_make_changes_in_your_code_base": "Esta é uma ação de código. Por favor, faça alterações na sua base de código.", "this_is_a_code_action_you_can_only_change_the_description": "Essa é uma ação de código. Você só pode mudar a descrição.", "track_new_user_action": "Rastrear Ação de Novo Usuário", "track_user_action_to_display_surveys_or_create_user_segment": "Rastrear ações do usuário para exibir pesquisas ou criar segmento de usuários.",