From b86f837e78c90acadf3b89d384d88ecd81b09e5b Mon Sep 17 00:00:00 2001
From: Johannes <johannes@formbricks.com>
Date: Fri, 30 Jun 2023 17:12:59 +0200
Subject: [PATCH] fix response card not visible

---
 .../[surveyId]/edit/ResponseOptionsCard.tsx   | 47 ++++++++++---------
 .../{AudienceView.tsx => SettingsView.tsx}    |  8 ++--
 .../surveys/[surveyId]/edit/SurveyEditor.tsx  |  4 +-
 3 files changed, 30 insertions(+), 29 deletions(-)
 rename apps/web/app/environments/[environmentId]/surveys/[surveyId]/edit/{AudienceView.tsx => SettingsView.tsx} (79%)

diff --git a/apps/web/app/environments/[environmentId]/surveys/[surveyId]/edit/ResponseOptionsCard.tsx b/apps/web/app/environments/[environmentId]/surveys/[surveyId]/edit/ResponseOptionsCard.tsx
index 0a87863d07..fa78465fc4 100644
--- a/apps/web/app/environments/[environmentId]/surveys/[surveyId]/edit/ResponseOptionsCard.tsx
+++ b/apps/web/app/environments/[environmentId]/surveys/[surveyId]/edit/ResponseOptionsCard.tsx
@@ -1,5 +1,6 @@
 "use client";
 
+import SurveyEditor from "@/app/environments/[environmentId]/surveys/[surveyId]/edit/SurveyEditor";
 import type { Survey } from "@formbricks/types/surveys";
 import { Input, Label, Switch } from "@formbricks/ui";
 import { CheckCircleIcon } from "@heroicons/react/24/solid";
@@ -112,29 +113,31 @@ export default function ResponseOptionsCard({ localSurvey, setLocalSurvey }: Res
               </label>
             </div>
           )}
-          <div className="p-3 ">
-            <div className="ml-2 flex items-center space-x-1">
-              <Switch id="redirectUrl" checked={redirectToggle} onCheckedChange={handleRedirectCheckMark} />
-              <Label htmlFor="redirectUrl" className="cursor-pointer">
-                <div className="ml-2">
-                  <h3 className="text-sm font-semibold text-slate-700">Redirect on completion</h3>
-                  <p className="text-xs font-normal text-slate-500">
-                    Redirect user to specified link on survey completion
-                  </p>
-                </div>
-              </Label>
+          {localSurvey.type === "link" && (
+            <div className="p-3 ">
+              <div className="ml-2 flex items-center space-x-1">
+                <Switch id="redirectUrl" checked={redirectToggle} onCheckedChange={handleRedirectCheckMark} />
+                <Label htmlFor="redirectUrl" className="cursor-pointer">
+                  <div className="ml-2">
+                    <h3 className="text-sm font-semibold text-slate-700">Redirect on completion</h3>
+                    <p className="text-xs font-normal text-slate-500">
+                      Redirect user to specified link on survey completion
+                    </p>
+                  </div>
+                </Label>
+              </div>
+              <div className="mt-4">
+                {redirectToggle && (
+                  <Input
+                    type="url"
+                    placeholder="https://www.example.com"
+                    value={redirectUrl ? redirectUrl : ""}
+                    onChange={(e) => handleRedirectUrlChange(e.target.value)}
+                  />
+                )}
+              </div>
             </div>
-            <div className="mt-4">
-              {redirectToggle && (
-                <Input
-                  type="url"
-                  placeholder="https://www.example.com"
-                  value={redirectUrl ? redirectUrl : ""}
-                  onChange={(e) => handleRedirectUrlChange(e.target.value)}
-                />
-              )}
-            </div>
-          </div>
+          )}
         </div>
       </Collapsible.CollapsibleContent>
     </Collapsible.Root>
diff --git a/apps/web/app/environments/[environmentId]/surveys/[surveyId]/edit/AudienceView.tsx b/apps/web/app/environments/[environmentId]/surveys/[surveyId]/edit/SettingsView.tsx
similarity index 79%
rename from apps/web/app/environments/[environmentId]/surveys/[surveyId]/edit/AudienceView.tsx
rename to apps/web/app/environments/[environmentId]/surveys/[surveyId]/edit/SettingsView.tsx
index 4a5759ab0b..9d96432cf1 100644
--- a/apps/web/app/environments/[environmentId]/surveys/[surveyId]/edit/AudienceView.tsx
+++ b/apps/web/app/environments/[environmentId]/surveys/[surveyId]/edit/SettingsView.tsx
@@ -5,13 +5,13 @@ import ResponseOptionsCard from "./ResponseOptionsCard";
 import WhenToSendCard from "./WhenToSendCard";
 import WhoToSendCard from "./WhoToSendCard";
 
-interface AudienceViewProps {
+interface SettingsViewProps {
   environmentId: string;
   localSurvey: Survey;
   setLocalSurvey: (survey: Survey) => void;
 }
 
-export default function AudienceView({ environmentId, localSurvey, setLocalSurvey }: AudienceViewProps) {
+export default function SettingsView({ environmentId, localSurvey, setLocalSurvey }: SettingsViewProps) {
   return (
     <div className="mt-12 space-y-3 p-5">
       <HowToSendCard
@@ -32,9 +32,7 @@ export default function AudienceView({ environmentId, localSurvey, setLocalSurve
         environmentId={environmentId}
       />
 
-      {localSurvey.type === "link" && (
-        <ResponseOptionsCard localSurvey={localSurvey} setLocalSurvey={setLocalSurvey} />
-      )}
+      <ResponseOptionsCard localSurvey={localSurvey} setLocalSurvey={setLocalSurvey} />
 
       <RecontactOptionsCard
         localSurvey={localSurvey}
diff --git a/apps/web/app/environments/[environmentId]/surveys/[surveyId]/edit/SurveyEditor.tsx b/apps/web/app/environments/[environmentId]/surveys/[surveyId]/edit/SurveyEditor.tsx
index 8d9cc9d560..eaaa1d7d0d 100644
--- a/apps/web/app/environments/[environmentId]/surveys/[surveyId]/edit/SurveyEditor.tsx
+++ b/apps/web/app/environments/[environmentId]/surveys/[surveyId]/edit/SurveyEditor.tsx
@@ -7,7 +7,7 @@ import type { Survey } from "@formbricks/types/surveys";
 import { ErrorComponent } from "@formbricks/ui";
 import { useEffect, useState } from "react";
 import PreviewSurvey from "../../PreviewSurvey";
-import AudienceView from "./AudienceView";
+import SettingsView from "./SettingsView";
 import QuestionsAudienceTabs from "./QuestionsAudienceTabs";
 import QuestionsView from "./QuestionsView";
 import SurveyMenuBar from "./SurveyMenuBar";
@@ -67,7 +67,7 @@ export default function SurveyEditor({ environmentId, surveyId }: SurveyEditorPr
               environmentId={environmentId}
             />
           ) : (
-            <AudienceView
+            <SettingsView
               environmentId={environmentId}
               localSurvey={localSurvey}
               setLocalSurvey={setLocalSurvey}