From b9d62f6af210c4346bb5e0ddfbf294a0b4c36e5a Mon Sep 17 00:00:00 2001
From: Piyush Jain <122745947+d3vb0ox@users.noreply.github.com>
Date: Wed, 7 May 2025 13:15:57 +0530
Subject: [PATCH] fix: pin version 1 of helmfile actions (#5691)

---
 .github/workflows/deploy-formbricks-cloud.yml             | 8 +++++---
 .github/workflows/formbricks-release.yml                  | 2 +-
 .../{helmfile.yaml => helmfile.yaml.gotmpl}               | 4 ++--
 infra/formbricks-cloud-helm/values-staging.yaml.gotmpl    | 2 +-
 4 files changed, 9 insertions(+), 7 deletions(-)
 rename infra/formbricks-cloud-helm/{helmfile.yaml => helmfile.yaml.gotmpl} (89%)

diff --git a/.github/workflows/deploy-formbricks-cloud.yml b/.github/workflows/deploy-formbricks-cloud.yml
index a0a1f9312a..a4d46c259f 100644
--- a/.github/workflows/deploy-formbricks-cloud.yml
+++ b/.github/workflows/deploy-formbricks-cloud.yml
@@ -4,7 +4,7 @@ on:
   workflow_dispatch:
     inputs:
       VERSION:
-        description: 'The version of the Docker image to release'
+        description: 'The version of the Docker image to release, full image tag if image tag is v0.0.0 enter v0.0.0.'
         required: true
         type: string
       REPOSITORY:
@@ -67,7 +67,7 @@ jobs:
 
       - uses: helmfile/helmfile-action@v2
         name: Deploy Formbricks Cloud Prod
-        if: (github.event_name == 'workflow_call' || github.event_name == 'workflow_dispatch') && github.event.inputs.ENVIRONMENT == 'prod'
+        if: inputs.ENVIRONMENT == 'prod'
         env:
           VERSION: ${{ inputs.VERSION }}
           REPOSITORY: ${{ inputs.REPOSITORY }}
@@ -75,6 +75,7 @@ jobs:
           FORMBRICKS_INGRESS_CERT_ARN: ${{ secrets.FORMBRICKS_INGRESS_CERT_ARN }}
           FORMBRICKS_ROLE_ARN: ${{ secrets.FORMBRICKS_ROLE_ARN }}
         with:
+          helmfile-version: 'v1.0.0'
           helm-plugins: >
             https://github.com/databus23/helm-diff,
             https://github.com/jkroepke/helm-secrets
@@ -84,13 +85,14 @@ jobs:
 
       - uses: helmfile/helmfile-action@v2
         name: Deploy Formbricks Cloud Stage
-        if: github.event_name == 'workflow_dispatch' && github.event.inputs.ENVIRONMENT == 'stage'
+        if: inputs.ENVIRONMENT == 'stage'
         env:
           VERSION: ${{ inputs.VERSION }}
           REPOSITORY: ${{ inputs.REPOSITORY }}
           FORMBRICKS_INGRESS_CERT_ARN: ${{ secrets.STAGE_FORMBRICKS_INGRESS_CERT_ARN }}
           FORMBRICKS_ROLE_ARN: ${{ secrets.STAGE_FORMBRICKS_ROLE_ARN }}
         with:
+          helmfile-version: 'v1.0.0'
           helm-plugins: >
             https://github.com/databus23/helm-diff,
             https://github.com/jkroepke/helm-secrets
diff --git a/.github/workflows/formbricks-release.yml b/.github/workflows/formbricks-release.yml
index 30342b7dd0..68f45a88b5 100644
--- a/.github/workflows/formbricks-release.yml
+++ b/.github/workflows/formbricks-release.yml
@@ -30,5 +30,5 @@ jobs:
       - docker-build
       - helm-chart-release
     with:
-      VERSION: ${{ needs.docker-build.outputs.VERSION }}
+      VERSION: v${{ needs.docker-build.outputs.VERSION }}
       ENVIRONMENT: "prod"
diff --git a/infra/formbricks-cloud-helm/helmfile.yaml b/infra/formbricks-cloud-helm/helmfile.yaml.gotmpl
similarity index 89%
rename from infra/formbricks-cloud-helm/helmfile.yaml
rename to infra/formbricks-cloud-helm/helmfile.yaml.gotmpl
index 523c94cbc1..f89792787b 100644
--- a/infra/formbricks-cloud-helm/helmfile.yaml
+++ b/infra/formbricks-cloud-helm/helmfile.yaml.gotmpl
@@ -12,7 +12,7 @@ releases:
       - values.yaml.gotmpl
     set:
       - name: deployment.image.tag
-        value: v{{ requiredEnv "VERSION" }}
+        value: {{ requiredEnv "VERSION" }}
       - name: deployment.image.repository
         value: {{ requiredEnv "REPOSITORY" }}
     labels:
@@ -26,7 +26,7 @@ releases:
     createNamespace: true
     set:
       - name: deployment.image.tag
-        value: v{{ requiredEnv "VERSION" }}
+        value: {{ requiredEnv "VERSION" }}
       - name: deployment.image.repository
         value: {{ requiredEnv "REPOSITORY" }}
     labels:
diff --git a/infra/formbricks-cloud-helm/values-staging.yaml.gotmpl b/infra/formbricks-cloud-helm/values-staging.yaml.gotmpl
index df761fa12e..ac863158ae 100644
--- a/infra/formbricks-cloud-helm/values-staging.yaml.gotmpl
+++ b/infra/formbricks-cloud-helm/values-staging.yaml.gotmpl
@@ -145,7 +145,7 @@ ingress:
       paths:
         - path: /
           pathType: Prefix
-          serviceName: formbricks
+          serviceName: formbricks-stage
   ingressClassName: alb
 
 ## RBAC