mirror/formbricks
1
0
Fork 0
mirror of https://github.com/formbricks/formbricks.git synced 2026-04-22 19:39:01 -05:00
Code Issues Packages Projects Releases 164 Wiki Activity

fix: segment evaluation fix (#3043)

Browse Source
This commit is contained in:
Anshuman Pandey
2024-08-26 10:34:37 +05:30
committed by GitHub
parent 5443226e27
commit 4a6d7952a7
1 changed files with 15 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/lib/segment/service.ts
+15 -4
View File
@@ -680,20 +680,31 @@ export const evaluateSegment = async (
return false;
}
// We first evaluate all `and` conditions consecutively
let intermediateResults: boolean[] = [];
// Given that the first filter in every group/sub-group always has a connector value of "null",
// we initialize the finalResult with the result of the first filter.
let finalResult = resultPairs[0].result;
let currentAndGroupResult = resultPairs[0].result;
for (let i = 1; i < resultPairs.length; i++) {
const { result, connector } = resultPairs[i];
if (connector === "and") {
finalResult = finalResult && result;
currentAndGroupResult = currentAndGroupResult && result;
} else if (connector === "or") {
finalResult = finalResult || result;
intermediateResults.push(currentAndGroupResult);
currentAndGroupResult = result;
}
}
// Push the final `and` group result
intermediateResults.push(currentAndGroupResult);
// Now we can evaluate the `or` conditions
let finalResult = intermediateResults[0];
for (let i = 1; i < intermediateResults.length; i++) {
finalResult = finalResult || intermediateResults[i];
}
return finalResult;
} catch (error) {