fix: single survey card rerenders on tag add or delete (#2461)

Co-authored-by: Johannes <72809645+jobenjada@users.noreply.github.com>
This commit is contained in:
Piyush Gupta
2024-04-17 13:49:18 +05:30
committed by GitHub
parent 1bd9b8a485
commit 74b4be99a4
4 changed files with 9 additions and 4 deletions

View File

@@ -67,7 +67,9 @@ const ResponsePage = ({
const filters = useMemo(
() => getFormattedFilters(survey, selectedFilter, dateRange),
[survey, selectedFilter, dateRange]
// eslint-disable-next-line react-hooks/exhaustive-deps
[selectedFilter, dateRange]
);
const searchParams = useSearchParams();

View File

@@ -79,7 +79,9 @@ const SummaryPage = ({
const filters = useMemo(
() => getFormattedFilters(survey, selectedFilter, dateRange),
[survey, selectedFilter, dateRange]
// eslint-disable-next-line react-hooks/exhaustive-deps
[selectedFilter, dateRange]
);
useEffect(() => {

View File

@@ -89,7 +89,9 @@ export const CustomFilter = ({ survey }: CustomFilterProps) => {
const filters = useMemo(
() => getFormattedFilters(survey, selectedFilter, dateRange),
[survey, selectedFilter, dateRange]
// eslint-disable-next-line react-hooks/exhaustive-deps
[selectedFilter, dateRange]
);
const datePickerRef = useRef<HTMLDivElement>(null);

View File

@@ -33,7 +33,6 @@ export function getPrefillResponseData(
} catch (error) {
console.error(error);
}
// eslint-disable-next-line react-hooks/exhaustive-deps
}
export const checkValidity = (question: TSurveyQuestion, answer: any, language: string): boolean => {