From 74b4be99a4ad87ae01ccdd12d3b9b1064f010193 Mon Sep 17 00:00:00 2001 From: Piyush Gupta <56182734+gupta-piyush19@users.noreply.github.com> Date: Wed, 17 Apr 2024 13:49:18 +0530 Subject: [PATCH] fix: single survey card rerenders on tag add or delete (#2461) Co-authored-by: Johannes <72809645+jobenjada@users.noreply.github.com> --- .../(analysis)/responses/components/ResponsePage.tsx | 4 +++- .../[surveyId]/(analysis)/summary/components/SummaryPage.tsx | 4 +++- .../surveys/[surveyId]/components/CustomFilter.tsx | 4 +++- apps/web/app/s/[surveyId]/lib/prefilling.ts | 1 - 4 files changed, 9 insertions(+), 4 deletions(-) diff --git a/apps/web/app/(app)/environments/[environmentId]/surveys/[surveyId]/(analysis)/responses/components/ResponsePage.tsx b/apps/web/app/(app)/environments/[environmentId]/surveys/[surveyId]/(analysis)/responses/components/ResponsePage.tsx index afbd5a9c04..935bc5b26a 100644 --- a/apps/web/app/(app)/environments/[environmentId]/surveys/[surveyId]/(analysis)/responses/components/ResponsePage.tsx +++ b/apps/web/app/(app)/environments/[environmentId]/surveys/[surveyId]/(analysis)/responses/components/ResponsePage.tsx @@ -67,7 +67,9 @@ const ResponsePage = ({ const filters = useMemo( () => getFormattedFilters(survey, selectedFilter, dateRange), - [survey, selectedFilter, dateRange] + + // eslint-disable-next-line react-hooks/exhaustive-deps + [selectedFilter, dateRange] ); const searchParams = useSearchParams(); diff --git a/apps/web/app/(app)/environments/[environmentId]/surveys/[surveyId]/(analysis)/summary/components/SummaryPage.tsx b/apps/web/app/(app)/environments/[environmentId]/surveys/[surveyId]/(analysis)/summary/components/SummaryPage.tsx index e278a7d6d9..ea9deb2caa 100644 --- a/apps/web/app/(app)/environments/[environmentId]/surveys/[surveyId]/(analysis)/summary/components/SummaryPage.tsx +++ b/apps/web/app/(app)/environments/[environmentId]/surveys/[surveyId]/(analysis)/summary/components/SummaryPage.tsx @@ -79,7 +79,9 @@ const SummaryPage = ({ const filters = useMemo( () => getFormattedFilters(survey, selectedFilter, dateRange), - [survey, selectedFilter, dateRange] + + // eslint-disable-next-line react-hooks/exhaustive-deps + [selectedFilter, dateRange] ); useEffect(() => { diff --git a/apps/web/app/(app)/environments/[environmentId]/surveys/[surveyId]/components/CustomFilter.tsx b/apps/web/app/(app)/environments/[environmentId]/surveys/[surveyId]/components/CustomFilter.tsx index 797ba6bc46..b3797f1ec9 100755 --- a/apps/web/app/(app)/environments/[environmentId]/surveys/[surveyId]/components/CustomFilter.tsx +++ b/apps/web/app/(app)/environments/[environmentId]/surveys/[surveyId]/components/CustomFilter.tsx @@ -89,7 +89,9 @@ export const CustomFilter = ({ survey }: CustomFilterProps) => { const filters = useMemo( () => getFormattedFilters(survey, selectedFilter, dateRange), - [survey, selectedFilter, dateRange] + + // eslint-disable-next-line react-hooks/exhaustive-deps + [selectedFilter, dateRange] ); const datePickerRef = useRef(null); diff --git a/apps/web/app/s/[surveyId]/lib/prefilling.ts b/apps/web/app/s/[surveyId]/lib/prefilling.ts index cf7546f442..6d9a297652 100644 --- a/apps/web/app/s/[surveyId]/lib/prefilling.ts +++ b/apps/web/app/s/[surveyId]/lib/prefilling.ts @@ -33,7 +33,6 @@ export function getPrefillResponseData( } catch (error) { console.error(error); } - // eslint-disable-next-line react-hooks/exhaustive-deps } export const checkValidity = (question: TSurveyQuestion, answer: any, language: string): boolean => {